first program, could probably be better.....

Forum 2005-2010 (read only) Software Syntax & Programs
2

I'm impressed. If that is really from 3-4 days experience then you are well on the right track. My critique would consist of two points

  • If it isn't a variable don't declare it as a variable. Use a constant or a #define.
int Blue = 6; //Just two LEDs for testing
int Green = 5;

Your program isn't going to be replugging the LEDs to connect to different pins is it? :wink:

#define BLUE 6
#define GREEN 5
// -or-
const int blue = 6;
const int green 5;
  • Factor out repetitive code

Just like when you took algebra and factored (4x+2x) as 2(2x+x) so should you factor out common terms from your functions. You have got several loops like:

    for(int fadeValueG = 255; fadeValueG >=0; fadeValueG -=5) { // fade in from off to on
    analogWrite(Green, fadeValueG);  //write to Green LED pin          
    delay(30);  //Fade
    }

-- since they're so small this is a ridiculous nitpick (especially for someone as new to coding as you) but you could make your code a bit more expressive by making a generic fadeLED() function (have it take parameters of the pin of the led, start val, stop val, and step value) and then replace your loops with calls to fadeLED().

For a two-line loop it probably isn't worth it. But going forward you might see yourself doing copy&paste on something bigger and have it repeated 20 times in your code and then you find a bug and you need to go and..fix...it..20...times...

Lookin' good! ;D