[RESOLVED]Timer1 sketch not compiling under v1.61 IDE but compiles with v1.05-r2

Using Arduino Microcontrollers
1

The following sketch doesn't compile with IDE v 1.61 but compiles with v 1.05-r2:
The timer value is actually for 125 kHz because I was using this sketch to try something else and never
changed the file name.

This line is the part for 125 Khz: (everything else is from the 150 kHz sketch. Both freqs work fine)

OCR1A = 63; // =>f = 16 Mhz/[2*N*(1+ OCR1A)]=16Mhz/(2*64)=> OCR1A = 63; // =>f = 16 Mhz/[2*1*(1+ OCRnA)]=16Mhz/(2*66)=6563 (N=prescaler)

#############################################################
uno.name=Arduino Uno
uno.upload.protocol=arduino
uno.upload.maximum_size=32256
uno.upload.speed=115200
uno.bootloader.low_fuses=0xff
uno.bootloader.high_fuses=0xde
uno.bootloader.extended_fuses=0x05
uno.bootloader.path=optiboot
uno.bootloader.file=optiboot_atmega328.hex
uno.bootloader.unlock_bits=0x3F
uno.bootloader.lock_bits=0x0F
uno.build.mcu=atmega328p
uno.build.f_cpu=16000000L
uno.build.core=arduino
uno.build.variant=standard

##############################################################

  // backlight.c
// for NerdKits with ATmega168
// mrobbins@mit.edu
#define F_CPU 16000000
#include <stdio.h>
#include <avr/io.h>
#include <avr/interrupt.h>
#include <avr/pgmspace.h>
#include <inttypes.h>
const int PB1=9; //OC1A  Pin-9
const int PB2=10; //OC1B Pin-10
const int PB3=11; //OC2A Pin-11


// PIN DEFINITIONS:
//
// D9 -- OC1A -- backlight high-speed switchy thing (nFET gate)
// used to generate the high voltage supply
// D11 -- OC2A -- backlight low-speed switchy thing (nFET gate)
// used to pulse the AC to the electroluminescent

 
 
void setup()
{
       pinMode(PB1,OUTPUT);
       pinMode(PB2,OUTPUT);
       pinMode(PB3,OUTPUT);
 }      
       
void loop()
{
  // D9,D10, D11 as output
  DDRB |= (1<<PB1) | (1<<PB2) | (1<<PB3);
  
  // Timer1: Toggle CTC, 10-bit, non-inverting, clocked from CLK/1
  TCCR1A = (1<<COM1A0);
  TCCR1B = (1<<WGM12) | (1<<CS10);
  OCR1A = 63; // =>f = 16 Mhz/[2*1*(1+ OCRnA)]=16Mhz/(2*66)=65
  
  // Timer2: Toggle CTC, clocked from CLK/1024
  TCCR2A = (1<<COM2A0) | (1<<WGM21);
  TCCR2B = (1<<CS22) | (1<<CS21) | (1<<CS20);
  OCR2A = 12; // 175 Hz
  
}

v 1.61 Boards.txt file[/u] (UNO section only)[/b]
##############################################################

uno.name=Arduino Uno

uno.vid.0=0x2341
uno.pid.0=0x0043
uno.vid.1=0x2341
uno.pid.1=0x0001
uno.vid.2=0x2A03
uno.pid.2=0x0043

uno.vid.0x2A03.warning=Uncertified

uno.upload.tool=avrdude
uno.upload.protocol=arduino
uno.upload.maximum_size=32256
uno.upload.maximum_data_size=2048
uno.upload.speed=115200

uno.bootloader.tool=avrdude
uno.bootloader.low_fuses=0xFF
uno.bootloader.high_fuses=0xDE
uno.bootloader.extended_fuses=0x05
uno.bootloader.unlock_bits=0x3F
uno.bootloader.lock_bits=0x0F
uno.bootloader.file=optiboot/optiboot_atmega328.hex

uno.build.mcu=atmega328p
uno.build.f_cpu=16000000L
uno.build.board=AVR_UNO
uno.build.core=arduino
uno.build.variant=standard

##############################################################

v 1.05-r2 boards.txt file (UNO section only)
##############################################################

uno.name=Arduino Uno
uno.upload.protocol=arduino
uno.upload.maximum_size=32256
uno.upload.speed=115200
uno.bootloader.low_fuses=0xff
uno.bootloader.high_fuses=0xde
uno.bootloader.extended_fuses=0x05
uno.bootloader.path=optiboot
uno.bootloader.file=optiboot_atmega328.hex
uno.bootloader.unlock_bits=0x3F
uno.bootloader.lock_bits=0x0F
uno.build.mcu=atmega328p
uno.build.f_cpu=16000000L
uno.build.core=arduino
uno.build.variant=standard

##############################################################

FYI, I have Acronics Backup software and have backups of C drive for both versions so I can restore a backup with one version and then go back and test code under the other version as many times as necessary.
Sidenote: Freq is rock solid with xtal based UNO but ATtiny85 version of the same sketch is +/- 75 hz (0.06% deviation [60,000 PPM) with 16 Mhz PLL boards file)

see attached comiler verbose output file

Timer1_comiler output .txt (1.2 KB)

2 
const int PB1=9; //OC1A  Pin-9
const int PB2=10; //OC1B Pin-10
const int PB3=11; //OC2A Pin-11

In the new compiler, avr/io.h #includes avr/portpins.h, which defines PB1 and etc (as the tremendously useful "1")
The fact that these pin bit definitions were missing from the normal avr/iom238p.h was always a sort of anomaly, introduced (I think) when Atmel started generating individual files from .xml chip descriptions, instead of semi-manually. PB1 has always been defined for ATmega8 and ATmega168, for example.

3

That was almost Greek to me but if I got it right, you mean all I have to do is change PB1 to 1, PB2 to 2, etc. ?

4

It boils down to "PB1" through "PB7" are official names for the individual bits in PORTB, and you can't redefine them to refer to arduino "pin numbers" instead.
So you should use names other than PBn for your constants. I realize that in this case, that's a bit ... circular.
I might suggest "CHIPPIN_PB1"

5

Ok, thanks. I think I'll go with "CPU_PB1"

6

THAT WORKED ! Thanks ! (+1)

Here's the modified code that compiled without errors.
Note: I realized while pasting the "CPU_" in front of the variables that there was one line of code that should be left as it is:

 DDRB |= (1<<PB1) | (1<<PB2) | (1<<PB3);

I then realized that the problem was a name conflict between TIMER1 pins and digital output pins.

  // backlight.c
// for NerdKits with ATmega168
// mrobbins@mit.edu
#define F_CPU 16000000
#include <stdio.h>
#include <avr/io.h>
#include <avr/interrupt.h>
#include <avr/pgmspace.h>
#include <inttypes.h>
const int CPU_PB1=9; //OC1A  Pin-9
const int CPU_PB2=10; //OC1B Pin-10
const int CPU_PB3=11; //OC2A Pin-11


// PIN DEFINITIONS:
//
// D9 -- OC1A -- backlight high-speed switchy thing (nFET gate)
//		used to generate the high voltage supply
// D11 -- OC2A -- backlight low-speed switchy thing (nFET gate)
//		used to pulse the AC to the electroluminescent

 
 
void setup()
{
       pinMode(CPU_PB1,OUTPUT);
       pinMode(CPU_PB2,OUTPUT);
       pinMode(CPU_PB3,OUTPUT);
 }      
       
void loop()
{
  // D9,D10, D11 as output
  DDRB |= (1<<PB1) | (1<<PB2) | (1<<PB3);
  
  // Timer1: Toggle CTC, 10-bit, non-inverting, clocked from CLK/1
  TCCR1A = (1<<COM1A0);
  TCCR1B = (1<<WGM12) | (1<<CS10);
  OCR1A = 63; // =>f = 16 Mhz/[2*1*(1+ OCRnA)]=16Mhz/(2*66)=65
  
  // Timer2: Toggle CTC, clocked from CLK/1024
  TCCR2A = (1<<COM2A0) | (1<<WGM21);
  TCCR2B = (1<<CS22) | (1<<CS21) | (1<<CS20);
  OCR2A = 12; // 175 Hz
  
}

Thanks again for your help !