Help with GET request?

TheSpy7:
So the response is totally correct. It does not show the output of the GET request. The GET request DOES work in a browser. The response serial is just successful and then it says Great success!

How do you know the response is correct, if you haven't seen it?

This code looks as if it prints the response to the serial monitor:

  while (client.connected() || client.available()) { //connected or data available
    char c = client.read(); //gets byte from ethernet buffer
    Serial.print(c); //prints byte to serial monitor 
  }

Why is there no output from that code?

See, that's the problem. I have no idea why! It goes through and says "success" or whatever, but never ACTUALLY sends the GET request!

TheSpy7:
See, that's the problem. I have no idea why! It goes through and says "success" or whatever, but never ACTUALLY sends the GET request!

Well, I don't know whether it's sending it or not, and I don't suppose you do either.

You need to sort out sendGET() so it tells you what actually happened during the process of sending the request and receiving the response. So far you haven't posted any evidence to prove that the function is even being called at all.

Its not sending it, but it acts like it did send it successfully. I will try to see what debug I can get.

Are you using a proxy?

If you can get nc (or netcat) working on your system you can echo the messages sent to a local port, e.g.

nc -l 8000

[edit] Then change your parameters to connect to localhost your system's IP address port 8000 and see what happens.

spatula:
Are you using a proxy?

If you can get nc (or netcat) working on your system you can echo the messages sent to a local port, e.g.

nc -l 8000

Then change your parameters to connect to localhost port 8000 and see what happens.

Eh, not interested. I just want to know why the current code doesn't work.

It is required that you start the ethernet connection with Ethernet.begin(mac). You mention it with a comment, but never start it. I added it below.

void setup()
{
  // start the serial library:
  Serial.begin(9600);
  // set display brightness
  Serial.write(0x7C);
  Serial.write(157);
  // set screen size in case LCD gets derpy...
  Serial.write(0xFE);
  Serial.write(6);
  Serial.write(0xFE);
  Serial.write(4);
  delay(4000);

  // start the Ethernet connection:
  if(!Ethernet.begin(mac)) Serial.println("ethernet failed");
  else Serial.println(Ethernet.localIP());

  // set up soft reset button
  ////attachInterrupt(0, softReset, CHANGE);
  // clear screen
  clearDisplay();
}

TheSpy7:
Eh, not interested. I just want to know why the current code doesn't work.

Fine. I took the liberty of modifying my original suggestion because it was wrong.

Perhaps you might be more interested in persistent connections under HTTP/1.0.

TheSpy7:
See, that's the problem. I have no idea why! It goes through and says "success" or whatever, but never ACTUALLY sends the GET request!

Your code:

 if (client.connect(serverName, 80)) {  //starts client connection, checks for connection
    Serial.println("connected");

Do you see "connected"?

Later:

  Serial.println();
  Serial.println("disconnecting.");
  Serial.println("==================");
  Serial.println();
  client.stop(); //stop client

Do you see "disconnecting"?

Don't just vaguely describe what you see. Copy and paste it.

Christ, I apologise, I just need a solution!

"Apology accepted, Captain Needa".

Now what I need is for you to copy and paste your output.

Tweaked the code a bit. Here is new output followed by new code.

|þþþþþ?Phone number:þþ?Phone number:þþ?Phone number:þþ?Phone number:þþ?Phone number:þþ?Phone number:þþ?Phone number:þþ?Phone number:þþ?Phone number:þþ?Phone number:þþ?Phone number:þÀ1þþ?Phone number:þÀ1þþ?Phone number:þÀ1þþ?Phone number:þÀ11þþ?Phone number:þÀ11þþ?Phone number:þÀ11þþ?Phone number:þÀ111þþ?Phone number:þÀ111þþ?Phone number:þÀ1111þþ?Phone number:þÀ1111þþ?Phone number:þÀ11111þþ?Phone number:þÀ11111þþ?Phone number:þÀ11111þþ?Phone number:þÀ111111þþ?Phone number:þÀ111111þþ?Phone number:þÀ111111þþ?Phone number:þÀ1111111þþ?Phone number:þÀ1111111þþ?Phone number:þÀ11111111þþ?Phone number:þÀ11111111þþ?Phone number:þÀ11111111þþ?Phone number:þÀ111111111þþ?Phone number:þÀ111111111þþ?Phone number:þÀ111111111þþ?Trolling option:þþ?Trolling option:þþ?Trolling option:þþ?Trolling option:þþ?Trolling option:þÀRickrollþþ?Connecting...connection failed


disconnecting.
==================

þÀGreat Success!þ?þþ?Phone number:þþ?Phone number:þþ?Phone number:þþ?Phone number:þþ?Phone number:þþ?Phone number:þþ?Phone number:þþ?Phone number:þþ?Phone number:þþ?Phone number:þþ?Phone number:þþ?Phone number:þþ?Phone number:þþ?Phone number:þþ?Phone number:þþ?Phone number:þþ?Phone number:þþ?Phone number:þþ?Phone number:þþ?Phone number:þþ?Phone number:þþ?Phone number:þþ?Phone number:þþ?Phone number:þþ?Phone number:þþ?Phone number:þþ?Phone number:þþ?Phone number:þþ?Phone number:þþ?Phone number:þþ?Phone number:þþ?Phone number:þþ?Phone number:þþ?Phone number:þþ?Phone number:þþ?Phone number:þþ?Phone number:þþ?Phone number:
#include <SPI.h>
#include <Ethernet.h>
#include <Keypad.h>
#include <EthernetClient.h>
const byte ROWS = 4;
const byte COLS = 3;
const int DELAY_VAL = 2;
const int MAX_SHIFT_VAL = 1023;
int buttonState = 0; // soft reset button state
String phoneNumber = "";
String clip = "";

char keys[ROWS][COLS] = {
   {'1','2','3'}
  ,{'4','5','6'}
  ,{'7','8','9'}
  ,{'*','0','#'}
}; // map out the keys

// map out the pins
byte rowPins[ROWS] = {5,6,7,8};
byte colPins[COLS] = {2,3,4};

Keypad keypad = Keypad(makeKeymap(keys), rowPins, colPins, ROWS, COLS);

byte mac[] = { 0x90, 0xA2, 0xDA, 0x04, 0x00, 0x8D }; //physical mac address
byte subnet[] = {255,255,255,0};
byte gateway[] = {192,168,1,1};
char server[] = "www.api.tropo.com"; // zoomkat's test web page server

// instantiate a network client
EthernetClient client;

void setup()
{
  // start the serial library:
  Serial.begin(9600);
  // set display brightness
  Serial.write(0x7C);
  Serial.write(157);
  // set screen size in case LCD gets derpy...
  Serial.write(0xFE);
  Serial.write(6);
  Serial.write(0xFE);
  Serial.write(4);
  delay(4000);
  Ethernet.begin(mac, subnet, gateway);
  
  // start the Ethernet connection:
  // set up soft reset button

  ////attachInterrupt(0, softReset, CHANGE);
  // clear screen
  clearDisplay();
}

void loop()
{
  ////digitalWrite(softResetPin, LOW);
  // read the state of the reset button value:
  
  
  // check if the pushbutton is pressed (HIGH)
  
  
  delay(70); // delay loop to keep the LCD from redrawing stuff too much
  
 
  
  char keyPressed = keypad.getKey(); // need to check press selection on keypad

  if (keyPressed)
  {
    if (keyPressed == '#') // # and * are reveresed for some reason
    {
      clearDisplay();
      selectFirstLine();
      Serial.print("THE GAME");
      delay(500);
    }
    else if (keyPressed == '*')
    {
      clearDisplay();
      selectFirstLine();
      Serial.print("i said wut wut");
      selectSecondLine();
      Serial.print("in the *");
      delay(1000);
    }
    else
    {
      // check for complete number
      if (phoneNumber.length() == 10)
      {
        selectSecondLine();
        // determine which sound clip to play
        switch (keyPressed) 
        {
        case '1':
          Serial.print("Rickroll");
          clip = "dfs";
          break;
        case '2':
          Serial.print("Nyan Cat");
          clip = "fds";
          break;
        case '3':
          Serial.print("Still Alive");
          clip = "fds";
          break;
        case '4':
          Serial.print("Hurr Durr");
          clip = "dfsfds";
          break;
        case '5':
          Serial.print("Heyyeahyeah");
          clip = "sdf";
          break;
        case '6':
          Serial.print("Friday");
          clip = "sfd";
          break;
        case '7':
          Serial.print("Tiny Tim");
          clip = "dfs";
          break;
        case '8':
          Serial.print("Banana Phone"); // OH GOD WHAT HAVE I DONE
          clip = "fsd";
          break;
        case '9':
          Serial.print("Britney Rant");
          clip = "dsf";
          break;
        }
        
        delay(3000);
      }
      else
      {
        phoneNumber = phoneNumber + keyPressed;
      }
    }
  }
  else
  {
    clearDisplay();
    if (phoneNumber.length() == 10)
    {
      if (clip == "")
      {
        selectFirstLine();
        Serial.print("Trolling option:");
      }
      else
      {
        selectFirstLine();
        Serial.print("Connecting...");
        // proceed to lulz
        sendGET();
        delay(10000);
        // close connection to ensure proper re-connect
        client.stop();
        selectSecondLine();
          Serial.print("Great Success!");
          selectFirstLine();
          delay(5000);
          phoneNumber = "";
          clip = "";
      }
    }
    else
    {
      selectFirstLine();
      Serial.print("Phone number:");
      
      if (phoneNumber.length() > 0)
      {
        selectSecondLine();
        Serial.print(phoneNumber);
      }
    }
  }
}

void clearDisplay() {
  Serial.write(0xFE);
  Serial.write(0x01);
}

void selectFirstLine() {
  Serial.write(0xFE);
  Serial.write(128);
   //delay(10);
}

void selectSecondLine() {
  Serial.write(0xFE);
  Serial.write(192);
}

void sendGET() //client function to send/receive GET request data.
{
  if (client.connect(server, 80)) {  //starts client connection, checks for connection
    Serial.println("connected");
    client.println("GET /1.0/sessions?action=create&token=fsdfd&number=fsdfds2 HTTP/1.0"); //download text
    client.println("Host: www.api.tropo.com");
    client.println(); //end of get request
  } 
  else {
    Serial.println("connection failed"); //error message if no client connect
    Serial.println();
  }

  while(client.connected() && !client.available()) delay(1); //waits for data
  while (client.connected() || client.available()) { //connected or data available
    char c = client.read(); //gets byte from ethernet buffer
    Serial.print(c); //prints byte to serial monitor 
  }

  Serial.println();
  Serial.println("disconnecting.");
  Serial.println("==================");
  Serial.println();
  client.stop(); //stop client

}

What I see there that is relevant is this:

Connecting...connection failed


disconnecting.

Okay. So how do I fix the problem?

Okay. So how do I fix the problem?

There is nothing wrong with the code. The problem starts on the other end of the ethernet cable. You have not defined anything about that.

You have not said whether you are able to run the client example correctly. That would be a start.

Ethernet.begin(mac, subnet, gateway);

Wrong order of parameters, missing dns.

Did you read reply #13? It won't work until you call Ethernet.begin(mac) in the setup function.

edit: ...and called correctly.

TheSpy7:
Okay. So how do I fix the problem?

Uh, make it connect?

  // start the serial library:
  Serial.begin(9600);
  // set display brightness
  Serial.write(0x7C);
  Serial.write(157);
  // set screen size in case LCD gets derpy...
  Serial.write(0xFE);
  Serial.write(6);
  Serial.write(0xFE);
  Serial.write(4);

These Serial.writes will just produce garbage on the serial monitor. This is due to you having both the LCD and the monitor on Serial.

|þþþþþ?Phone number:þþ?Phone number:þþ

That accounts for the first group of garbage char's. The second and subsequent groups of garbage are coming from this

    }
    else
    {
      selectFirstLine();
      Serial.print("Phone number:");
      
      if (phoneNumber.length() > 0)
      {
        selectSecondLine();
        Serial.print(phoneNumber);
      }

I think, which means that phoneNumber has the crap in it. (or just maybe Serial.print() has a problem with String).
So and a debug statement to print out each key as you get it from the key pad i.e. in this bit of code

  delay(70); // delay loop to keep the LCD from redrawing stuff too much
  
 
  
  char keyPressed = keypad.getKey(); // need to check press selection on keypad

  if (keyPressed)