Opinions and improvements to my MotorControl-Function for the ArduinoMotorShield

Community Bar Sport
1

Hello guys,

This is my first self-written function (with Testingprogram) and I am interested in what you think about it and your suggestions for improvements.

void setup(){}

void loop(){
MotorControl(3, 12, 9, 155, HIGH, LOW);
delay(3000);
MotorControl(3,12,9,0,HIGH, HIGH);
delay(5000);
MotorControl(3,12,9,255,LOW, LOW);
delay(3000);
MotorControl(3, 12, 9, 0, HIGH, HIGH);
delay(1000);
}

void Motor(byte pinPWM, byte pinDirectionM, byte pinBrakeM, int value_PWM, boolean value_directionM, boolean value_brakeM){
constrain(value_PWM,0,255);
pinMode(pinBrakeM, OUTPUT);
pinMode(pinDirectionM, OUTPUT);
digitalWrite(pinBrakeM, value_brakeM);
digitalWrite(pinDirectionM, value_directionM);
analogWrite(pinPWM, value_PWM);
}

I wrote it in order to save space because I have to Control 6 different DC-Motors with an Arduino Mega + 3 MotorShields.

Thank you and sorry for my english :slight_smile: