Oh and this patch is meant for the standard Ethernet library, it doesn't work with Ethernet2 yet.
Will this patch find it's way to the official distribution?
I've only done a casual look at the Ethernet2 library, but from what I saw the Client::connect() code looked identical to the "official" library.
I'll be writing up this patch and submitting it to the developer's list. There are a couple of other bugs and enhancements that I'm still looking into.
-
The client can get into an unrecoverable state if the sketch opens connections and then fails to call client.stop() before issuing another client.connet(). After the fourth connect all sockets will be in use preventing any more connections. The insidious part is that there's no way to release the orphaned connections. Easily fixed by having the connect() return a fail result if there is already and active connection.
-
There are some situations where the client.stop() fails to disconnect and leaves an "ESTABLISHED" connection to the server. I'm still researching this.