Help me here, is this what you want to do?
Turn on a relay that powers a solenoid? The diode needs to be at the relay coil side. The solenoid? separate the 12V supply ground from arduino's. They don't have to and should not share grounds.
I only see the box (you held it in your hand in the other picture). Is the relay inside the box or is it outside your picture?