Need help with IF ELSE trigger for Nrf24L01+ Arduino Motor Shield

PaulS:
You are printing values AFTER the subroutines have mucked with them. That tells you nothing. Print them BEFORE calling the subroutines.

The value printed after motorReverse() looks screwy. After this code:

int motorReverse() {

val1 = map(val1, 135, 254, 0, 254);



val1 is -503. This means that the input was not in the range 135 to 254, which is clear from the fact that you call this function only when val1 is less than 110.

You need to explain the screwy mapping.

in loop

 if(val1 < 110 ){
    motorReverse();
  }
  else if(val1 > 135){
    motorForward();
}
  else{
    motorStop();
  }

Forward now

int motorForward() {

  val1 = map(val1, 135, 0, 100, 254);

Reverse now

int motorReverse() {
  val1 = map(val1, 110, 254, 0, 254);

Serial output is called in the external as just Forward/Back/Stop/L/R to see if and when they are triggering.
this is what it is now outputting.

Up
--------
Reverse: 
Stop: 
Forward: 
Stop: 
Reverse: 
Stop: 
Reverse: 
Stop: 
Forward: 
Stop: 
_________
Down
-------
Reverse: 
Stop: 
Reverse: 
Stop: 
Reverse: 
Stop: 
Reverse: 
Stop: 
Reverse: 
_________
Left
-------
Right: 
Stop: 
Right: 
Stop: 
Right: 
Stop: 
Right: 
Stop: 
Right: 
__________
Right
--------
Right: 
Stop: 
Right: 
Stop: 
Right: 
Stop: 
Right: 
Stop: 
Right: 
__________

Why is stop injecting between each call FsFsF RsRsRs etc with out skipping a beat and why is L/R only calling right function.