Show Posts
Pages: 1 [2] 3
16  Using Arduino / Project Guidance / Re: Audomatic Garage Door Close on: October 10, 2012, 03:25:24 pm
Does it work?

In general in cases like this:

Code:
if (DoorCloseWarn == true) {
    Warn(); // go to the Warn function

Booleans can only be true or false, so testing for "== true" is a bit redundant. How about:


Code:
if (DoorCloseWarn) {
    Warn(); // go to the Warn function

It does work... both my uncle (who I wrote it for) have tested it and it all seems to function correctly. Good point on the DoorCloseWarn == true.

Thanks,
 Adam
17  Using Arduino / Project Guidance / Re: Audomatic Garage Door Close on: October 10, 2012, 01:38:55 pm
Ok, went back to the drawing board a bit. I got rid of the goto, replaced it with a function, and also fixed the issue with the way I was referencing the state of the PINs. Using the suggestions given as guidance I was able to set it up so that there is a beep every x seconds while the override is active.

I'd be interested to hear your comments. 
18  Using Arduino / Project Guidance / Re: Audomatic Garage Door Close on: September 28, 2012, 11:41:33 am
About the goto alternative, you need to pick a good working logic and then decide, such as:

in the while loop, if certain condition is met, call an override function, which returns to the loop and the code continue to loop

or if with a different logic, you may decide to end the loop and then call the override function.

In any case, since the override code is pretty independent from other code, it can stay together as a function you can call.

It's best if you start with a flow diagram to specify how the program will run, and then write the code according to the flow diagram.

Thanks, I'm working on this and the other errors that were pointed out and I'll post back when done.
19  Using Arduino / Project Guidance / Re: Audomatic Garage Door Close on: September 27, 2012, 05:44:17 pm
... it felt like your first post was dedicated to detailing how stupid I am.

I want you to understand that I look at about 20 to 30 posts a day with programming questions. Once I read "it doesn't work" and browse through the code and see some obvious problems, for example where you are comparing pin numbers instead of reading from those pins and comparing the results, I usually quote the problem code, with a hint about how to fix it, and then stop reading. I'm not being paid for this, you know.

I never called you "stupid".

If I had really wanted to make you look small I would have kept going and found all the other errors (if any).

I'm a believer in teaching people to fish rather than giving them a fish, so I don't usually try to simply hand back corrected code.

You might want to reconsider telling someone on a forum they don't understand "the basics" especially when you say:

Quote
I'm not a programmer ...

If you are not a programmer, how do you know I don't understand the basics?

Well, first and foremost I do appreciate your time. You've pushed me to try to come up with something other than the goto. And you pointed out the issue with how I was reading the state of the PINs.

That said, in case you didn't see my other posts - I never said "it doesn't work" In fact what I said in my initial post was that it does work but that I'm not sure how to go about adding this specific function (that being a beep every x # of min. during the override).

Again, I honestly thought that you were telling me that I should not be naming/defining PINs. I'm sorry about my confusion on this but that's where my "basic stuff" quip came into play because I was siting here thinking "every single example I've looked at does this..." Hopefully that clears up why I said that and for what it's worth I take it back. You'll also have to excuse my confusion when you (and a number of other people) insisted that what I have will not work because coming into this it all did (including PIR1, PIR2 == HIGH). Now it's been pointed out that I may just not be testing enough to catch the error but I assure you that as far as I know it works. I will however make the corrections you and others have suggested.

Lastly, I'm not expecting to be spoon fed. Guidance is nice though.

Hope that we can move past the initial confusion and that once I figure out how to get my code working without the goto you'll be able to stomach my code smiley
20  Using Arduino / Project Guidance / Re: Audomatic Garage Door Close on: September 27, 2012, 05:07:58 pm
2) I understand that that the use of the goto is frowned upon (though I did not know hoe vehement people were about it  smiley). I used it 'cause it worked and as mentioned here (http://arduino.cc/en/Reference/Goto) I did not use in "unrestrained." I'm open to suggestions on how to eliminate this.

That was popular before structured programming paradigm came along to save the day when code became hundreds of lines long that resembles a certain type of poorly cooked Italian noodle. You have to have well-defined entrance and exit points in your code for debugging. It's not an optional writing style. I'll use language analogy once again. Goto was like middle English smiley

http://en.wikipedia.org/wiki/Structured_programming

Object-oriented programming didn't come out of a fad either. It was absolutely necessary to manage even larger projects and make code stay independent and reusable like modules. Then more paradigm that I don't know for even larger and more flexible projects.

I get why you would not want to use goto, I just could not come up with another way... and it worked so.

Although, that's not entirely true I did consider another option. Currently where goto is used the code is:

Code:
if (DoorClose1 == true) {
    while (DoorCloseDelayVal != DoorCloseDelay){
      tone(Speaker,100);
      digitalWrite(DoorClosingLED, HIGH);
      delay(500);
      tone(Speaker,200);
      digitalWrite(DoorClosingLED, LOW);
      delay(500);
      DoorCloseDelayVal ++;
      
      if (digitalRead(OverrideSW) && digitalRead(DoorOpenedSW)) {
        [b]goto override;[/b]
      }
      
      if (CloseAttemptsVal == CloseAttempts) {
        [b]goto override;[/b]
      }
      
  }

I considered doing something like this:

Code:
if (DoorClose1 == true) {
    while (DoorCloseDelayVal != DoorCloseDelay){
      tone(Speaker,100);
      digitalWrite(DoorClosingLED, HIGH);
      delay(500);
      tone(Speaker,200);
      digitalWrite(DoorClosingLED, LOW);
      delay(500);
      DoorCloseDelayVal ++;
      
      if (digitalRead(OverrideSW) && digitalRead(DoorOpenedSW)) {
       digitalWrite(OverrideLED, HIGH);
DoorOpenTime = 0;
DoorState = false;
DoorClose1 = false;
DoorClose2 = false;
DoorReset = false;
      }
      
      if (CloseAttemptsVal == CloseAttempts) {
        digitalWrite(OverrideLED, HIGH);
DoorOpenTime = 0;
DoorState = false;
DoorClose1 = false;
DoorClose2 = false;
DoorReset = false;
      }
      
  }

But I thought since I already have it written why not just use the a goto to go to the override code... Obviously I was wrong.
21  Using Arduino / Project Guidance / Re: Audomatic Garage Door Close on: September 27, 2012, 02:44:15 pm
I'd be inclined to refactor the thing into a state machine (search the forums). But for less work, when you set OverrideState to be true, store the current value of millis in a global unsigned long. In the section you run when OverrideState is true do something like this:

Code:
if(millis()-TimeOverrideWasInvoked > 30000UL)
  {
  Tone(Speaker,100);
  }

Ok, I'll try this out when I'm back in front of my Arduino
22  Using Arduino / Project Guidance / Re: Audomatic Garage Door Close on: September 27, 2012, 02:24:24 pm
Can you get anything out of the speaker elsewhere in your code? Such as the doorclose1 section?

Yes, elsewhere it seems to work fine. I can get it to beep during the override too, a steady beep (I think I can even get it to do an alternating beep). The issue I'm having is getting it to only beep every 5 minutes (for example) while the override is active.

I don't suspect, but I could be wrong, that the goto is causing any issues with this simply because during the override the goto isn't read... if it helps to eliminate the goto then I will... I'm just at a loss as to how. Would a sub-routine outside of the for(loop) work? Something like:

Code:
if (digitalRead(OverrideSW) && digitalRead(DoorOpenedSW) || CloseAttemptsVal == CloseAttempts) {
    OverrideState = true;
  }

  if (OverrideState == true) {
    override()
  }


With the sub-routine being:

Code:

void override(){

digitalWrite(OverrideLED, HIGH);
    DoorOpenTime = 0;
    DoorState = false;
    DoorClose1 = false;
    DoorClose2 = false;
    DoorReset = false;
  }
}


Then whenever I need the override, instead of using goto I could just call the sub-routine override()?
23  Using Arduino / Project Guidance / Re: Audomatic Garage Door Close on: September 27, 2012, 01:59:29 pm
Ok, I get that. Which is why I've explained ad nauseum that my basis for defending the way it's written is because as far as I can tell it works. That's all I'm saying, I'm not trying to dismiss anyone, I'm not trying to start a fight, or pee on anyone's fun-fire, I'm just saying "hum, odd because in all the testing I've done this seems to work swimmingly."

Which means 1 or 2 things:

1. You haven't sufficiently tested enough to expose the error.
2. The code is redundant/pointless and is handled in a different portion of the code.

If it works, that's fine for you. The problem is you're on the forum, asking for people for help with your code. People here don't want to weed through pointless code, or code that will cause issues as you make changes to your program. That's why it's pointed out.

The problem with GoTo is it's hard to follow/debug. So again, if it works for you, great. If not, you have to take into account how others feel about the code that you've written if you're asking for your help, because GoTo complicates things for those trying to read the code.

As far as your original question, I haven't read your code, but the fact that GoTo is used (delay(), and while statement could also cause issues), may make the normal way of doing this not work, but that's something you can experiment yourself:

Code:
if something that causes you to set a condition that will blink the led occurs
   set the condition
   note the time
end if

if the blinking condition is set and it's been 5 minutes
  turn the LED on
  note the time
end if

if it's been on long enough
  turn the led off
end if

Take a look at the Blink Without Delay example for how to handle the "note the time" and "it's been..." portions of the psuedocode.

If it helps, I've looked at the blink without delay example and I can successfully get the override LED to blink during the override. I cannot however get a beep out of the speaker.
24  Using Arduino / Project Guidance / Re: Audomatic Garage Door Close on: September 27, 2012, 01:44:41 pm
I'm just saying "hum, odd because in all the testing I've done this seems to work swimmingly."

I'm just saying that code doesn't achieve what you expect. I'd suggest that you could remove that line code and get the same behaviour. So, either what you're trying to do there is not required, or you haven't tested it sufficiently to realise that it's not doing what you intend.

Noted.
25  Using Arduino / Project Guidance / Re: Audomatic Garage Door Close on: September 27, 2012, 01:36:13 pm
while(PIR1, PIR2 == HIGH);
All I can say is that this works.

...

I'm saying is that it does or at least seems to as far as I can tell. If it is in fact wrong then it is wrong in form and not functionality.

No, it doesn't work, for two reasons, both of which have been explained. But presumably your testing has not been sufficient to expose the bug yet. I suggest it would benefit you to be far less eager to dismiss people's criticisms of your code.

Ok, I get that. Which is why I've explained ad nauseum that my basis for defending the way it's written is because as far as I can tell it works. That's all I'm saying, I'm not trying to dismiss anyone, I'm not trying to start a fight, or pee on anyone's fun-fire, I'm just saying "hum, odd because in all the testing I've done this seems to work swimmingly."

See: https://vimeo.com/50017640
26  Using Arduino / Project Guidance / Re: Audomatic Garage Door Close on: September 27, 2012, 01:26:49 pm
Whatever others pointed out, all being correct, is probably not helping you because you consider whatever "works" is correct already. You need to read a few sample programs that come with arduino. You can't just invent how to speak the C language. Read a few well written short samples and you might be able to mimic, until you truly understand. If you have some experience speaking a second language, you would agree with me. You can't just invent your own way to speak it. You mimic how native speakers talk until you can talk on your own. Those that pointed out your mistakes are the native speakers of the C language. Fighting them won't get your ideas understood by arduino. Read the sample code and hit the books.

I'm not fighting anyone. I'm genuinely looking for help. There was some confusion because people were pointing out errors - things that should not work - while I was seeing them as working. I was also misinformed on a particular aspect of how read the state of a pin. You can also understand my... dismay and frustration when I've spent the past couple of weeks writing this to come here and be told right off the bat that everything I've done is wrong.

With all that said:

1) I understand that I was reading the state of the pin wrong and will work in the suggested fix for that. Thank you.

2) I understand that that the use of the goto is frowned upon (though I did not know hoe vehement people were about it  smiley). I used it 'cause it worked and as mentioned here (http://arduino.cc/en/Reference/Goto) I did not use in "unrestrained." I'm open to suggestions on how to eliminate this.

3) The original reason for my post: suggestions, ideas, on how to get a beep every x number of minutes while the override is active.
27  Using Arduino / Project Guidance / Re: Audomatic Garage Door Close on: September 27, 2012, 12:52:02 pm
Quote
As I understand it a statement like (digitalRead(DoorShutSW) is basically shorthand (or another of writing) (DoorShutSW == HIGH)

Then you misunderstand, digitalRead() is function that returns the state of the pin. (DoorShutSW == HIGH) evaluates the pin number, not its state. I explained this in my earlier post.

http://arduino.cc/en/Reference/DigitalRead

Ok, good to know. You'll excuse my initial confusion (and perhaps overly overaggressive defense of what I was doing) as what I have does seem to work.

Looking back through where I read that (DoorShutSW == HIGH) was the same as (digitalRead(DoorShutSW) I realize that I misinterpreted what the person was saying. Again, confusion set in because I was being told that what I had would not work when it does, that's all.

I will adjust the code and retest when I get back in front of my Arduino... are there any suggestions as two how to deal with the beep every x number of minutes during the override? Also, any suggestions as to how to eliminate the goto would be welcome.
28  Using Arduino / Project Guidance / Re: Audomatic Garage Door Close on: September 27, 2012, 12:25:53 pm
I've tried a few approaches but can't get any to work.

...

A viable solution is one that works - this does.

Well, I'm confused. Does it work or not?

As I said in my first and subsequent posts (and as demonstrated in the linked video) the code, as it is written, works. The only thing that I cannot get working is when the override is activated is having a beep go off every x number of minutes.

I'm sorry if I misunderstood you but it seemed as if you were criticizing me, and confused, by my defining the Arduino pins as names (like DoorShutSW). This is what I meant by my "basic stuff" quip. I'm not sure why you'd criticize me doing this when it seems to be SOP in every single example I've ever seen, including the ones on the official Arduino example page.

If I've defined pin 6 as DoorShutSW then it stands to reason that I could then reference pin 6 as DoorShutSW in the rest of my code. Am I wrong?

while(PIR1, PIR2 == HIGH);

All I can say is that this works. Please understand that I'm not a programmer so my approach has basically been throwing things at the wall and using what sticks. This stuck. I saw the use of the comma in this way in some other code (can't remember where at this point) so I tried it and it worked.

while(digitalRead(PIR1) == HIGH || digitalRead(PIR2) == HIGH);

You'll note that I used the || (or) operator in other parts of my code but in this particular statement could not get it to work, I was probably writing it wrong. You seem convinced that my use of the comma does not work, all I'm saying is that it does or at least seems to as far as I can tell. If it is in fact wrong then it is wrong in form and not functionality. I'll try your suggestion when I get back in front of my Arduino.

You also pointed out

while (DoorShutSW == HIGH);

and said

HIGH is 1, DoorShutSW is 6, so that condition will never be true.

DoorShutSW is defined as PIN 6, I'm saying while PIN 6 is HIGH do this. As I understand it a statement like (digitalRead(DoorShutSW) is basically shorthand (or another of writing) (DoorShutSW == HIGH) this is what I remember being told in by someone here on another project I was working on anyway and I've seen both ways in use. In any case it works, it seems to be SOP, so again your criticism/confusion is... confusing.

As for the goto, I know that using goto is frowned upon. In this case, with something as uncomplicated as this, I'm not sure I see what the problem is but again - I'm just throwing at the wall and seeing what sticks. In thinking about this more I'm wondering if having a sub-routine for the override would allow me to accomplish the same result without using the goto. I'm open to suggestions...

Again, as it's written the code works. The only thing that I cannot work out is how to have a beep go every x number of minutes while the override is active.

I'm sorry for my crass responses. You came off a bit crass and it felt like your first post was dedicated to detailing how stupid I am. I was in a mood last night, sorry if I misunderstood. I really am wanting to learn and improve where necessary.
29  Using Arduino / Project Guidance / Re: Audomatic Garage Door Close on: September 27, 2012, 01:13:17 am
Lol.

I'm sorry I have to laugh. You start off by criticizing my use of goto when you don't seem to understand the basics.
There is no reason to refractor my use of goto, it works and does not seem to be causing any issues that would cause me to not use it (like an endless loop). A viable solution is one that works - this does. In any case with my limited knowladge, I was unable to come up with an alternative solution. If you are able to offer a better solution - rather than just curt criticism - then I'm all ears.

As noted in the code comments DoorShutSW is a variable that is assigned to pin 6 on the Arduino. Attached to pin 6 is a switch which I’m monitoring to see if it goes high or low (on/off). This is basic stuff and I’m not sure why it’s confusing.

while(PIR1, PIR2 == HIGH);

Again, as noted in the comments I’m monitoring the state of two PIR sensors this is effectively saying if either PIR1 or PIR2 is high then continue to execute the if statement.

I assure you that the code works as I have tested it with the hardware (switches, pir sensor, etc) connected to the Arduino. The only issue I’m having is how to get a beep every x number of minutes when the override is active.

I’m open to suggestions as to how to improve the code. Criticizing my work (when I’ve openly admitted I’m not a programmer) while offering no solutions seems like a waste of both your time and mine.

If it helps here is a video of the attached code in action. It’s a bit lengthy and dry but I explain what I’m trying to do and show how it’s currently working.

https://vimeo.com/50017640

Thank you,

Adam
30  Using Arduino / Project Guidance / Audomatic Garage Door Close on: September 26, 2012, 11:57:32 pm
I'm working on a project that will automatically close a garage door after a set period of time. I'm nearly finished but have one lingering problem - when the override is active I want there to be a beep every x number of minutes (say every 5 minutes) until the override is deactivated. I've tried a few approaches but can't get any to work. I'm hoping that someone can look over what I have and suggest a solution. The code is heavenly commented because I'm writing this for my uncle and I want him to know what's going on in the code.

Also, I'm not a programmer and this is only my second attempt at making something with the Arduino so... I'm open to suggestion to improve the code.

Thanks!

I've attached the code 'cause it was too long to post directly.
Pages: 1 [2] 3