Offline
Newbie
Karma: 0
Posts: 13
|
 |
« on: July 12, 2012, 12:08:53 pm » |
Hi all, I use an Arduino Uno with a ATMEGA328P R3. If I'm not mistaken, I thus has 2048 bytes of SRAM.
I have a program that uses the following memory: Serial Buffer = 256 bytes. (I changed the library) SERIN [200] = 200 bytes. String for display on LCD = 24 bytes. various variables such bytes = 10 bytes. a total of I think 490 bytes. And then my program works properly. If I add an array SERINMODIF [92] or 92 extra bytes, my program does not work, as if I had a crush memory. If anyone has any idea? calculation may be my memory is right? Thank you for your help. Philippe.
|
|
|
|
« Last Edit: July 12, 2012, 12:19:29 pm by phm78 »
|
Logged
|
|
|
|
|
UK
Offline
Edison Member
Karma: 45
Posts: 2289
What a host of balls she had seen: gaity, the brass buttons...
|
 |
« Reply #1 on: July 12, 2012, 12:15:47 pm » |
What are the data types of your variables?
|
|
|
|
|
Logged
|
|
|
|
|
Gosport, UK
Offline
Faraday Member
Karma: 19
Posts: 3117
|
 |
« Reply #2 on: July 12, 2012, 12:18:12 pm » |
Post your code.
|
|
|
|
|
Logged
|
|
|
|
|
Offline
Newbie
Karma: 0
Posts: 13
|
 |
« Reply #3 on: July 12, 2012, 12:19:00 pm » |
All variables are byte.
|
|
|
|
|
Logged
|
|
|
|
|
Offline
Newbie
Karma: 0
Posts: 13
|
 |
« Reply #4 on: July 12, 2012, 12:26:11 pm » |
My code:
#include <LiquidCrystal.h>
LiquidCrystal lcd(18,19,14,15,16,17);
const byte patchreq[11] = {0xF0, 0x0, 0x21, 0x02, 0x00, 0x02, 0x11, 0x00, 0x00, 0x00, 0xF7}; byte SERIN[200]; byte PATCH[92]; byte i = 0; byte a = 0; byte index = 0; byte checksumlu = 0; byte checksum = 0; byte b=0;
void setup() { Serial.begin(31250);
lcd.begin(16,2); lcd.clear(); lcd.print("o0o FACTORY"); lcd.setCursor(0,1); lcd.print("Serial SysEx "); delay(100); lcd.clear(); }
void loop() { patchread(); lcd.print(a); lcd.print(" "); lcd.print(SERIN[0], HEX); lcd.print(" "); lcd.print(SERIN[194], HEX); lcd.print(" "); lcd.print(checksumlu, HEX); lcd.print(" "); lcd.print(checksum, HEX); loop: goto loop; }
void patchread() { Serial.flush(); Serial.write(patchreq,11);
while(Serial.available() < 205) { } do { i = Serial.read(); } while(i != 0xf7);
index = 0; do { SERIN[index] = Serial.read(); index++; } while(SERIN[index] != 0xf7);
checksumlu = SERIN[192]; checksumlu *= 16; checksumlu += SERIN[193]; checksum = 0; for (index = 0; index < 92; index++) { i = (index * 2) + 8; b = (SERIN * 16) + SERIN[(i+1)]; PATCH[index] = b; // This line causes the problem <<<-------------------------------------------------- checksum += b; } a=SERIN[10]; a *= 16; a += SERIN[11]; }
|
|
|
|
|
Logged
|
|
|
|
|
UK
Offline
Edison Member
Karma: 45
Posts: 2289
What a host of balls she had seen: gaity, the brass buttons...
|
 |
« Reply #5 on: July 12, 2012, 12:32:59 pm » |
You're not taking into account the memory used by the core system (millis counter, plus many others), and the LiquidCrystal memory requirements.
Plus you have the stack on top of all that.
|
|
|
|
|
Logged
|
|
|
|
|
UK
Offline
Edison Member
Karma: 45
Posts: 2289
What a host of balls she had seen: gaity, the brass buttons...
|
 |
« Reply #6 on: July 12, 2012, 12:40:49 pm » |
I have around 1700 bytes available with an almost empty sketch. If I try and allocate more than that in one solid chunk it causes instability.
|
|
|
|
|
Logged
|
|
|
|
|
Global Moderator
UK
Offline
Brattain Member
Karma: 138
Posts: 19067
I don't think you connected the grounds, Dave.
|
 |
« Reply #7 on: July 12, 2012, 01:12:59 pm » |
put your strings in PROGMEM, and your code in code tags.
|
|
|
|
|
Logged
|
Pete, it's a fool looks for logic in the chambers of the human heart.
|
|
|
|
Seattle, WA USA
Offline
Brattain Member
Karma: 316
Posts: 35593
Seattle, WA USA
|
 |
« Reply #8 on: July 12, 2012, 01:46:31 pm » |
Also, tell us what version of the IDE you are using. For 1.0+, there are two serial buffers - one for incoming and one for outgoing - that are the same size.
Why are you using Serial.flush()? Do you understand what it does?
|
|
|
|
|
Logged
|
|
|
|
|
|