Pages: [1] 2   Go Down
Author Topic: Is this too big for ISR ?  (Read 1205 times)
0 Members and 1 Guest are viewing this topic.
Vancouver, Canada
Offline Offline
Full Member
***
Karma: 0
Posts: 118
View Profile
WWW
 Bigger Bigger  Smaller Smaller  Reset Reset

Hi, I was wondering if this ISR is too much for processing power of Arduino?

The interrupt is set at 1kHz
Code:

ISR(TIMER1_COMPA_vect) {  //Interrupt at freq of 1kHz
  distance = getDistance(Lsensor);
  pressure = getPressure(Psensor);
  prSwitch = getPswitch(Pswitch);
  temp = getTemperature(tmp);
  Fldtemp = getTemperature(Fluidtmp);
  
  Serial.print(drive);
  Serial.print(" ");
  Serial.print(distance);
  Serial.print(" ");
  Serial.print(pressure);
  Serial.print(" ");
  Serial.print(prSwitch);
  Serial.print(" ");
  Serial.print(temp);
  Serial.print(" ");
  Serial.println(Fldtemp);
}
And here are the function calls in the ISR:
Code:
int getPressure(const int pin) {
  float ADCpressure = analogRead(pin);
  ADCpressure = (ADCpressure/1023)*25;
  return (int) ADCpressure;
}

int getPswitch(const int pin) {
  if(digitalRead(pin) == HIGH)
  {
    return 1;
  }
  if(digitalRead(pin) == LOW)
  {
    return 0;
  }
}

int getTemperature(const int pin) {
  float ADCtemperature = analogRead(pin);
  ADCtemperature = ADCtemperature/1.023;
  return (int) ADCtemperature;
}

int getDistance(const int pin) {
  return analogRead(pin);
}
 

Any ideas on how to make this work?
« Last Edit: October 10, 2012, 05:27:50 pm by FardinB » Logged

Global Moderator
Offline Offline
Brattain Member
*****
Karma: 474
Posts: 18696
Lua rocks!
View Profile
WWW
 Bigger Bigger  Smaller Smaller  Reset Reset

It's nothing to do with processing power. Don't do Serial.print inside an ISR.

http://www.gammon.com.au/interrupts
Logged

Global Moderator
Offline Offline
Brattain Member
*****
Karma: 474
Posts: 18696
Lua rocks!
View Profile
WWW
 Bigger Bigger  Smaller Smaller  Reset Reset

Just set a flag, test it in loop, and do your readings and displays there.
Logged

Vancouver, Canada
Offline Offline
Full Member
***
Karma: 0
Posts: 118
View Profile
WWW
 Bigger Bigger  Smaller Smaller  Reset Reset

I need to send these data every millisecond to the PC.

Any help is appreciated

Thanks
Logged

Global Moderator
Offline Offline
Brattain Member
*****
Karma: 474
Posts: 18696
Lua rocks!
View Profile
WWW
 Bigger Bigger  Smaller Smaller  Reset Reset

At what baud rate?
Logged

Vancouver, Canada
Offline Offline
Full Member
***
Karma: 0
Posts: 118
View Profile
WWW
 Bigger Bigger  Smaller Smaller  Reset Reset

I am using the max: 115200

Logged

Offline Offline
Edison Member
*
Karma: 32
Posts: 1394
View Profile
 Bigger Bigger  Smaller Smaller  Reset Reset

Haven't you done the math yet?

115200 baud = 115200 bits per second
 = 11520 bytes per second
 = 11.5 bytes per millisecond

You can't send that many characters in the 1 mS time frame, it has nothing to do with the "processing power" of the Arduino, but the baud rate.
Logged

Vancouver, Canada
Offline Offline
Full Member
***
Karma: 0
Posts: 118
View Profile
WWW
 Bigger Bigger  Smaller Smaller  Reset Reset

I am sorry i did not see the last reply you posted.
Is there a way to increase the baud rate then. increase it in a way that PC can receive it?
Logged

Global Moderator
Offline Offline
Brattain Member
*****
Karma: 474
Posts: 18696
Lua rocks!
View Profile
WWW
 Bigger Bigger  Smaller Smaller  Reset Reset

You are getting close to the maximum. How about not sending the spaces? Even then you will be pushing it to condense your data into 11 bytes.

A more reasonable approach might be to do some calculations and send an average every second, or a delta (eg. rather than the temperature, the change in temperature).
Logged

Offline Offline
Edison Member
*
Karma: 32
Posts: 1394
View Profile
 Bigger Bigger  Smaller Smaller  Reset Reset

You might have to send it as binary instead of characters. That way, for example, 0xFF saves on one character over 255.

How long do all your readings take? that might be more than a millisecond right there!
Logged

Offline Offline
Edison Member
*
Karma: 19
Posts: 1041
Arduino rocks
View Profile
 Bigger Bigger  Smaller Smaller  Reset Reset

I managed to get 460800 baud with the uno. Above that, I would just see garbage.

You could also use Serial.write rather than print so you just print 2 bytes rather than somewhere between one and six (and you'd save another because you wouldn't need a deliminator). Then you'd have to write a program on your computer to interpret it, though
Logged

Offline Offline
Edison Member
*
Karma: 32
Posts: 1394
View Profile
 Bigger Bigger  Smaller Smaller  Reset Reset

According to this:
http://www.arduino.cc/en/Reference/AnalogRead

An analog read takes .1 mS, so your three Analog reads take 30% of your 1 mS anyway.
Logged

Vancouver, Canada
Offline Offline
Full Member
***
Karma: 0
Posts: 118
View Profile
WWW
 Bigger Bigger  Smaller Smaller  Reset Reset

I optimized my analogRead to get the maximum speed out of it.
This page (near the bottom) shows you how to get 77 kHz reading speed out of analog read. So the analog read times is not a concern to me.
https://sites.google.com/site/measuringstuff/the-arduino

@WizenedEE
How did you manage to read that speed on the serial monitor of PC?

Logged

Offline Offline
Edison Member
*
Karma: 19
Posts: 1041
Arduino rocks
View Profile
 Bigger Bigger  Smaller Smaller  Reset Reset

@WizenedEE
How did you manage to read that speed on the serial monitor of PC?
Code:
screen /dev/ttyACM0 460800
I run GNU/linux
Logged

Vancouver, Canada
Offline Offline
Full Member
***
Karma: 0
Posts: 118
View Profile
WWW
 Bigger Bigger  Smaller Smaller  Reset Reset

How about this code for ISR? would it run faster?

Code:
ISR(TIMER1_COMPA_vect) {  //Interrupt at freq of 250Hz
  distance = getDistance(Lsensor);
  pressure = getPressure(Psensor);
  prSwitch = getPswitch(Pswitch);
  temp = getTemperature(tmp);
  Fldtemp = getTemperature(Fluidtmp);
 
  toprint = 0; //reset buffer
  toprint += drive;
  toprint += ' ';
  toprint += distance;
  toprint += ' ';
  toprint += pressure;
  toprint += ' ';
  toprint += prSwitch;
  toprint += ' ';
  toprint += temp;
  toprint += ' ';
  toprint += Fldtemp;
 
  Serial.println(toprint);
}

Logged

Pages: [1] 2   Go Up
Jump to: