next topic »

[Reply #15 on:]

I tried to compile a sketch including the code you posted and I get the following errors:

Code:

sketch_nov01a:2: error: expected ',' or '...' before '&' token
sketch_nov01a:2: error: ISO C++ forbids declaration of 'T' with no type

Using Arduino 1.0.1 on a Mac

[Reply #16 on:]

If you buy a gun, you can shoot yourself in the foot. If you want to.

True. It really comes down to whether or not you have the skill to handle the gun. You have to know the limits of your competence.

So I guess you never do any assembly language programming at all then, huh? How dangerous is that? No type checking at all. Every line of code a virtual death trap. 

[Reply #17 on:]

True. It really comes down to whether or not you have the skill to handle the gun. You have to know the limits of your competence.

Wow. Well this could always be settled with a duel. Handbags at dawn perhaps?
However, in the mean time.... why won't my code work? 

[Reply #18 on:]

Well whist you guys were fighting I tried this and it seems to work. Thanks

Code:

template <class T> void sendAnything(const T& value)
{
    const byte* p = (const byte*)(const void*)&value;
    unsigned int i;
    for (i = 0; i < sizeof(value); i++) {
      if (*p == 0x7E || *p == 0x7D) { //byte stuffing
        Serial.write(0x7D);
        Serial.write(*p++ ^ 0x20);
      } else {
        Serial.write(*p++);
      }
    }
}

[Reply #19 on:]

Just one other quick question:
How might I modify the above code to send the bytes MSB first?

[Reply #20 on:]

How do you expect that to work when you call sendAnything with a string?

[Reply #21 on:]

Oh yeah, duh.
As I said. Just finished a night shift. Not optimum time for writing code.....

[Reply #22 on:]

So I guess you never do any assembly language programming at all then, huh? How dangerous is that? No type checking at all. Every line of code a virtual death trap. 

What is this assembly language of which you speak?

[Reply #23 on:]

Well whist you guys were fighting I tried this and it seems to work. Thanks

While you were fixing dinner I was making a sandwich.

[Reply #24 on:]

How do you expect that to work when you call sendAnything with a string?

Well, it works somehow. You might rename it to sendAnyValueOrItsAddress
Arduino is famous for  NoErrorHandling Software, so I'd max. add a comment in the library .cpp source code.

@Chris: rather look at the Serial.print() ( resp. hardware\arduino\cores\arduino\Print.h  / .cpp ) code
for a nice sample of function overloading.

[Reply #25 on:]

Code:

      if (*p == 0x7E || *p == 0x7D) { //byte stuffing

You lost me on that line. Perhaps I should learn assembler?

[Reply #26 on:]

Arduino is famous for  NoErrorHandling Software ...

So is Microsoft.

[Reply #27 on:]

Code:

      if (*p == 0x7E || *p == 0x7D) { //byte stuffing

You lost me on that line. Perhaps I should learn assembler?

It's plain good old C, and provides } as an escape character to avoid ever sending a tilde character ~ 0x7e
Don't ask my why, nor why some might consider this "fun".

[Reply #28 on:]

Code:

      if (*p == 0x7E || *p == 0x7D) { //byte stuffing

You lost me on that line. Perhaps I should learn assembler?

It's plain good old C, and provides } as an escape character to avoid ever sending a tilde character ~ 0x7e
Don't ask my why, nor why some might consider this "fun".

Oh I see. It's so obvious now. So really:

Code:

      if (*p == '~' || *p == '}') { //byte stuffing
        Serial.write('}');

That would certainly stuff the bytes. Particularly if the data type was, say, an int.

And the point of this line?

Code:

        Serial.write(*p++ ^ 0x20);

Honestly, this is why you shouldn't fiddle with pointers if you don't understand what you are doing.

[Reply #29 on:]

And the point of this line?

Nick, are you joking?

It's sending  a ~ as }^ and a real } as }]

It's allowing to insert meta data in the stream, marked by a ~ starting character.
Or add other special characters -- by prefixing them with }