Arduino Forum upgrade scheduled for Monday, October 20th, 11am-4pm (CEST). Sorry for the inconvenience!
Pages: 1 [2]   Go Down
Author Topic: Arduino.h and wiring_digital.c problem.  (Read 7386 times)
0 Members and 1 Guest are viewing this topic.
0
Offline Offline
Newbie
*
Karma: 0
Posts: 41
Arduino DUE rocks
View Profile
 Bigger Bigger  Smaller Smaller  Reset Reset

Thanks again cmaglie, your fix on the Arduino.h puts everything working on the right spot.  smiley
I hope it will sent to GIT so the last version comes out fixed with that.

Now all code works like a charme, I wonder now if we still can not optimize it a bit more since we are still using on the ports writing routines the REG_PIOD_SODR register, do you think this can also be changed for ODSR?

The problem with ODSR is when you write something there what was before gets cleared, so I think I need to do the proper logic just to change what´s new and maintain what was previous, no?
Logged

Check all my projects based on Atmel/Arduino -> www.aqualed-light.com

0
Offline Offline
Jr. Member
**
Karma: 1
Posts: 84
Arduino rocks
View Profile
WWW
 Bigger Bigger  Smaller Smaller  Reset Reset

Ok ok ok, if I get it right, that means that I'll not need to add the ampersand to "portOutputRegister(digitalPinToPort(13))" as your previous suggestion, because "( &(port->PIO_PDSR) )" will already return that pointer, right?

exactly.

By the way, can you explain me the meaning of "->"? Or point me to some place to read about it?

when you have a pointer to a structure the "->" operator is used to access a member of the pointed structure. Without this operator you should write something like:

Quote
(*PIOA).PIO_PDSR

whete *PIOA is the structure instance pointed by PIOA and .PIO_PDSR is the member selector. You need also the parenthesis because . has higher priority versus *. Since this kind of access is used very often, the C language defines the -> operator so you can write a more concise:

Quote
PIOA->PIO_PDSR

if you need more info a google search for "pointer to structure" will give you a lot of articles.

Ok, thank you for your time explaining. smiley-wink

BR,

Joao
Logged


0
Offline Offline
Jr. Member
**
Karma: 1
Posts: 84
Arduino rocks
View Profile
WWW
 Bigger Bigger  Smaller Smaller  Reset Reset


I'm waiting the results of your test! :-)

Ok, working fine now, thanks for your help!

With direct port communication with SODR and CODR for data pins we have gained +-13s in UTFT Demo code loop, a HUGE difference!!!

Regards,

Joao
Logged


Offline Offline
Newbie
*
Karma: 0
Posts: 9
View Profile
 Bigger Bigger  Smaller Smaller  Reset Reset

Hello alvesjc

Can you put the sample code you already it works.
I refer to the set of sbi, cbi.

It would be far better that you put the modified UTFT to download.

I have cast a write methods for UTFT ports that I have not been able to apply, but I set the display directly and go very fast, I would like to adapt the library and send it to the developer to UTFT but I'm missing that part.

Thanks
Logged

Offline Offline
Newbie
*
Karma: 0
Posts: 9
View Profile
 Bigger Bigger  Smaller Smaller  Reset Reset

After doing some tests, I see that it works by putting the code which says cmaglie.
Quote
  REG_PIOA_OWER = 0xFFFFFFFF;
  REG_PIOB_OWER = 0xFFFFFFFF;
  REG_PIOC_OWER = 0xFFFFFFFF;

then hit the code.

Code:
#define sbi(reg, mask) *reg |= mask
#define cbi(reg, mask) *reg &= ~mask

int led = 13;
volatile uint32_t * Registro;
uint32_t Mascara;

// the setup routine runs once when you press reset:
void setup() {               
  REG_PIOA_OWER = 0xFFFFFFFF;
  REG_PIOB_OWER = 0xFFFFFFFF;
  REG_PIOC_OWER = 0xFFFFFFFF;
  Registro = portOutputRegister(digitalPinToPort(led));
  Mascara = digitalPinToBitMask(led);
  // initialize the digital pin as an output.
  pinMode(led, OUTPUT);   
 
 
}

// the loop routine runs over and over again forever:
void loop() {
  sbi(Registro,Mascara);
  delay(1000);               // wait for a second
  cbi(Registro,Mascara);
  delay(1000);               // wait for a second
}

Logged

0
Offline Offline
Jr. Member
**
Karma: 1
Posts: 84
Arduino rocks
View Profile
WWW
 Bigger Bigger  Smaller Smaller  Reset Reset

Hi Amolinero.

The latest IDE version fixes the problems with SBI and CBI Macros. You don't need to set OWER registers anymore.

I've also modified the communication with ports to work with due at a very reasonable speed.

I run now the DEMO code from Henning in 32s now.

I've modified UTFT::LCD_Writ_Bus function switch this way:

Code:
case 16:

                //Clear port registers
                REG_PIOA_CODR=0xc080; //PA7,PA14,PA15
                REG_PIOB_CODR=0x4000000; //PB26
                REG_PIOC_CODR=0x3e; //PC1 - PC5
                REG_PIOD_CODR=0x64f; //PD0-3,PD6,PD9-10
               
//DB00 on PIN37 -> PIO_PC5
                REG_PIOC_SODR=(VL<<5) & 0x20;
                //DB01 on PIN36 -> PIO_PC4
                REG_PIOC_SODR=(VL<<3) & 0x10;
                //DB02 on PIN35 -> PIO_PC3
                REG_PIOC_SODR=(VL<<1) & 0x08;
                //DB03 on PIN34 -> PIO_PC2
                REG_PIOC_SODR=(VL>>1) & 0x04;
                //DB04 on PIN33 -> PIO_PC1
                REG_PIOC_SODR=(VL>>3) & 0x02;
                //DB05 on PIN32 -> PIO_PD10
                REG_PIOD_SODR=(VL<<5) & 0x400;
                //DB06 on PIN31 -> PIO_PA7
                REG_PIOA_SODR=(VL<<1) & 0x80;
                //DB07 on PIN30 -> PIO_PD9
                REG_PIOD_SODR=(VL<<2) & 0x200;
                //DB08 on PIN22 -> PIO_PB26
                REG_PIOB_SODR=(VH<<26) & 0x4000000;
                //DB09 on PIN23 -> PIO_PA14
                REG_PIOA_SODR=(VH<<13) & 0x4000;
                //DB10 on PIN24 -> PIO_PA15
                REG_PIOA_SODR=(VH<<13) & 0x8000;
                //DB11 on PIN25 -> PIO_PD0
                REG_PIOD_SODR=(VH>>3) & 0x01;
                //DB12 on PIN26 -> PIO_PD1
                REG_PIOD_SODR=(VH>>3) & 0x02;
                //DB13 on PIN27 -> PIO_PD2
                REG_PIOD_SODR=(VH>>3) & 0x04;
                //DB14 on PIN28 -> PIO_PD3
                REG_PIOD_SODR=(VH>>3) & 0x08;
                //DB15 on PIN29 -> PIO_PD6
                REG_PIOD_SODR=(VH>>1) & 0x40;

#endif
                pulse_low(P_WR, B_WR);

                break;

And the UTFT::_set_direction_registers Function this way:

Code:
if (mode==16)
{

REG_PIOA_OER=0xc080; //PA7,PA14,PA15 enable
REG_PIOB_OER=0x4000000; //PB26 enable
REG_PIOC_OER=0x3e; //PC1 - PC5 enable
REG_PIOD_OER=0x64f; //PD0-3,PD6,PD9-10 enable
}

I've only cared with 16 bit part, my display is 16bit version.

Hope this helps.
Logged


Offline Offline
Newbie
*
Karma: 0
Posts: 9
View Profile
 Bigger Bigger  Smaller Smaller  Reset Reset

Thank you very much for your answer
Logged

Finland
Offline Offline
Newbie
*
Karma: 0
Posts: 45
View Profile
 Bigger Bigger  Smaller Smaller  Reset Reset

Can't get utft library to work even how hard I try. I just end up with empty white screen backlit..

I added cbi and sbi defines to beginning of UTFT.cpp and HW_AVR.h - removed all
other mode stuff than mode 16 from HW_AVR.h and changed regtype's type definition to volatile rwreg..

Also, I grabbed pgmspace.h from another thread and included it whenever AVR/pgmspace.h is requested.
Code compiles without problems. Shield is at 3.3v setting and mega pins is selected in demo 320x240.

Nothing happens. What am I doing wrong?
I have itdb32s and mega shield for it from
Iteadstudios..
« Last Edit: December 05, 2012, 01:55:23 am by jake1981 » Logged

Finland
Offline Offline
Newbie
*
Karma: 0
Posts: 45
View Profile
 Bigger Bigger  Smaller Smaller  Reset Reset

alvesjc - what display you are having? (and how is connected, with shield? what shield? or by wires, how did you wire it?)
Logged

Offline Offline
Newbie
*
Karma: 0
Posts: 9
View Profile
 Bigger Bigger  Smaller Smaller  Reset Reset

In the first define, change UTFT.c by this

Code:
#if defined(__AVR__)
#include <avr/pgmspace.h>
#include "HW_AVR.h"
#elif defined(__SAM3X8E__)
#include "Arduino.h"
#include "HW_SAM.h"
#else
#include "HW_PIC32.h"
#endif

In the define __AVR__ of file UTFT.h change by this

Code:
#if defined(__AVR__)
#if defined(ARDUINO) && ARDUINO >= 100
#include "Arduino.h"
#else
#include "WProgram.h"
#endif
#include "HW_AVR_defines.h"
#elif defined(__SAM3X8E__)
#include "Arduino.h"
#include "HW_SAM_defines.h"
#else
#include "WProgram.h"
#include "HW_PIC32_defines.h"
#endif

copy HW_AVR_defines.h to HW_SAM_defines.h
copy HW_AVR.h to HW_SAM.h
Changes HW_SAM_defines.h by this

Code:
#define cbi(reg, bitmask) *reg &= ~bitmask
#define sbi(reg, bitmask) *reg |= bitmask
#define pulse_high(reg, bitmask) sbi(reg, bitmask); cbi(reg, bitmask);
#define pulse_low(reg, bitmask) cbi(reg, bitmask); sbi(reg, bitmask);

#define pgm_read_word(data) *data
#define pgm_read_byte(data) *data

#define cport(port, data) port &= data
#define sport(port, data) port |= data

#define swap(type, i, j) {type t = i; i = j; j = t;}

#define fontbyte(x) cfont.font[x] 

#define regtype volatile uint32_t
#define regsize uint32_t
#define bitmapdatatype unsigned uint16_t

Changes HW_SAM.h by this

Code:
// *** Hardwarespecific functions ***
void UTFT::LCD_Writ_Bus(char VH,char VL, byte mode)
{   
switch (mode)
{
case 1:
if (display_serial_mode==SERIAL_4PIN)
{
if (VH==1)
sbi(P_SDA, B_SDA);
else
cbi(P_SDA, B_SDA);
pulse_low(P_SCL, B_SCL);
}
else
{
if (VH==1)
sbi(P_RS, B_RS);
else
cbi(P_RS, B_RS);
}

if (VL & 0x80)
sbi(P_SDA, B_SDA);
else
cbi(P_SDA, B_SDA);
pulse_low(P_SCL, B_SCL);
if (VL & 0x40)
sbi(P_SDA, B_SDA);
else
cbi(P_SDA, B_SDA);
pulse_low(P_SCL, B_SCL);
if (VL & 0x20)
sbi(P_SDA, B_SDA);
else
cbi(P_SDA, B_SDA);
pulse_low(P_SCL, B_SCL);
if (VL & 0x10)
sbi(P_SDA, B_SDA);
else
cbi(P_SDA, B_SDA);
pulse_low(P_SCL, B_SCL);
if (VL & 0x08)
sbi(P_SDA, B_SDA);
else
cbi(P_SDA, B_SDA);
pulse_low(P_SCL, B_SCL);
if (VL & 0x04)
sbi(P_SDA, B_SDA);
else
cbi(P_SDA, B_SDA);
pulse_low(P_SCL, B_SCL);
if (VL & 0x02)
sbi(P_SDA, B_SDA);
else
cbi(P_SDA, B_SDA);
pulse_low(P_SCL, B_SCL);
if (VL & 0x01)
sbi(P_SDA, B_SDA);
else
cbi(P_SDA, B_SDA);
pulse_low(P_SCL, B_SCL);
break;
case 8:
// NOT IMPLEMENTED
break;
case 16:
//Clear port registers
REG_PIOA_CODR=0xc080; //PA7,PA14,PA15
REG_PIOB_CODR=0x4000000; //PB26
REG_PIOC_CODR=0x3e; //PC1 - PC5
REG_PIOD_CODR=0x64f; //PD0-3,PD6,PD9-10
               
//DB00 on PIN37 -> PIO_PC5
REG_PIOC_SODR=(VL<<5) & 0x20;
//DB01 on PIN36 -> PIO_PC4
REG_PIOC_SODR=(VL<<3) & 0x10;
//DB02 on PIN35 -> PIO_PC3
REG_PIOC_SODR=(VL<<1) & 0x08;
//DB03 on PIN34 -> PIO_PC2
REG_PIOC_SODR=(VL>>1) & 0x04;
//DB04 on PIN33 -> PIO_PC1
REG_PIOC_SODR=(VL>>3) & 0x02;
//DB05 on PIN32 -> PIO_PD10
REG_PIOD_SODR=(VL<<5) & 0x400;
//DB06 on PIN31 -> PIO_PA7
REG_PIOA_SODR=(VL<<1) & 0x80;
//DB07 on PIN30 -> PIO_PD9
REG_PIOD_SODR=(VL<<2) & 0x200;
//DB08 on PIN22 -> PIO_PB26
REG_PIOB_SODR=(VH<<26) & 0x4000000;
//DB09 on PIN23 -> PIO_PA14
REG_PIOA_SODR=(VH<<13) & 0x4000;
//DB10 on PIN24 -> PIO_PA15
REG_PIOA_SODR=(VH<<13) & 0x8000;
//DB11 on PIN25 -> PIO_PD0
REG_PIOD_SODR=(VH>>3) & 0x01;
//DB12 on PIN26 -> PIO_PD1
REG_PIOD_SODR=(VH>>3) & 0x02;
//DB13 on PIN27 -> PIO_PD2
REG_PIOD_SODR=(VH>>3) & 0x04;
//DB14 on PIN28 -> PIO_PD3
REG_PIOD_SODR=(VH>>3) & 0x08;
//DB15 on PIN29 -> PIO_PD6
REG_PIOD_SODR=(VH>>1) & 0x40;

pulse_low(P_WR, B_WR);
break;
}
}

void UTFT::_set_direction_registers(byte mode)
{
if (mode==16)
{
REG_PIOA_OER=0xc080; //PA7,PA14,PA15 enable
REG_PIOB_OER=0x4000000; //PB26 enable
REG_PIOC_OER=0x3e; //PC1 - PC5 enable
REG_PIOD_OER=0x64f; //PD0-3,PD6,PD9-10 enable
}
}

If it works, let me know and I use it, I have not tried.

If winds are going to send him UTFT developer to implement it.

regards

Logged

Finland
Offline Offline
Newbie
*
Karma: 0
Posts: 45
View Profile
 Bigger Bigger  Smaller Smaller  Reset Reset

Thanks to amolinero, I got it to work! Perfect.. Well, could be faster, but for the moment, this is great progress!
Logged

0
Offline Offline
Jr. Member
**
Karma: 1
Posts: 84
Arduino rocks
View Profile
WWW
 Bigger Bigger  Smaller Smaller  Reset Reset

Hi!

Ok, glad you made it, sorry I was out.

Have you tested with UTFT_DEMO? What is your loop time?
Logged


Offline Offline
Newbie
*
Karma: 0
Posts: 9
View Profile
 Bigger Bigger  Smaller Smaller  Reset Reset

Currently it takes 352 milliseconds to clean the screen.

It is an acceptable time.
Logged

Pages: 1 [2]   Go Up
Arduino Forum upgrade scheduled for Monday, October 20th, 11am-4pm (CEST). Sorry for the inconvenience!
Jump to: