next topic »

[on:]

Hello everyone,

I have a 320x64 pixel graphical LCD that uses a LC7891 controller and I'm trying to create a new device for it in u8glib v1.08 but I'm having some trouble.

So far I have it wired up and working perfectly with the U8GLIB_LC7981_240X64 device profile, except the far right of the display is showing the same as the far left, like so: http://i.imgur.com/ntnW6.jpg
In that picture I am using drawFrame(0, 0, 80, 64); to show the 80 pixel overlap.

I have duplicated the 240x64 device file and made edits to add my own 320x64 display to u8glib, but when I set the WIDTH variable to 320 I get a garbled display like this: http://i.imgur.com/ztiXc.jpg

Any ideas on what to try next?

[Reply #1 on:]

Show us the code you tried?

[Reply #2 on:]

Here is my u8g_dev_lc7981_320x64.c

Code:

/*

  u8g_dev_lc7981_320x64.c
 
  Tested with Nan Ya LM_J6_003_
 
  Universal 8bit Graphics Library
 
  Copyright (c) 2012, olikraus@gmail.com
  All rights reserved.

  Redistribution and use in source and binary forms, with or without modification,
  are permitted provided that the following conditions are met:

  * Redistributions of source code must retain the above copyright notice, this list
    of conditions and the following disclaimer.
   
  * Redistributions in binary form must reproduce the above copyright notice, this
    list of conditions and the following disclaimer in the documentation and/or other
    materials provided with the distribution.

  THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND
  CONTRIBUTORS "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES,
  INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF
  MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
  DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR
  CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
  SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT
  NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
  LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER
  CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT,
  STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
  ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF
  ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 
 
 
*/

#include "u8g.h"

#define WIDTH 320
#define HEIGHT 64
#define PAGE_HEIGHT 8

static const uint8_t u8g_dev_lc7981_320x64_init_seq[] PROGMEM = {
  U8G_ESC_CS(0),             /* disable chip */
  U8G_ESC_ADR(1),           /* instruction mode */
  U8G_ESC_RST(15),           /* do reset low pulse with (15*16)+2 milliseconds (=maximum delay)*/
  U8G_ESC_CS(1),             /* enable chip */
  U8G_ESC_DLY(50),         /* delay 50 ms */
 
 
  U8G_ESC_ADR(1),               /* instruction mode */
  0x000,                                /* mode register */
  U8G_ESC_ADR(0),               /* data mode */
  0x032,                                /* display on (bit 5), master mode on (bit 4), graphics mode on (bit 1)*/

  U8G_ESC_ADR(1),               /* instruction mode */
  0x001,                                /* character/bits per pixel pitch */
  U8G_ESC_ADR(0),               /* data mode */
  0x007,                                /* 8 bits per pixel */

  U8G_ESC_ADR(1),               /* instruction mode */
  0x002,                                /* number of chars/byte width of the screen */
  U8G_ESC_ADR(0),               /* data mode */
  WIDTH/8-1,                         /* 8 bits per pixel */

  U8G_ESC_ADR(1),               /* instruction mode */
  0x003,                                /* time division */
  U8G_ESC_ADR(0),               /* data mode */
  0x07f,                                /*  */

  U8G_ESC_ADR(1),               /* instruction mode */
  0x008,                                /* display start low */
  U8G_ESC_ADR(0),               /* data mode */
  0x000,                                /*  */

  U8G_ESC_ADR(1),               /* instruction mode */
  0x009,                                /* display start high */
  U8G_ESC_ADR(0),               /* data mode */
  0x000,                                /*  */
   
  U8G_ESC_DLY(10),               /* delay 10 ms */
 
  U8G_ESC_CS(0),             /* disable chip */
  U8G_ESC_END                /* end of sequence */
};

uint8_t u8g_dev_lc7981_320x64_fn(u8g_t *u8g, u8g_dev_t *dev, uint8_t msg, void *arg)
{
  switch(msg)
  {
    case U8G_DEV_MSG_INIT:
      u8g_InitCom(u8g, dev);
      u8g_WriteEscSeqP(u8g, dev, u8g_dev_lc7981_320x64_init_seq);
      break;
    case U8G_DEV_MSG_STOP:
      break;
    case U8G_DEV_MSG_PAGE_NEXT:
      {
        uint8_t y, i;
        uint16_t disp_ram_adr;
        uint8_t *ptr;
        u8g_pb_t *pb = (u8g_pb_t *)(dev->dev_mem);
       
        u8g_SetAddress(u8g, dev, 1);           /* cmd mode */
        u8g_SetChipSelect(u8g, dev, 1);
        y = pb->p.page_y0;
        ptr = pb->buf;
        disp_ram_adr = WIDTH/8;
        disp_ram_adr *= y;
        for( i = 0; i < 8; i ++ )
        {
          u8g_SetAddress(u8g, dev, 1);           /* cmd mode */
          u8g_WriteByte(u8g, dev, 0x00a );      /* display ram (cursor) address low byte */
          u8g_SetAddress(u8g, dev, 0);           /* data mode */
          u8g_WriteByte(u8g, dev, disp_ram_adr & 0x0ff ); 

          u8g_SetAddress(u8g, dev, 1);           /* cmd mode */
          u8g_WriteByte(u8g, dev, 0x00b );      /* display ram (cursor) address hight byte */
          u8g_SetAddress(u8g, dev, 0);           /* data mode */
          u8g_WriteByte(u8g, dev, disp_ram_adr >> 8 ); 
         
          u8g_SetAddress(u8g, dev, 1);           /* cmd mode */
          u8g_WriteByte(u8g, dev, 0x00c );      /* write data */
          u8g_SetAddress(u8g, dev, 0);           /* data mode */
          u8g_WriteSequence(u8g, dev, WIDTH/8, ptr);
          ptr += WIDTH/8;
          disp_ram_adr += WIDTH/8;
        }
        u8g_SetChipSelect(u8g, dev, 0);
      }
      break;
  }
  return u8g_dev_pb8h1f_base_fn(u8g, dev, msg, arg);
}

U8G_PB_DEV(u8g_dev_lc7981_320x64_8bit, WIDTH, HEIGHT, PAGE_HEIGHT, u8g_dev_lc7981_320x64_fn, U8G_COM_FAST_PARALLEL);

[Reply #3 on:]

For comparison here is the original u8g_dev_lc7981_240x64.c

Code:

/*

  u8g_dev_lc7981_240x64.c
 
  Tested with Nan Ya LM_J6_003_
 
  Universal 8bit Graphics Library
 
  Copyright (c) 2012, olikraus@gmail.com
  All rights reserved.

  Redistribution and use in source and binary forms, with or without modification,
  are permitted provided that the following conditions are met:

  * Redistributions of source code must retain the above copyright notice, this list
    of conditions and the following disclaimer.
   
  * Redistributions in binary form must reproduce the above copyright notice, this
    list of conditions and the following disclaimer in the documentation and/or other
    materials provided with the distribution.

  THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND
  CONTRIBUTORS "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES,
  INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF
  MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
  DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR
  CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
  SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT
  NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
  LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER
  CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT,
  STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
  ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF
  ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 
 
 
*/

#include "u8g.h"

#define WIDTH 240
#define HEIGHT 64
#define PAGE_HEIGHT 8


/*
  http://www.mark-products.com/graphics.htm#240x64%20Pixel%20Format
*/

static const uint8_t u8g_dev_lc7981_240x64_init_seq[] PROGMEM = {
  U8G_ESC_CS(0),             /* disable chip */
  U8G_ESC_ADR(1),           /* instruction mode */
  U8G_ESC_RST(15),           /* do reset low pulse with (15*16)+2 milliseconds (=maximum delay)*/
  U8G_ESC_CS(1),             /* enable chip */
  U8G_ESC_DLY(50),         /* delay 50 ms */
 
 
  U8G_ESC_ADR(1),               /* instruction mode */
  0x000,                                /* mode register */
  U8G_ESC_ADR(0),               /* data mode */
  0x032,                                /* display on (bit 5), master mode on (bit 4), graphics mode on (bit 1)*/

  U8G_ESC_ADR(1),               /* instruction mode */
  0x001,                                /* character/bits per pixel pitch */
  U8G_ESC_ADR(0),               /* data mode */
  0x007,                                /* 8 bits per pixel */

  U8G_ESC_ADR(1),               /* instruction mode */
  0x002,                                /* number of chars/byte width of the screen */
  U8G_ESC_ADR(0),               /* data mode */
  WIDTH/8-1,                         /* 8 bits per pixel */

  U8G_ESC_ADR(1),               /* instruction mode */
  0x003,                                /* time division */
  U8G_ESC_ADR(0),               /* data mode */
  0x07f,                                /*  */

  U8G_ESC_ADR(1),               /* instruction mode */
  0x008,                                /* display start low */
  U8G_ESC_ADR(0),               /* data mode */
  0x000,                                /*  */

  U8G_ESC_ADR(1),               /* instruction mode */
  0x009,                                /* display start high */
  U8G_ESC_ADR(0),               /* data mode */
  0x000,                                /*  */
   
  U8G_ESC_DLY(10),               /* delay 10 ms */
 
  U8G_ESC_CS(0),             /* disable chip */
  U8G_ESC_END                /* end of sequence */
};

uint8_t u8g_dev_lc7981_240x64_fn(u8g_t *u8g, u8g_dev_t *dev, uint8_t msg, void *arg)
{
  switch(msg)
  {
    case U8G_DEV_MSG_INIT:
      u8g_InitCom(u8g, dev);
      u8g_WriteEscSeqP(u8g, dev, u8g_dev_lc7981_240x64_init_seq);
      break;
    case U8G_DEV_MSG_STOP:
      break;
    case U8G_DEV_MSG_PAGE_NEXT:
      {
        uint8_t y, i;
        uint16_t disp_ram_adr;
        uint8_t *ptr;
        u8g_pb_t *pb = (u8g_pb_t *)(dev->dev_mem);
       
        u8g_SetAddress(u8g, dev, 1);           /* cmd mode */
        u8g_SetChipSelect(u8g, dev, 1);
        y = pb->p.page_y0;
        ptr = pb->buf;
        disp_ram_adr = WIDTH/8;
        disp_ram_adr *= y;
        for( i = 0; i < 8; i ++ )
        {
          u8g_SetAddress(u8g, dev, 1);           /* cmd mode */
          u8g_WriteByte(u8g, dev, 0x00a );      /* display ram (cursor) address low byte */
          u8g_SetAddress(u8g, dev, 0);           /* data mode */
          u8g_WriteByte(u8g, dev, disp_ram_adr & 0x0ff ); 

          u8g_SetAddress(u8g, dev, 1);           /* cmd mode */
          u8g_WriteByte(u8g, dev, 0x00b );      /* display ram (cursor) address hight byte */
          u8g_SetAddress(u8g, dev, 0);           /* data mode */
          u8g_WriteByte(u8g, dev, disp_ram_adr >> 8 ); 
         
          u8g_SetAddress(u8g, dev, 1);           /* cmd mode */
          u8g_WriteByte(u8g, dev, 0x00c );      /* write data */
          u8g_SetAddress(u8g, dev, 0);           /* data mode */
          u8g_WriteSequence(u8g, dev, WIDTH/8, ptr);
          ptr += WIDTH/8;
          disp_ram_adr += WIDTH/8;
        }
        u8g_SetChipSelect(u8g, dev, 0);
      }
      break;
  }
  return u8g_dev_pb8h1f_base_fn(u8g, dev, msg, arg);
}

U8G_PB_DEV(u8g_dev_lc7981_240x64_8bit, WIDTH, HEIGHT, PAGE_HEIGHT, u8g_dev_lc7981_240x64_fn, U8G_COM_FAST_PARALLEL);

[Reply #4 on:]

And finally my test code:

Code:

#include "U8glib.h"

U8GLIB_LC7981_320X64 u8g(8, 9, 10, 11, 4, 5, 6, 7,  18, 14, 15, 17, 16); // 8Bit Com: D0..D7: 8,9,10,11,4,5,6,7 en=18, cs=14 ,di=15,rw=17, reset = 16


void draw(void) {
  //80 pixels wide to show the screen is 320 pixels wide 320-240 = 80
  u8g.drawFrame(0, 0, 80, 64);
}

void setup(void) {
}

void loop(void) {
  // picture loop
  u8g.firstPage(); 
  do {
    draw();
  } while( u8g.nextPage() );
 
  // rebuild the picture after some delay
  delay(1000);
}

[Reply #5 on:]

Hi

First of all, you need to enable 16 bit mode.
Locate http://code.google.com/p/u8glib/source/browse/csrc/u8g.h and uncomment line 39

Code:

//#define U8G_16BIT 1

Will this solve your problem?

Oliver

[Reply #6 on:]

you need to enable 16 bit mode.

Oh... that's got to be the problem 

I'll get back to you once I test it!

[Reply #7 on:]

Its almost correct but something is still off

This is u8g.drawFrame(0, 0, 80, 64);
http://i.imgur.com/ZgOAl.jpg

And this is u8g.drawFrame(0, 0, 320, 64);
http://i.imgur.com/Mr0oj.jpg
You can see that the full width is working now!

Any ideas?

P.S. Great work on the lcd library!

[Reply #8 on:]

Is there a datasheet for your display?
Can you provide a picture with dots at (0,0) (1,1)(0,63)(1,62) (127,0)(128,0) (255,0)(256,0) (319,0)(318,1)?

Thanks,
Oliver

[Reply #9 on:]

I think this is the correct datasheet: http://www.gaw.ru/pdf/lcd/lcm/Varitronix/graf/MGLS32064-03.pdf

Here is a much better picture of the previous error: http://i.imgur.com/MOvnV.jpg

Picture with points: http://i.imgur.com/ouns2.jpg
Picture of the back of the LCD for reference: http://i.imgur.com/RNgHK.jpg

Code:

u8g.drawPixel(0,0);
u8g.drawPixel(1,1);
u8g.drawPixel(0,63);
u8g.drawPixel(1,62);
u8g.drawPixel(127,0);
u8g.drawPixel(128,0);
u8g.drawPixel(255,0);
u8g.drawPixel(256,0);
u8g.drawPixel(319,0);
u8g.drawPixel(318,1);

[Reply #10 on:]

Hi

Thanks for all the good pictures so far. I think i was able to isolate the problem.
Please locate line 64 of file u8g_pb8h1f.c

replace

Code:

  register uint8_t mask, tmp;

with

Code:

  register uint8_t mask;
  register u8g_uint_t tmp;

This should solve the problem. I also made the change in the repository:
http://code.google.com/p/u8glib/source/browse/csrc/u8g_pb8h1f.c
Procedures of pb8h1f have been written for a buffer of max 256 bytes. But this is wrong for your display. So the tmp variable needs to be 16 bit in 16 bit modes.

Oliver
 

[Reply #11 on:]

Thank you so much Oliver, the screen is now working perfectly! 

Here is my u8g_dev_lc7981_320x64.c if you would like to add the device to the library

Code:

/*

  u8g_dev_lc7981_320x64.c

  Note: Requires 16 bit mode
 
  Tested with Varitronix MGLS32064-03.pdf
 
  Universal 8bit Graphics Library
 
  Copyright (c) 2012, olikraus@gmail.com
  All rights reserved.

  Redistribution and use in source and binary forms, with or without modification,
  are permitted provided that the following conditions are met:

  * Redistributions of source code must retain the above copyright notice, this list
    of conditions and the following disclaimer.
   
  * Redistributions in binary form must reproduce the above copyright notice, this
    list of conditions and the following disclaimer in the documentation and/or other
    materials provided with the distribution.

  THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND
  CONTRIBUTORS "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES,
  INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF
  MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
  DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR
  CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
  SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT
  NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
  LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER
  CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT,
  STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
  ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF
  ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 
 
 
*/

#include "u8g.h"

#define WIDTH 320
#define HEIGHT 64
#define PAGE_HEIGHT 8


/*
  http://www.gaw.ru/pdf/lcd/lcm/Varitronix/graf/MGLS32064-03.pdf
*/

static const uint8_t u8g_dev_lc7981_320x64_init_seq[] PROGMEM = {
  U8G_ESC_CS(0),             /* disable chip */
  U8G_ESC_ADR(1),           /* instruction mode */
  U8G_ESC_RST(15),           /* do reset low pulse with (15*16)+2 milliseconds (=maximum delay)*/
  U8G_ESC_CS(1),             /* enable chip */
  U8G_ESC_DLY(50),         /* delay 50 ms */
 
 
  U8G_ESC_ADR(1),               /* instruction mode */
  0x000,                                /* mode register */
  U8G_ESC_ADR(0),               /* data mode */
  0x032,                                /* display on (bit 5), master mode on (bit 4), graphics mode on (bit 1)*/

  U8G_ESC_ADR(1),               /* instruction mode */
  0x001,                                /* character/bits per pixel pitch */
  U8G_ESC_ADR(0),               /* data mode */
  0x007,                                /* 8 bits per pixel */

  U8G_ESC_ADR(1),               /* instruction mode */
  0x002,                                /* number of chars/byte width of the screen */
  U8G_ESC_ADR(0),               /* data mode */
  WIDTH/8-1,                         /* 8 bits per pixel */

  U8G_ESC_ADR(1),               /* instruction mode */
  0x003,                                /* time division */
  U8G_ESC_ADR(0),               /* data mode */
  0x07f,                                /*  */

  U8G_ESC_ADR(1),               /* instruction mode */
  0x008,                                /* display start low */
  U8G_ESC_ADR(0),               /* data mode */
  0x000,                                /*  */

  U8G_ESC_ADR(1),               /* instruction mode */
  0x009,                                /* display start high */
  U8G_ESC_ADR(0),               /* data mode */
  0x000,                                /*  */
   
  U8G_ESC_DLY(10),               /* delay 10 ms */
 
  U8G_ESC_CS(0),             /* disable chip */
  U8G_ESC_END                /* end of sequence */
};

uint8_t u8g_dev_lc7981_320x64_fn(u8g_t *u8g, u8g_dev_t *dev, uint8_t msg, void *arg)
{
  switch(msg)
  {
    case U8G_DEV_MSG_INIT:
      u8g_InitCom(u8g, dev);
      u8g_WriteEscSeqP(u8g, dev, u8g_dev_lc7981_320x64_init_seq);
      break;
    case U8G_DEV_MSG_STOP:
      break;
    case U8G_DEV_MSG_PAGE_NEXT:
      {
        uint8_t y, i;
        uint16_t disp_ram_adr;
        uint8_t *ptr;
        u8g_pb_t *pb = (u8g_pb_t *)(dev->dev_mem);
       
        u8g_SetAddress(u8g, dev, 1);           /* cmd mode */
        u8g_SetChipSelect(u8g, dev, 1);
        y = pb->p.page_y0;
        ptr = pb->buf;
        disp_ram_adr = WIDTH/8;
        disp_ram_adr *= y;
        for( i = 0; i < 8; i ++ )
        {
          u8g_SetAddress(u8g, dev, 1);           /* cmd mode */
          u8g_WriteByte(u8g, dev, 0x00a );      /* display ram (cursor) address low byte */
          u8g_SetAddress(u8g, dev, 0);           /* data mode */
          u8g_WriteByte(u8g, dev, disp_ram_adr & 0x0ff ); 

          u8g_SetAddress(u8g, dev, 1);           /* cmd mode */
          u8g_WriteByte(u8g, dev, 0x00b );      /* display ram (cursor) address hight byte */
          u8g_SetAddress(u8g, dev, 0);           /* data mode */
          u8g_WriteByte(u8g, dev, disp_ram_adr >> 8 ); 
         
          u8g_SetAddress(u8g, dev, 1);           /* cmd mode */
          u8g_WriteByte(u8g, dev, 0x00c );      /* write data */
          u8g_SetAddress(u8g, dev, 0);           /* data mode */
          u8g_WriteSequence(u8g, dev, WIDTH/8, ptr);
          ptr += WIDTH/8;
          disp_ram_adr += WIDTH/8;
        }
        u8g_SetChipSelect(u8g, dev, 0);
      }
      break;
  }
  return u8g_dev_pb8h1f_base_fn(u8g, dev, msg, arg);
}

U8G_PB_DEV(u8g_dev_lc7981_320x64_8bit, WIDTH, HEIGHT, PAGE_HEIGHT, u8g_dev_lc7981_320x64_fn, U8G_COM_FAST_PARALLEL);

[Reply #12 on:]

Hi

I have added an issue for this task on the project page and I will add the new device as soon as possible.
Thanks!

Oliver