Go Down

Topic: DS1388 RTC (Read 2 times) previous topic - next topic

elpaso

Thanks for your code and ideas,

it would be nice if you could rename the class to match the chip DS1307 -> DS1388 and upload the code on github, I'm sure that somebody will cooperate to check and maybe improve the library.

David Pye

Thanks!

I did wonder whether it might be better to adjust the class heirarchy a bit, and have a core DSRTC class, with two subclasses (DS1388 and DS1307) etc to improve code re-use.

One problem I've found with some libraries like the DS1307 is that it isn't maintained in simply one place.  I wonder if the arduino 'core' project team has considered adopting it like the I2C libraries etc?  If so, it'd be clear who owned it, and therefore who to submit patches to.

Any thoughts ?   :)

robtillaart

Quote
Any thoughts ?

Take ownership?

Your proposal makes a lot of sense!
Maybe not primary for code reuse but at least for interface reuse, so all those RTC's can be called in the same manner.

I can review the code if you want.




Rob Tillaart

Nederlandse sectie - http://arduino.cc/forum/index.php/board,77.0.html -
(Please do not PM for private consultancy)

David Pye

Ooh, that'd be interesting!

Take ownership, as in the Arduino project taking ownership?

I could hack the code into some semblance of order certainly, but I'd not have the time to 'maintain' it separately outside the Arduino family.

David

robtillaart

Quote
but I'd not have the time to 'maintain' it separately outside the Arduino family.

I understand, I maintain some code myself (on playground) and I must say the first releases were hardest ;)

Rob Tillaart

Nederlandse sectie - http://arduino.cc/forum/index.php/board,77.0.html -
(Please do not PM for private consultancy)

Go Up