Go Down

Topic: DS1388 RTC (Read 2 times) previous topic - next topic

elpaso


Ooh, that'd be interesting!

Take ownership, as in the Arduino project taking ownership?

I could hack the code into some semblance of order certainly, but I'd not have the time to 'maintain' it separately outside the Arduino family.

David


To drive the DS1388 I used https://github.com/jcw/rtclib , I modified the lib adding a DS1388 class.

I could fork the original lib on github, add my modifications, and you can then add yours.
Or we can do the opposite: you fork (or just start a new repo if yours does not inherit from RTCLib) and I add my modifications (if needed).

I think that github is a very good way to distribute development efforts and maintain the code.

I don't think this lib will ever go into the Arduino core, there are so many chips out there that supporting them all would be a real nightmare for core maintainers.


David Pye

Hi elpaso,

If you're happy to fork the lib and add your changes, I can add mine on top.  Be interested to see what else you did :-)

Cheers,

David

elpaso

Hi,

sorry for the delay, I forked RTClib and added initial support for DS1388

https://github.com/elpaso/rtclib

it's far from being complete (watchdog and charger are completely missing), but it's a start ;)


David Pye

Great!

I will try to figure out how github works (I was used to cvs in the past!) and am a bit out of date w.r.t. modern source control!

I will send a patch for my changes to isRunning, and adjust().   

Cheers,

David

David Pye

Oh, and another problem I found with the DS1388.

It's very sensitive to any crystal instability, so touching the contacts of the crystal while it's running is enough to upset it and make isRunning() return false.

Problem fixed by coating those pins and the short length of track between them and the ds1388 with hot glue. Solved :-)

Go Up