Go Down

Topic: DS1388 RTC (Read 2551 times) previous topic - next topic

elpaso


Great!

I will try to figure out how github works (I was used to cvs in the past!) and am a bit out of date w.r.t. modern source control!

I will send a patch for my changes to isRunning, and adjust().   

Cheers,

David


Hi David,

I think "isRunning" doesn't exists anymore in the lib, to tell you the truth I was using an older version with isRunning already in place but when I forked I noticed that it has been dropped meanwhile.

We could add it back and ask for a merge (pull request in git jargon), it was definitely a useful function to initalize the clock with compile time when loading the sketch.

Another recent addition to RTClib is an intial support for PCF8563, I've also patched a working lib in the past, it's here: https://github.com/elpaso/Rtc_Pcf8563 , it would be nice to merge the two...



David Pye

Fork created, changes added, pull request sent :-)

https://github.com/davidmpye/rtclib

David

David Pye

I think isrunning() is something in the ladyada fork of jcw's lib, but never got put back into the original jcw one...  Which is a pity.

I've added it back into the pull request I sent :)

elpaso

Merged and pull-requested to jcw  :)

I agree that isRunning was useful, I asked to pull it.

https://github.com/jcw/rtclib/pull/4

Many thanks for the code revision and corrections !

elpaso


I think isrunning() is something in the ladyada fork of jcw's lib, but never got put back into the original jcw one...  Which is a pity.

I've added it back into the pull request I sent :)


jcw merged the pull:

https://github.com/jcw/rtclib/pull/4

It's always a pleasure to see how people cooperates to build better code, thank you all!

I really love open source!!!

David Pye

Great when it all works  :)

Cheers,

David

Go Up