Go Down

Topic: help for the program for water tank (Read 4 times) previous topic - next topic

mkbutan


It looks to me like you are just splattering code around without a clue as to what you are doing.

main does not terminate correctly.
display has a body, even though it is NOT a function declaration.
getch() returns a value that you discard. It won't work on an Arduino, anyway, since the Arduino doesn't have a keyboard.
printf() won't work, because the Arduino doesn't have a console.

You have no clue when to use { and }, and when not to.


sir post #32 and #35 says I am Using 'C' but not ARDUINO
My project is for ARDUINO First let me learn to program in 'C' after that I will Program the same in ARDUINO
I am new to programming I have just learnt 'C' Programming Language that to from YOU TUBE and from net surfing and Book's 
"THE LIFE IS VERY SMALL TO LEARN ELECTRONICS"
                           ??????°?i??
                           AND
                           yes
                           PROGRAMMING

mkbutan

#41
Jan 07, 2013, 09:48 pm Last Edit: Jan 07, 2013, 09:52 pm by mkbutan Reason: 1
\4-16v1.c|13|error: syntax error before "void"|
\4-16v1.c|23|error: syntax error before '{' token|
error on line #13 and #23


Code: [Select]

#include<stdio.h>
#include<conio.h>
void display(int z);
int main(void)
{
    int a,b,c,d;
    int x[16] = {0,10,20,25,30,40,50,60,70,75,80,90,100,100,100,100}
    //printf("Enter the Val of A,B,C,D\n");
    //scanf("%d,%d,%d,%d",&a,&b,&c,&d);
    //printf("Val of a,b,c,d,%d,%d,%d,%d",a,b,c,d);
void display(int z);
{
 int index = a*8 + b*4 + c*2 + d;
  printf("%d, %d, %d, %d is %d %%", a, b, c, d, x[index]);

    getch();
    }
}
{
   void display(int z)
{
   if(a==0 && b==0 && c==0 && d==0)
   printf("%d,%d,%d,%d is %d%% EMPTY",a,b,c,d,x[0]);//0000=00
   }
{
   if(a==0&&b==0&&c==0&&d==1)
   printf("%d, %d, %d, %d is %d %%", a,b,c,d, x[1]);//0001=01
   }
{
   if(a==0&&b==0&&c==1&&d==0)
   printf("%d, %d, %d, %d is %d %%", a,b,c,d, x[2]);//0010=02
   }
{
   if(a==0&&b==0&&c==1&&d==1)
   printf("%d, %d, %d, %d is %d %%", a,b,c,d, x[3]);//0011=03
   }
{
   if(a==0&&b==1&&c==0&&d==0)
   printf("%d, %d, %d, %d is %d %%", a,b,c,d, x[4]);//0100=04
   }
{
   if(a==0&&b==1&&c==0&&d==1)
   printf("%d, %d, %d, %d is %d %%", a,b,c,d, x[5]);//0101=05
   }
{
   if(a==0&&b==1&&c==1&&d==0)
   printf("%d, %d, %d, %d is %d %%", a,b,c,d, x[6]);//0110=06
   }
{
   if(a==0&&b==1&&c==1&&d==1)
   printf("%d, %d, %d, %d is %d %%", a,b,c,d, x[7]);//0111=07
   }
{
   if(a==1&&b==0&&c==0&&d==0)
   printf("%d, %d, %d, %d is %d %%", a,b,c,d, x[8]);//1000=08
   }
{
   if(a==1&&b==0&&c==0&&d==1)
   printf("%d, %d, %d, %d is %d %%", a,b,c,d, x[9]);//1001=09
   }
{
   if(a==1&&b==0&&c==1&&d==0)
   printf("%d, %d, %d, %d is %d %%", a,b,c,d, x[10]);//1010=10
   }
{
   if(a==1&&b==0&&c==1&&d==1)
   printf("%d, %d, %d, %d is %d %%", a,b,c,d, x[10]);//1011=11
   }
{
   if(a==1&&b==1&&c==0&&d==0)
   printf("%d, %d, %d, %d is %d %%", a,b,c,d, x[12]);//1100=12
   }
{
   if(a==1&&b==1&&c==0&&d==1)
   printf("%d, %d, %d, %d is %d %%", a,b,c,d, x[13]);//1101=13
   }
{
   if(a==1&&b==1&&c==1&&d==0)
   printf("%d, %d, %d, %d is %d %%", a,b,c,d, x[14]);//1110=14
   }
{
   else(a==1&&b==1&&c==1&&d==1)
   printf("%d, %d, %d, %d is %d %%", a,b,c,d, x[15]);//1111=15
   }
}
"THE LIFE IS VERY SMALL TO LEARN ELECTRONICS"
                           ??????°?i??
                           AND
                           yes
                           PROGRAMMING

PaulS

#42
Jan 07, 2013, 09:50 pm Last Edit: Jan 07, 2013, 09:53 pm by PaulS Reason: 1
Does that compile? Does it do what you want? Did you have a question?

Code: [Select]
     int a,b,c,d;
Local variables are not initialized. These contain whatever junk was in memory.

Code: [Select]
  int index = a*8 + b*4 + c*2 + d;
Now, what do you suppose index equals?

AWOL

Line 7 missing semicolon.
Can I ask what you're trying to do, and why doesn't it involve an Arduino?
"Pete, it's a fool looks for logic in the chambers of the human heart." Ulysses Everett McGill.
Do not send technical questions via personal messaging - they will be ignored.

PeterH


First let me learn to program in 'C' after that I will Program the same in ARDUINO
I am new to programming I have just learnt 'C' Programming Language that to from YOU TUBE and from net surfing and Book's   


It's perfectly fine to learn C++ on its own if you want. In that case I suggest you start with a C++ development environment available on your operating system, and find a C++ forum and/or tutorials to help you learn. There are plenty of both about. I don't think it's reasonable to expect contributors on the Arduino forum to deal with general C++ issues that are not related to Arduino.
I only provide help via the forum - please do not contact me for private consultancy.

Go Up