Well from analog or digital I would choose the one that allows me to have more inputs.
A switch is a digital device. It is either on or off.
A potentiometer is an analog device. It can return a range of values.
You don't just randomly choose one. You use multiplexers of the appropriate kind, based on the type of device providing the input.
My requirement is to gather input from 64+ buttons as they happen very fast. Like reading a keyboard keypresses!
My keypresses are not fast at all. Except for the backspace key. I use it a lot.