next topic »

[on:]

Hi everybody !
I'm new here
I'm using Arduino for 2 years, but now i'm trying to do something more difficult.
I'm having problems with my new Car Controller.

I use :
- LCD DfRobot Keypad
- Keypad BV4605 I2C
- Arduino Uno R2 (Powered by Vin)
- Max Converter SPI For Temperature
- A BreadBoard With Alimmentation 5 and 3.3 Each Side

My problems, After 1 minute, Serial print "... Of memory EEPROM"
I Know my Code is not Perfect ... and not finished !
If you have Any tweak, Tell me

Ps: Sorry for mistake of language, i'm French.

Code:

#include <LiquidCrystal.h>
#include <MAX31855.h>
#include <DFR_Key.h>
#include <Wire.h>
#include <bv4506.h>
#include <I2c_bv.h>
#include <EEPROMEx.h>


//Keypad 3X4
BV4506 keypad(0x31);
int keypadDown;
long clavierBkT;
boolean clavierBk = false;

DFR_Key keypadLCD;
LiquidCrystal lcd(8, 9, 4, 5, 6, 7);
double voltage,voltageR,voltageC;
int count, clavier = 0, clavierP;

//Action
int waitingA = 0;

//message
String mBuffer1,mBuffer2,mBuffer3,mBuffer4;
int countB;
boolean mBufferM;


//Thermocouple
  // ***** PIN DEFINITIONS ***** Thermocouple
  const  unsigned  char thermocoupleSO = 13;
  const  unsigned  char thermocoupleCS = 12;
  const  unsigned  char thermocoupleCLK = 11;
  // Declaration
  MAX31855  MAX31855(thermocoupleSO, thermocoupleCS, thermocoupleCLK);

//Gestion du loggage
  int logged = 0;
  String passTemp, passCar = String(EEPROM.readInt(10));
    
void setup()
{
  
  //Serial for test
  Serial.begin(115200);
  Serial.println("Demarrage");
  //Keypad
    Wire.begin();
    
  //LCD
  lcd.begin(16, 2);
  lcd.clear();
  lcd.setCursor(0,1);
  
    //pinMode(2, INPUT); // Hall sensor
    //digitalWrite(2, HIGH);
 
  //Demarrage
    lcd.print("Cumpu-Benda");
    delay(1000);
    lcd.clear();

  // Init Boucle
    count = 0;
  

}

void loop()
{
  //Keypad

  //Login
  if (logged == 0) {
    lcd.setCursor(0,0);
    lcd.print("Identification:");
    if (touchePresser()) {
      lcd.setCursor(0,1);
       switch (passAppend(clavierP)) {
        case 1:
          //Bon
          lcd.print("Ok");
          delay(1000);
          lcd.clear();
          logged = 1;
          Serial.println("Logged In");
          break;
        case 2:
          //Faux
          lcd.print("Error Password");
          delay(1000);
          lcd.clear();
          break;
        case 3:
          //Etoile
             for (int i=0; i < passTemp.length(); i++){
              lcd.print("*");
             }
          break;
      }
    
    }

  }
  
  else {
      
    double Vcc;
    unsigned int ADCValue;
 
    Vcc = readVcc()/1000.0;
    ADCValue = analogRead(1);
    voltage = voltage + ( (ADCValue / 1023.0) * Vcc );
    count++;
    
    keypad.clear();
    clavier = keypadLCD.getKey();
    if (clavier == SAMPLE_WAIT) clavier = 0;  
    
    if (action(-2)) {
      //Faire action plutot que de gerer le reste
    }
    else if (touchePresser()) { //menu keypad Action
      Serial.println("action keypad");
      action(clavierP);
    }//Fin menu keypad
    
    if (messageBuffer()) { // Gestion de l'affichage forcer
    }
    
    else  { // Action au LCD detecter
      if (count >= 200)
      {
        
          
          if (clavier == 3)
          {
            lcd.clear();  
            voltageC = voltage/count;
            voltageR = (voltageC * 2.7428571) + 2.16;
            lcd.setCursor(0,0);
            lcd.print("Tension Vin");
            lcd.setCursor(0,1);
            lcd.print(voltageR);
            lcd.setCursor(6,1);
            lcd.print(voltageC);
          }
          else if (clavier == 2)
          {
            lcd.clear();    
            voltageC = voltage/count;
            lcd.setCursor(0,0);
            voltageR = (voltageC * 2.7428571) + 2.16;
            float tensionpourcent = fmap(voltageR, 11.80, 13.50, 0.00, 100);
            lcd.print(tensionpourcent);
            lcd.setCursor(7,0);
            lcd.print("%");
            lcd.setCursor(0,1);
            lcd.print(MAX31855.readThermocouple(CELSIUS));
          }
          
          else if (clavier == 4)
          {
            
    
               lcd.clear();
               lcd.setCursor(0,1);
               lcd.print(clavierP);
               lcd.setCursor(0,0);
               lcd.print(keypadDown);
          
          }
      
        
    
    
        voltage = 0;
        voltageR = 0;
        voltageC = 0;
        count = 0;
          
        }
    }//Fin detection clavier LCD
  }//Fin logged =1
} // fin loop

float fmap(float x, float in_min, float in_max, float out_min, float out_max)
{
  return (x - in_min) * (out_max - out_min) / (in_max - in_min) + out_min;
}

long readVcc() {
  long result; // Read 1.1V reference against AVcc
  ADMUX = _BV(REFS0) | _BV(MUX3) | _BV(MUX2) | _BV(MUX1);
  delay(2); // Wait for Vref to settle
  ADCSRA |= _BV(ADSC); // Convert
  while (bit_is_set(ADCSRA,ADSC));
  result = ADCL;
  result |= ADCH<<8;
  //result = 1125300L / result; // Back-calculate AVcc in mV 4.48 meurer / 4.07 arduino
  result = (((1.1*6.25)/(5.161))*1023*1000) / result; // Back-calculate AVcc in mV
  return result;
  }
  
//
//Gestion du loggin
//
  
  //Password / Menu / Clavier
  //PassAppend
int passAppend (int toucheC) {
  // On ajoute a la variable
  passTemp = passTemp + String(toucheC);
  // On verifie qu'il fait la longueur du pass
  if (passTemp.length() >= passCar.length()) {
    // Si oui On verifie qu'il est identique au pass
      if (passTemp == passCar) {
      // Si oui on renvoie true
        return 1;
      }
      // Sinon on efface et renvoie false et efface le screen
      else {
        passReset();
        return 2;
      }
   //Sinon On ajoute une étoile au screen
  }
   else return 3;
}

  //PassReset
String passReset() {
 passTemp ="";
 return "Pass Clear";
}


  //PassSet
String passSet(int pass) {
    if (EEPROM.updateInt(0, pass)) return "Pass Set";
    else return "Error Set Pass";
}

 //
 //Getion des messages sous forme de buffer
 //
 boolean messageBuffer() {

  if ((mBuffer1 != "") && ( mBuffer1 != "" )) {
      if ((mBuffer3 != "") && ( mBuffer4 != "" )) {
        countB++;
        if(countB == 300) {mBufferM = true; lcd.clear();}
        if (countB > 600) {countB = 0; mBufferM = false; lcd.clear();}
        if (mBufferM) {
          lcd.setCursor(0,0);
          lcd.print(mBuffer3);
          lcd.setCursor(0,1);
          lcd.print(mBuffer4);
        }
        else{
          lcd.setCursor(0,0);
          lcd.print(mBuffer1);
          lcd.setCursor(0,1);
          lcd.print(mBuffer2);
        }
        
      }
      else {
        lcd.setCursor(0,0);
        lcd.print(mBuffer1);
        lcd.setCursor(0,1);
        lcd.print(mBuffer2);
        countB = 0;
      }
    return true;
  }
  else{
  return false;
  countB = 0;
  }

  
 }
 
boolean messageBufferErase() {
   mBuffer1 = "";
   mBuffer2 = "";
   mBuffer3 = "";
   mBuffer4 = "";
 }
 
 
 
 //
 //Gestion des actions
 //
boolean action(int numero) {
       switch (numero) {
        case 1:  //1 Allumage
         if (waitingA == 0) { //Verifie qu'il n'y a pas de demande de confirmation
           mBuffer1 = "Valider :";
           mBuffer2 = "Pre-Allumage";
           mBuffer3 = "* Pour Oui";
           mBuffer4 = "# Pour Non";
           waitingA = 1;
         }
         break;
        case 2:  //2 Allumage Bobine
        
         break;
        case 3:  //3 Demarreur
        
         break;
        case 9:  //9 Set password
        
         break;
        case -2:  //-1 Verifs action
         if (waitingA == 0) return false;
           switch (waitingA) {
             case 1:  //1 Allumage /1 valider /2 Annuler
               if (touchePresser()) {
                 if (clavierP == 10) {}//demarrer
                 else if (clavierP == 11) // Quitter
                   {
                     Serial.println("annulation");
                     messageBufferErase();
                     waitingA = 0;
                   }
               }
             break;
            
           }
           return true;
         break;
       }
 
 
 
 
 
 
 
 }

boolean touchePresser() {
  if (clavierBkT + 100 < millis()) {
    if (clavierBk == false) {
      clavierBkT = millis();
      if (keypad.down() == 1) {clavierBk = true; clavierP = keypad.key(); Serial.println("Clavier P: "+String(clavierP)); return true;}
    }
    else {
     clavierBkT = millis();
     if (keypad.down() == 0) {clavierBk = false;}
    }
  }
return false;
}

[Reply #1 on:]

Well, immediately I see an issue:

Code:

...
String mBuffer1,mBuffer2,mBuffer3,mBuffer4;
...
  String passTemp, passCar = String(EEPROM.readInt(10));
...

You're using Strings.  Ditch them and use character arrays and you'll probably see all your problems disappear.

[Reply #2 on:]

I've try to change that:
GuessTheNumber.ino: In function 'char passReset()':
GuessTheNumber:235: error: invalid conversion from 'const char*' to 'char'
GuessTheNumber.ino: In function 'char passSet(int)':
GuessTheNumber:241: error: invalid conversion from 'const char*' to 'char'

Code:

#include <LiquidCrystal.h>
#include <MAX31855.h>
#include <DFR_Key.h>
#include <Wire.h>
#include <bv4506.h>
#include <I2c_bv.h>
#include <EEPROMEx.h>


//Keypad 3X4
BV4506 keypad(0x31);
int keypadDown;
long clavierBkT;
boolean clavierBk = false;

DFR_Key keypadLCD;
LiquidCrystal lcd(8, 9, 4, 5, 6, 7);
double voltage,voltageR,voltageC;
int count, clavier = 0, clavierP;

//Action
int waitingA = 0;

//message
char mBuffer1,mBuffer2,mBuffer3,mBuffer4;
int countB;
boolean mBufferM;


//Thermocouple
  // ***** PIN DEFINITIONS ***** Thermocouple
  const  unsigned  char thermocoupleSO = 13;
  const  unsigned  char thermocoupleCS = 12;
  const  unsigned  char thermocoupleCLK = 11;
  // Declaration
  MAX31855  MAX31855(thermocoupleSO, thermocoupleCS, thermocoupleCLK);

//Gestion du loggage
  int logged = 0;
  char passTemp, passCar = EEPROM.readInt(10);
   
void setup()
{
 
  //Serial for test
  Serial.begin(115200);
  Serial.println("Demarrage");
  //Keypad
    Wire.begin();
   
  //LCD
  lcd.begin(16, 2);
  lcd.clear();
  lcd.setCursor(0,1);
 
    //pinMode(2, INPUT); // Hall sensor
    //digitalWrite(2, HIGH);
 
  //Demarrage
    lcd.print("Cumpu-Benda");
    delay(1000);
    lcd.clear();

  // Init Boucle
    count = 0;
 

}

void loop()
{
  //Keypad

  //Login
  if (logged == 0) {
    lcd.setCursor(0,0);
    lcd.print("Identification:");
    if (touchePresser()) {
      lcd.setCursor(0,1);
       switch (passAppend(clavierP)) {
        case 1:
          //Bon
          lcd.print("Ok");
          delay(1000);
          lcd.clear();
          logged = 1;
          Serial.println("Logged In");
          break;
        case 2:
          //Faux
          lcd.print("Error Password");
          delay(1000);
          lcd.clear();
          break;
        case 3:
          //Etoile
             for (int i=0; i < sizeof(passTemp); i++){
              lcd.print("*");
             }
          break;
      }
   
    }

  }
 
  else {
     
    double Vcc;
    unsigned int ADCValue;
 
    Vcc = readVcc()/1000.0;
    ADCValue = analogRead(1);
    voltage = voltage + ( (ADCValue / 1023.0) * Vcc );
    count++;
   
    keypad.clear();
    clavier = keypadLCD.getKey();
    if (clavier == SAMPLE_WAIT) clavier = 0; 
   
    if (action(-2)) {
      //Faire action plutot que de gerer le reste
    }
    else if (touchePresser()) { //menu keypad Action
      Serial.println("action keypad");
      action(clavierP);
    }//Fin menu keypad
   
    if (messageBuffer()) { // Gestion de l'affichage forcer
    }
   
    else  { // Action au LCD detecter
      if (count >= 200)
      {
       
         
          if (clavier == 3)
          {
            lcd.clear(); 
            voltageC = voltage/count;
            voltageR = (voltageC * 2.7428571) + 2.16;
            lcd.setCursor(0,0);
            lcd.print("Tension Vin");
            lcd.setCursor(0,1);
            lcd.print(voltageR);
            lcd.setCursor(6,1);
            lcd.print(voltageC);
          }
          else if (clavier == 2)
          {
            lcd.clear();     
            voltageC = voltage/count;
            lcd.setCursor(0,0);
            voltageR = (voltageC * 2.7428571) + 2.16;
            float tensionpourcent = fmap(voltageR, 11.80, 13.50, 0.00, 100);
            lcd.print(tensionpourcent);
            lcd.setCursor(7,0);
            lcd.print("%");
            lcd.setCursor(0,1);
            lcd.print(MAX31855.readThermocouple(CELSIUS));
          }
         
          else if (clavier == 4)
          {
           
   
               lcd.clear();
               lcd.setCursor(0,1);
               lcd.print(clavierP);
               lcd.setCursor(0,0);
               lcd.print(keypadDown);
           
          }
     
       
   
   
        voltage = 0;
        voltageR = 0;
        voltageC = 0;
        count = 0;
         
        }
    }//Fin detection clavier LCD
  }//Fin logged =1
} // fin loop

float fmap(float x, float in_min, float in_max, float out_min, float out_max)
{
  return (x - in_min) * (out_max - out_min) / (in_max - in_min) + out_min;
}

long readVcc() {
  long result; // Read 1.1V reference against AVcc
  ADMUX = _BV(REFS0) | _BV(MUX3) | _BV(MUX2) | _BV(MUX1);
  delay(2); // Wait for Vref to settle
  ADCSRA |= _BV(ADSC); // Convert
  while (bit_is_set(ADCSRA,ADSC));
  result = ADCL;
  result |= ADCH<<8;
  //result = 1125300L / result; // Back-calculate AVcc in mV 4.48 meurer / 4.07 arduino
  result = (((1.1*6.25)/(5.161))*1023*1000) / result; // Back-calculate AVcc in mV
  return result;
  }
 
//
//Gestion du loggin
//
 
  //Password / Menu / Clavier
  //PassAppend
int passAppend (int toucheC) {
  // On ajoute a la variable
  passTemp = passTemp + char(toucheC);
  // On verifie qu'il fait la longueur du pass
  if (sizeof(passTemp) >= sizeof(passCar)) {
    // Si oui On verifie qu'il est identique au pass
      if (passTemp == passCar) {
      // Si oui on renvoie true
        return 1;
      }
      // Sinon on efface et renvoie false et efface le screen
      else {
        passReset();
        return 2;
      }
   //Sinon On ajoute une étoile au screen
  }
   else return 3;
}

  //PassReset
char passReset() {
 passTemp = "";
 return "Pass Clear";
}


  //PassSet
char passSet(int pass) {
    if (EEPROM.updateInt(0, pass)) return "Pass Set";
    else return "Error Set Pass";
}

 //
 //Getion des messages sous forme de buffer
 //
 boolean messageBuffer() {

  if ((mBuffer1 != "") && ( mBuffer1 != "" )) {
      if ((mBuffer3 != "") && ( mBuffer4 != "" )) {
        countB++;
        if(countB == 300) {mBufferM = true; lcd.clear();}
        if (countB > 600) {countB = 0; mBufferM = false; lcd.clear();}
        if (mBufferM) {
          lcd.setCursor(0,0);
          lcd.print(mBuffer3);
          lcd.setCursor(0,1);
          lcd.print(mBuffer4);
        }
        else{
          lcd.setCursor(0,0);
          lcd.print(mBuffer1);
          lcd.setCursor(0,1);
          lcd.print(mBuffer2);
        }
       
      }
      else {
        lcd.setCursor(0,0);
        lcd.print(mBuffer1);
        lcd.setCursor(0,1);
        lcd.print(mBuffer2);
        countB = 0;
      }
    return true;
  }
  else{
  return false;
  countB = 0;
  }

   
 }
 
boolean messageBufferErase() {
   mBuffer1 = "";
   mBuffer2 = "";
   mBuffer3 = "";
   mBuffer4 = "";
 }
 
 
 
 //
 //Gestion des actions
 //
boolean action(int numero) {
       switch (numero) {
        case 1:  //1 Allumage
         if (waitingA == 0) { //Verifie qu'il n'y a pas de demande de confirmation
           mBuffer1 = "Valider :";
           mBuffer2 = "Pre-Allumage";
           mBuffer3 = "* Pour Oui";
           mBuffer4 = "# Pour Non";
           waitingA = 1;
         }
         break;
        case 2:  //2 Allumage Bobine
         
         break;
        case 3:  //3 Demarreur
         
         break;
        case 9:  //9 Set password
         
         break;
        case -2:  //-1 Verifs action
         if (waitingA == 0) return false;
           switch (waitingA) {
             case 1:  //1 Allumage /1 valider /2 Annuler
               if (touchePresser()) {
                 if (clavierP == 10) {}//demarrer
                 else if (clavierP == 11) // Quitter
                   {
                     Serial.println("annulation");
                     messageBufferErase();
                     waitingA = 0;
                   }
               }
             break;
             
           }
           return true;
         break;
       }
 
 
 
 
 
 
 
 }

boolean touchePresser() {
  if (clavierBkT + 100 < millis()) {
    if (clavierBk == false) {
      clavierBkT = millis();
      if (keypad.down() == 1) {clavierBk = true; clavierP = keypad.key(); Serial.println("Clavier P: "+char(clavierP)); return true;}
    }
    else {
     clavierBkT = millis();
     if (keypad.down() == 0) {clavierBk = false;}
    }
  }
return false;
}

[Reply #3 on:]

"char variable" stores one character.

"char *variable" points to a block of memory that can contain characters

"char variable[20]" reserves a block of 20 bytes in memory and points to it.

Now you tell me what's wrong.

[Reply #4 on:]

I suggest you read: http://en.wikibooks.org/wiki/C_Programming/Arrays#Strings

[Reply #5 on:]

"char *variable" points to a block of memory that can contain characters

A slight correction. variable can be pointed to a block of memory. By itself, it simply defines a variable that is a pointer. That pointer then must be explicitly pointed to a block of memory. Many of the problems with pointers are caused by assuming that a pointer points to a block of memory when it does not, or when the block it points to is read-only or too small.

[Reply #6 on:]

But, for a password, it need to be empty at start ?!

[Reply #7 on:]

But, for a password, it need to be empty at start ?!

What is empty?

Memory can never be empty.  For it to be empty it would have to vanish.

A block of memory, pointed to by a char * variable, will always contain something.  Even if that is just all character 0, it's still full of it.

If you'd read that page I posted you'd know that a char array "string" contains a series of characters terminated by the character 0 (that's not the ASCII character 0, but the actual numeric value 0, 8 bits all set to 0), so an "empty" string would be no characters terminated by the character 0.

And for you to put something in there it doesn't have to be "empty" in the first place - you will just overwrite what is in there already, even if it's just garbage.

Code:

char password[30];

getMyPassword(password);  // fictitious function that gets a password from the user.

if (strcmp(password, "letmein") == 0) {
  Serial.println("You entered the right password.");
} else {
  Serial.print("Sorry, ");
  Serial.print(password);
  Serial.println(" isn't the right password.  Try again.");
}

[Reply #8 on:]

Thanks for you answer,
I've try to use Char.

When writing

Code:

char passCar;
passCar = EEPROM.readInt(10);

Passcar return "9"
And Serial print : "outside of EEPROM memory"

With

Code:

char* passCar;
passCar = EEPROM.readInt(10);

Return GuessTheNumber:53: error: invalid conversion from 'uint16_t' to 'char*'


Sketch Size: 11042 on 32256

[Reply #9 on:]

Spot the disparity:

char passCar;

passCar = EEPROM.readInt(10);

[Reply #10 on:]

http://playground.arduino.cc/Code/EEPROMex
Only Int or Byte. How can i do ?

[Reply #11 on:]

http://playground.arduino.cc/Code/EEPROMex
Only Int or Byte. How can i do ?

A byte is an unsigned char.  They are both 8 bits in size.

I can't see it causing your problem though.  Have you determined at which point in your program this message is being generated? 

[Reply #12 on:]

The message about Eeprom is shown when i press a key on the Keypad.
Example :
When key pressed it have to show : Serial.println("Clavier P: "+char(clavierP));
1 times show :
2: avier P:
3: lavier P:
4: om memory
5: Out of Eeprom mem
6: 255
7: Clavier P:
8: Strange Characters
...

And SPI bus do something Crazy like return ~10 times the goog key and after return 255

[Reply #13 on:]

With :
    EEPROM.writeByte(10, '12345');
  (char) => carPass = EEPROM.readByte(10);
Return  5

    EEPROM.writeByte(10, 12345);
  (char) => carPass = EEPROM.readByte(10);
Return 9

[Reply #14 on:]

Code:

Serial.println("Clavier P: "+char(clavierP));

By doing that you are inadvertantly using the String class still.  You'd be much better doing:

Code:

Serial.print("Clavier P: ")
Serial.println((char)clavierP);