Potentiometer Controlling LED Graph and Servo

Forum 2005-2010 (read only) Hardware Interfacing
21

ok, i changed the led pin setup... the next step would be to change the pinMode's...

i am not even joking... i am getting tunnel vision from modifing hundreds of lines of code... i REALLY need your help in cleaning this up...

the compiled working (i dont even have any of this hooked up... im just writing the code in advanced and testing it by compiling it...) code:

#include <Servo.h> 

int val1;
int val2;

int potPin = 0; 

Servo servoPin;

int LED[35];

void setup()
{
 servoPin.attach(13); 
 
 pinMode(LED[0], OUTPUT); 
 pinMode(LED[1], OUTPUT);
 pinMode(LED[2], OUTPUT);
 pinMode(LED[3], OUTPUT);
 pinMode(LED[4], OUTPUT);
 pinMode(LED[5], OUTPUT);
 pinMode(LED[6], OUTPUT);
 pinMode(LED[7], OUTPUT);
 pinMode(LED[8], OUTPUT);
 pinMode(LED[9], OUTPUT);
 pinMode(LED[10], OUTPUT);
 pinMode(LED[11], OUTPUT);
 pinMode(LED[12], OUTPUT);
 pinMode(LED[13], OUTPUT);
 pinMode(LED[14], OUTPUT);
 pinMode(LED[15], OUTPUT);
 pinMode(LED[16], OUTPUT);
 pinMode(LED[17], OUTPUT);
 pinMode(LED[18], OUTPUT);
 pinMode(LED[19], OUTPUT);
 pinMode(LED[20], OUTPUT);
 pinMode(LED[21], OUTPUT);
 pinMode(LED[22], OUTPUT);
 pinMode(LED[23], OUTPUT);
 pinMode(LED[24], OUTPUT);
 pinMode(LED[25], OUTPUT);
 pinMode(LED[26], OUTPUT);
 pinMode(LED[27], OUTPUT);
 pinMode(LED[28], OUTPUT);
 pinMode(LED[29], OUTPUT);
 pinMode(LED[30], OUTPUT);
 pinMode(LED[31], OUTPUT);
 pinMode(LED[32], OUTPUT);
 pinMode(LED[33], OUTPUT);
 pinMode(LED[34], OUTPUT);
 pinMode(LED[35], OUTPUT);
}

void loop()
{
 val1 = analogRead(potPin);
 val2 = analogRead(potPin);
 val1 = map(val1, 0, 1023, 0, 180);
 val2 = map(val2, 0, 1023, 0, 36);
 
 servoPin.write(val1);
 
  if (val2 >= 1){               
  digitalWrite(LED[0], HIGH);
 }
 else{
  digitalWrite(LED[0], LOW);
 }
 
 if (val2 >= 2){               
  digitalWrite(LED[1], HIGH);
 }
 else{
  digitalWrite(LED[1], LOW);
 }
 
  if (val2 >= 3){               
  digitalWrite(LED[2], HIGH);
 }
 else{
  digitalWrite(LED[2], LOW);
 }
 
  if (val2 >= 4){               
  digitalWrite(LED[3], HIGH);
 }
 else{
  digitalWrite(LED[3], LOW);
 }
 
  if (val2 >= 5){               
  digitalWrite(LED[4], HIGH);
 }
 else{
  digitalWrite(LED[4], LOW);
 }
 
  if (val2 >= 6){               
  digitalWrite(LED[5], HIGH);
 }
 else{
  digitalWrite(LED[5], LOW);
 }

 if (val2 >= 7){               
  digitalWrite(LED[6], HIGH);
 }
 else{
  digitalWrite(LED[6], LOW);
 }

 if (val2 >= 8){               
  digitalWrite(LED[7], HIGH);
 }
 else{
  digitalWrite(LED[7], LOW);
 }
 
 if (val2 >= 9){               
  digitalWrite(LED[8], HIGH);
 }
 else{
  digitalWrite(LED[8], LOW);
 }
 
 if (val2 >= 10){               
  digitalWrite(LED[9], HIGH);
 }
 else{
  digitalWrite(LED[9], LOW);
 } 
 
 if (val2 >= 11){               
  digitalWrite(LED[10], HIGH);
 }
 else{
  digitalWrite(LED[10], LOW);
 } 
 
 if (val2 >= 12){               
  digitalWrite(LED[11], HIGH);
 }
 else{
  digitalWrite(LED[11], LOW);
 } 
 
 if (val2 >= 1){               
  digitalWrite(LED[12], HIGH);
 }
 else{
  digitalWrite(LED[12], LOW);
 } 
 
 if (val2 >= 14){               
  digitalWrite(LED[13], HIGH);
 }
 else{
  digitalWrite(LED[13], LOW);
 } 
 
 if (val2 >= 15){               
  digitalWrite(LED[14], HIGH);
 }
 else{
  digitalWrite(LED[14], LOW);
 } 
 
 if (val2 >= 16){               
  digitalWrite(LED[15], HIGH);
 }
 else{
  digitalWrite(LED[15], LOW);
 }
 
 if (val2 >= 17){               
  digitalWrite(LED[16], HIGH);
 }
 else{
  digitalWrite(LED[16], LOW);
 } 
 if (val2 >= 18){               
  digitalWrite(LED[17], HIGH);
 }
 else{
  digitalWrite(LED[17], LOW);
 }
 
 if (val2 >= 19){               
  digitalWrite(LED[18], HIGH);
 }
 else{
  digitalWrite(LED[18], LOW);
 }
 
 if (val2 >= 20){               
  digitalWrite(LED[19], HIGH);
 }
 else{
  digitalWrite(LED[19], LOW);
 }
 
 if (val2 >= 21){               
  digitalWrite(LED[20], HIGH);
 }
 else{
  digitalWrite(LED[20], LOW);
 }
 
 if (val2 >= 22){               
  digitalWrite(LED[21], HIGH);
 }
 else{
  digitalWrite(LED[21], LOW);
 }
 
 if (val2 >= 23){               
  digitalWrite(LED[22], HIGH);
 }
 else{
  digitalWrite(LED[22], LOW);
 }
 
 if (val2 >= 24){               
  digitalWrite(LED[23], HIGH);
 }
 else{
  digitalWrite(LED[23], LOW);
 }
 
 if (val2 >= 25){               
  digitalWrite(LED[24], HIGH);
 }
 else{
  digitalWrite(LED[24], LOW);
 }
 
 if (val2 >= 26){               
  digitalWrite(LED[25], HIGH);
 }
 else{
  digitalWrite(LED[25], LOW);
 }
 
 if (val2 >= 27){               
  digitalWrite(LED[26], HIGH);
 }
 else{
  digitalWrite(LED[26], LOW);
 }
 
 if (val2 >= 28){               
  digitalWrite(LED[27], HIGH);
 }
 else{
  digitalWrite(LED[27], LOW);
 }
 
 if (val2 >= 29){               
  digitalWrite(LED[28], HIGH);
 }
 else{
  digitalWrite(LED[28], LOW);
 }
 
 if (val2 >= 30){               
  digitalWrite(LED[29], HIGH);
 }
 else{
  digitalWrite(LED[29], LOW);
 }
 
 if (val2 >= 31){               
  digitalWrite(LED[30], HIGH);
 }
 else{
  digitalWrite(LED[30], LOW);
 }
 
 if (val2 >= 32){               
  digitalWrite(LED[31], HIGH);
 }
 else{
  digitalWrite(LED[31], LOW);
 }
 
 if (val2 >= 33){               
  digitalWrite(LED[32], HIGH);
 }
 else{
  digitalWrite(LED[32], LOW);
 }
 
 if (val2 >= 34){               
  digitalWrite(LED[33], HIGH);
 }
 else{
  digitalWrite(LED[33], LOW);
 }
 
 if (val2 >= 35){               
  digitalWrite(LED[34], HIGH);
 }
 else{
  digitalWrite(LED[34], LOW);
 }
 
 if (val2 >= 36){               
  digitalWrite(LED[35], HIGH);
 }
 else{
  digitalWrite(LED[35], LOW);
 }
}