Pages: 1 2 [3] 4 5 ... 7   Go Down
Author Topic: Multiple LED's on separate pins, switches and functions - need guidance  (Read 7030 times)
0 Members and 1 Guest are viewing this topic.
Offline Offline
Jr. Member
**
Karma: 0
Posts: 83
View Profile
 Bigger Bigger  Smaller Smaller  Reset Reset

I tinkered with the code, and added a couple more cases. Now I have 7 in total but the funny thing is, it's only outputting 5?

Code:
digitalRead(PIN_TOGG);
  if (digitalRead(PIN_TOGG) != patternButtonState)  { //the button state has changed

    if (patternButtonState == LOW) { //the button state must have just gone high
      patternButtonState = HIGH;  //record that button has just been pressed but do nothing for now, wait for release
    }
    else { //it was high, so the button must have just been released

      //record the fact that be button has now gone low ie. not pressed
      patternButtonState = LOW;

      switch (currentPattern) {

case 1: //Pattern 1 has been running
          //set up pattern 2
          currentPattern = 2;
          red = 175;
          red2 = 175;
          incR = 1;
          incR2 = 1;
          delayTime = 5;
          break;

case 2://Pattern 2 has been running
          //set up pattern 3
          currentPattern = 3;
          red = 175;
          red2 = 175;
          incR = 1;
          incR2 = 1;
          delayTime = 1;

case 3://Pattern 3 has been running
          //set up pattern 4
          currentPattern = 4;
          red = 175;
          red2 = 20;
          incR = 1;
          incR2 = 1;
          delayTime = 10;

case 4://Pattern 4 has been running
          //set up pattern 5
          currentPattern = 5;
          red = 175;
          red2 = 20;
          incR = 1;
          incR2 = 1;
          delayTime = 5;
          break;
         
case 5://Pattern 5 has been running
          //set up pattern 6
          currentPattern = 6;
          red = 175;
          red2 = 20;
          incR = 1;
          incR2 = 1;
          delayTime = 1;
          break;
         
case 6://Pattern 6 has been running
          //set up pattern 7
          currentPattern = 7;
          red = 175;
          red2 = 175;
          incR = 0;
          incR2 = 0;
          delayTime = 0;
          break;
         
case 7:
          //set up pattern 1
          currentPattern = 1;
          red = 175;
          red2 = 175;
          incR = 1;
          incR2 = 1;
          delayTime = 10;
          break;

Code:
// Delay time: sets the time in milliseconds between loop iterations.
// Make this value large for slower transitions.
unsigned long delayTime = 10;

int currentPattern = 7;
int patternButtonState = HIGH;

// The initial values of each color.
int red = 175;
int red2 = 175;

// Indicates whether a color is incrementing (1) or decrementing (0).
int incR = 1;
int incR2 = 1;
« Last Edit: April 30, 2014, 11:47:35 pm by HolidayV » Logged

West Yorkshire, UK
Offline Offline
Edison Member
*
Karma: 49
Posts: 1449
View Profile
 Bigger Bigger  Smaller Smaller  Reset Reset

You need a "break;" for each "case". There are 2 missing.
Logged

Offline Offline
Jr. Member
**
Karma: 0
Posts: 83
View Profile
 Bigger Bigger  Smaller Smaller  Reset Reset

Ahhhh! That probably happened with copy and paste. I'll check it tonight when I get home. Thank you so much for all your help on this. You are awesome.
Logged

Offline Offline
Jr. Member
**
Karma: 0
Posts: 83
View Profile
 Bigger Bigger  Smaller Smaller  Reset Reset

It WORKS!!! HOORAY!!!

Here's the working code if anybody wants it:

Code:
//////Bicycle Light System v1.0////////////

/////Author: Christopher Valentine 2014
/////Special Thanks to: PaulRB of the Arduino support forum!!!

////This is a full blown bicyle light system with
////headlights, turn signals (front and back),
////brakelights, and multi-function flashing tail lights
////Although this set up is designed for a bike,
////with the use of a wireless remote control it could
////Also be used on a remote control car or other things


byte BRAKE_SWITCH = 8; //Set Pin 8 as Brake Switch
byte Right_Turn= 4; //Set Pin 4 as Switch
byte PIN_RED = 11;  //Right Rear Set Pin 11 as LED
byte PIN_FR = 7;  //Right Front Set Pin 7 as LED
byte Left_Turn = 5 ; //Set Pin 5 as Switch
byte PIN_RED2 = 10;  //Left Rear Set Pin 10 as LED
byte PIN_FL = 6;  //Left Front Set Pin 6 as LED
byte PIN_TOGG = 3; //Toggle Fades set Pin 3
boolean buttonstate; //Integer variable named buttonstate Left Turn Switch
boolean button_state; //Integer variable named button_state Right Turn Switch
boolean button__state; //Integer variable named button__state Brake Switch

// Delay time: sets the time in milliseconds between loop iterations.
// Make this value large for slower transitions.
unsigned long delayTime = 10;

int currentPattern = 7;
int patternButtonState = HIGH;

// The initial values of each color.
int red = 175;
int red2 = 175;

// Indicates whether a color is incrementing (1) or decrementing (0).
int incR = 1;
int incR2 = 1;

void setup()
{
  pinMode(PIN_TOGG, INPUT);
  pinMode(Left_Turn, INPUT);
  pinMode(PIN_RED2, OUTPUT);
  pinMode(PIN_FL, OUTPUT);
  pinMode(Right_Turn, INPUT);
  pinMode(PIN_RED, OUTPUT);
  pinMode(PIN_FR, OUTPUT);
  pinMode(BRAKE_SWITCH, INPUT);
}
 
void turnLeft()//turnLeft function
{
analogWrite(PIN_FR, 255);
analogWrite(PIN_RED, 125);
analogWrite(PIN_RED2, 125);
buttonstate = HIGH; //the micro the switch is now HIGH

while (buttonstate == HIGH) //While the switch is NOT pressed do the following
{

buttonstate = digitalRead(Left_Turn); //Continually look at the switch to see if its pressed
analogWrite(PIN_RED2, 255); //Set the Rear Left LED to maximum brightness
analogWrite(PIN_FL, 255); //Set the Front Left LED to maximum brightness
delay(100);
analogWrite(PIN_RED2, 0); //turn the LED off for a blinking effect
analogWrite(PIN_FL, 0); //turn the LED off for a blinking effect
delay(100);

}
//Once the switch is pressed again, break out of the loop above and then break out of the function completely and go back to our main loop
buttonstate = LOW; //First we tell the micro the switch is now LOW
analogWrite(PIN_RED2, 0); //We turn the LED off before leaving our custom function
analogWrite(PIN_FL, 0); //We turn the LED off before leaving our custom function
}

void turnRight()//turnRight function
{
analogWrite(PIN_FL, 255);
analogWrite(PIN_RED, 125);
analogWrite(PIN_RED2, 125);
button_state = HIGH; //the micro the switch is now HIGH

while (button_state == HIGH) //While the switch is NOT pressed do the following
{
button_state = digitalRead(Right_Turn); //Continually look at the switch to see if its pressed
analogWrite(PIN_RED, 255); //Set the Rear Right LED to maximum brightness
analogWrite(PIN_FR, 255); //Set the Front Right LED to maximum brightness
delay(100);
analogWrite(PIN_RED, 0); //turn the LED off for a blinking effect
analogWrite(PIN_FR, 0); //turn the LED off for a blinking effect
delay(100);
}
//Once the switch is pressed again, break out of the loop above and then break out of the function completely and go back to our main loop
button_state = LOW; //First we tell the micro the switch is now LOW
analogWrite(PIN_RED, 0); //We turn the LED off before leaving our custom function
analogWrite(PIN_FR, 0); //We turn the LED off before leaving our custom function
}

void brakelights()
{

analogWrite(PIN_FL, 255);
analogWrite(PIN_FR, 255);
button__state = HIGH; //the micro switch is now HIGH

while (button__state == HIGH) //While the switch is NOT pressed do the following
{
  button__state = digitalRead(BRAKE_SWITCH); //Continually look at the switch to see if its pressed
  analogWrite(PIN_RED, 255); //Set the Rear Right LED to maximum brightness
  analogWrite(PIN_RED2, 255); //Set the Rear Left LED to maximum brightness
 
}
//Once the switch is pressed again, break out of the loop above and then break out of the function completely and go back to our main loop
button_state = LOW; //First we tell the micro the switch is now LOW
analogWrite(PIN_RED, 125); //We turn the LED off before leaving our custom function
analogWrite(PIN_RED2, 125); //We turn the LED off before leaving our custom function
}

// Smoothly changes the color values
void transition()
{
  if (red >= 175)
    incR = 0;
  else if (red <= 20)
    incR = 1;
  if (red2 >= 175)
    incR2 = 0;
  else if (red2 <= 20)
    incR2 = 1;
 
  if (incR)
    red++;
  else
    red--;
  if(incR2)
    red2++;
  else
    red2--;
}

// Sets the output voltage on the LED pins.
void setColor()
{
  analogWrite(PIN_RED, red);
  analogWrite(PIN_RED2, red2);
}
 
 
void loop()
{
 analogWrite(PIN_FR, 255);
 analogWrite(PIN_FL, 255);
 transition();
 setColor();
 delay(delayTime);
 
 button__state = digitalRead(BRAKE_SWITCH); //Continually look at the switch to see if its pressed
if (button__state == HIGH) //If the switch goes HIGH, act on it
{
  brakelights(); //new function called brakelights
}
 
buttonstate = digitalRead(Left_Turn); //Continually look at the switch to see if its pressed
if (buttonstate == HIGH) //If the switch goes HIGH, act on it
{
turnLeft(); //new function called turnLeft
}
button_state = digitalRead(Right_Turn); //Continually look at the switch to see if its pressed
if (button_state == HIGH) //If the switch goes HIGH, act on it
{
turnRight(); //new function called turnRight
}

digitalRead(PIN_TOGG);
  if (digitalRead(PIN_TOGG) != patternButtonState)  { //the button state has changed

    if (patternButtonState == LOW) { //the button state must have just gone high
      patternButtonState = HIGH;  //record that button has just been pressed but do nothing for now, wait for release
    }
    else { //it was high, so the button must have just been released

      //record the fact that be button has now gone low ie. not pressed
      patternButtonState = LOW;

      switch (currentPattern) {

case 1: //Pattern 1 has been running
          //set up pattern 2
          currentPattern = 2;
          red = 175;
          red2 = 175;
          incR = 1;
          incR2 = 1;
          delayTime = 5;
          break;

case 2://Pattern 2 has been running
          //set up pattern 3
          currentPattern = 3;
          red = 175;
          red2 = 175;
          incR = 1;
          incR2 = 1;
          delayTime = 1;
          break;

case 3://Pattern 3 has been running
          //set up pattern 4
          currentPattern = 4;
          red = 175;
          red2 = 20;
          incR = 1;
          incR2 = 1;
          delayTime = 10;
          break;

case 4://Pattern 4 has been running
          //set up pattern 5
          currentPattern = 5;
          red = 175;
          red2 = 20;
          incR = 1;
          incR2 = 1;
          delayTime = 5;
          break;
         
case 5://Pattern 5 has been running
          //set up pattern 6
          currentPattern = 6;
          red = 175;
          red2 = 20;
          incR = 1;
          incR2 = 1;
          delayTime = 1;
          break;
         
case 6://Pattern 6 has been running
          //set up pattern 7
          currentPattern = 7;
          red = 175;
          red2 = 175;
          incR = 0;
          incR2 = 0;
          delayTime = 0;
          break;
         
case 7:
          //set up pattern 1
          currentPattern = 1;
          red = 175;
          red2 = 175;
          incR = 1;
          incR2 = 1;
          delayTime = 10;
          break;

      }
    }
  }
}

Logged

West Yorkshire, UK
Offline Offline
Edison Member
*
Karma: 49
Posts: 1449
View Profile
 Bigger Bigger  Smaller Smaller  Reset Reset

Well done HolidayV, you did it!

So does it now do everything you set out to do? Reading your first few posts, I thought there was more, for example two flash requences running in parallel,  which would have meant taking out the delay() functions.

Paul
Logged

Offline Offline
Jr. Member
**
Karma: 0
Posts: 83
View Profile
 Bigger Bigger  Smaller Smaller  Reset Reset

Yes, it all works now.  Originally, I wanted to have the non-turning tail light to continue with it's flash sequence while the opposing tail light indicated the turn, but I changed it up so that it just lights solid.
Logged

West Yorkshire, UK
Offline Offline
Edison Member
*
Karma: 49
Posts: 1449
View Profile
 Bigger Bigger  Smaller Smaller  Reset Reset

Yes, it all works now.  Originally, I wanted to have the non-turning tail light to continue with it's flash sequence while the opposing tail light indicated the turn, but I changed it up so that it just lights solid.

Thought so. That small change made a big simplification to the sketch.

So what next? Are you going to build one for real? If so, an interesting challenge would be to run your sketch on an ATtiny84.

Paul
« Last Edit: May 02, 2014, 10:54:21 am by PaulRB » Logged

Offline Offline
Jr. Member
**
Karma: 0
Posts: 83
View Profile
 Bigger Bigger  Smaller Smaller  Reset Reset

I'm just waiting on the rest of the parts to arrive in the mail. My first prototype will be on an arduino compatible pro mini. I'm using light strips on the front and back forks from strips that are 120 LEDs/meter. I've got a wireless controller coming for the switches and I stole the brake switch off a cheap bike light I got off ebay that clips to the brake line. I've got a 4 channel 12v relay board coming to drive the light strips. All in all, it will have 60 LEDs on the front and 54 on the back. I even have a 12v to 5v converter to charge my cell phone using the same 12v battery. I've never played with the ATtiny 84, only the 85, but now that I've looked at it, that would shrink my board down to practically nothing and probably cost even less.  Thanks again!
Logged

West Yorkshire, UK
Offline Offline
Edison Member
*
Karma: 49
Posts: 1449
View Profile
 Bigger Bigger  Smaller Smaller  Reset Reset

Relays? They will work ok for your flashing turn lights, but not for your fading patterns on the brake lights. The fading uses pwm which is much too fast for mechanical relays to keep up with, and will quickly wear them out trying. You need transistors. Depending on the current needed, maybe just 4 x bc337 npn transistors or some logic level power fets like stp16nf06l.

« Last Edit: May 03, 2014, 03:24:26 am by PaulRB » Logged

Offline Offline
Jr. Member
**
Karma: 0
Posts: 83
View Profile
 Bigger Bigger  Smaller Smaller  Reset Reset

Well, that sucks. I really didn't want to have to build a MOSFET board. Oh well. It'll take up less space. I guess I'll just find another use for the 4ch relay I ordered.
Logged

West Yorkshire, UK
Offline Offline
Edison Member
*
Karma: 49
Posts: 1449
View Profile
 Bigger Bigger  Smaller Smaller  Reset Reset

What is/will be the current draw of your led strips? Bc337 will be ok up to 800mA and they are tiny and cheap. 60 leds @ 20mA each might be only 200mA if they are arranged into groups of 3 in series for the 12V supply. An ATtiny84, 4 x BC337, a 78L05 and a few caps and resistors won't take up much space on a bit of stripboard or tripad board!
Logged

Offline Offline
Faraday Member
**
Karma: 66
Posts: 2578
Now, More Than Ever
View Profile
 Bigger Bigger  Smaller Smaller  Reset Reset

Car lights have one end at Ground.
They're on/off by interrupting +V to the lamp (not Ground.)
Logged

"Hello, I must be going..."
"You gotta fight -- for your right -- to party!"
Don't react - Read.
"Who is like unto the beast? who is able to make war with him?"

Offline Offline
Jr. Member
**
Karma: 0
Posts: 83
View Profile
 Bigger Bigger  Smaller Smaller  Reset Reset

Car lights have one end at Ground.
They're on/off by interrupting +V to the lamp (not Ground.)
I guess it's a good thing this light set up is for a bicycle and not a car.
Logged

Offline Offline
Jr. Member
**
Karma: 0
Posts: 83
View Profile
 Bigger Bigger  Smaller Smaller  Reset Reset

Relays? They will work ok for your flashing turn lights, but not for your fading patterns on the brake lights. The fading uses pwm which is much too fast for mechanical relays to keep up with, and will quickly wear them out trying. You need transistors. Depending on the current needed, maybe just 4 x bc337 npn transistors or some logic level power fets like stp16nf06l.


I got the MOSFETs and they drive the strips just fine, but now I just realized that if the brake switch is pressed, the turn signal won't work simultaneously. It doesn't matter if the turn signal is turned on first because the rear LEDs are set to high when not flashing in the turn signal circuit, but if someone is riding the brake while approaching the turn, the signal doesn't flash. How can I fix this?
Logged

The Netherlands
Offline Offline
Edison Member
*
Karma: 50
Posts: 1715
View Profile
 Bigger Bigger  Smaller Smaller  Reset Reset

To solve this, you need to use a different approach.
First of all, dump the delay right away.

So dump the delays.
Your Arduino runs through loop very fast (at least hundreds of times per second), unless you are using blocking code like delay().
There are more blocking instructions, but delay() is the worst ever.
Study blink without delay, you can find that in your IDE examples.
If you use that technique, you will be able to use brake and keep blinking the turn indicator.
« Last Edit: May 03, 2014, 04:56:29 pm by MAS3 » Logged

Have a look at "blink without delay".
Did you connect the grounds ?
Je kunt hier ook in het Nederlands terecht: http://arduino.cc/forum/index.php/board,77.0.html

Pages: 1 2 [3] 4 5 ... 7   Go Up
Jump to: