next topic »

[Reply #30 on:]

Oh OK. After I got done putting in all the rubbish to make the C++ and C symbols work together I did feel it would be better as a class. I'm away from that hardware until Tuesday, I'll redo it as C++ then.

[Reply #31 on:]

Awesome.  

Having things like:

Code:

OneWire(pin);
OneWire.read();
OneWire.write(value, power)

Would make the code that much easier to use and more consistent with the other libraries.

[Reply #32 on:]

All packaged in C++ form. Well, not the keywords.txt file. I'm not sure what that is, though I guess it has something to do with the color coding of the build in editor.

http://www.federated.com/~jim/onewire/ contains the library and a sample program. Feel free to vacuum it up into anything you like.

This library is general 1-wire. It might be nice to derive a DS18S20 class from this that knows about temperature to handle the conversions, or that might start making too much object code. Maybe I'm being too sensitive to code bloat, but it seems that higher level libraries will end up containing a lot of unused functions for any given application. e.g. I won't use the alarm threshold registers in my application but I'd end up with functions for them linked into my code. I had enough worry about that in just the generic functions that I ended up with a couple nasty preprocessor symbols to omit some of the larger functions that people might not need.

[Reply #33 on:]

Very nice.  I may try to write up a bit of documentation for it in the playground, unless someone else decides to do it first.

[Reply #34 on:]

I will make the keywords.txt then. That seems to be the easiest part.  

[Reply #35 on:]

I made a rough outline at http://www.arduino.cc/playground/Learning/OneWire

When I get some time later today, I'll go through and edit it up.

[Reply #36 on:]

So, the easiest jobis done too, although I am not sure if I got it right. I thought I read something about the keywords.txt file, but I can't find it anymore.

Code:

#######################################
# Syntax Coloring Map For OneWire
#######################################

#######################################
# Datatypes (KEYWORD1)
#######################################

OneWire    KEYWORD1

#######################################
# Methods and Functions (KEYWORD2)
#######################################

reset      KEYWORD2
write_bit      KEYWORD2
read_bit      KEYWORD2
write      KEYWORD2
read      KEYWORD2
select      KEYWORD2
depower      KEYWORD2
reset_search      KEYWORD2
search      KEYWORD2
crc8      KEYWORD2
crc16      KEYWORD2

#######################################
# Instances (KEYWORD2)
#######################################


#######################################
# Constants (LITERAL1)
#######################################

[edit]changed the keywords.txt[/edit]

[Reply #37 on:]

You can check out the keywords.txt of the existing libraries (in lib/targets/libraries).  It looks good, except that OneWire should be in the datatypes section and a KEYWORD1.  Now we just need to zip it all and upload it somewhere (the playground?).

[Reply #38 on:]

You can check out the keywords.txt of the existing libraries (in lib/targets/libraries).  It looks good, except that OneWire should be in the datatypes section and a KEYWORD1.  Now we just need to zip it all and upload it somewhere (the playground?).

I made this after looking at an example. Only the OneWire wasn't clear to me. I have changed the file, so you can just copy/paste it.

[Reply #39 on:]

Cool, thanks.

[Reply #40 on:]

Has anybody gotten this working with the 008 environment? I can make it compile by changing digital_pin_to_port to digital_pin_to_port_PGM and such, but I'm not getting valid readings from the DS18S20P I'm testing it with.

[Reply #41 on:]

Has anybody gotten this working with the 008 environment?

Jim Studt was kind enough to email me with details of how to get the OneWire library working with arduino-0008. I've posted an updated version of the library to http://www.elsewhere.org/onewire/

Thanks, Jim!

[Reply #42 on:]

Don't know if you need more code sample for One Wire, but the project OWW is open source and addresses a lot of One Wire devices :
http://oww.sourceforge.net

[Reply #43 on:]

The OneWire library working fine with Arduino-0009. I'm reading from two DS18S20 using parasite power.

[Reply #44 on:]

EDIT:  nevermind .... figured it out  :o