next topic »

[Reply #30 on:]

Hi, thanks for the update.  I would be happy to design a PCB and send you a few if I had a schematic to work from?

Also wondering if your project can support different GLCD resolutions?  Thanks

[Reply #31 on:]

Nick,
I'm a bit confused as to how the code is really working on the read side.
The data lines should be read 320ns after E is raised but *before* E is lowered
because the data is only guaranteed to be valid on the data bus 10ns after E is lowered.

If I look at readData() it
raises and lowers E twice which will do the "dummy" read and then
the real "read",
but it isn't valid to read the data lines on the data bus *after* you lower E since
the glcd is supposed to tri-state the data bus when E is low.
So the validity of the data lines is rapidly collapsing between when the
loop ends and when the data lines are sampled lower in the routine
Since just a single AVR instruction is going to take more than 10ns I'm not sure
how the code can read the data from the glcd.

Were you getting valid data on your glcd reads? or just always getting 0 or FF?
i.e. does line() work properly by overstriking the existing pixels?
Am I missing something?

--- bill

[Reply #32 on:]

It's working but perhaps by good luck rather than good management. Do you mean to change it to be like this?

Code:

// read the byte corresponding to the selected x,y position
byte I2C_graphical_LCD_display::I2C_graphical_LCD_display::readData ()
{
 
#ifdef WRITETHROUGH_CACHE
  return _cache [_cacheOffset];
#endif
 
  // data port (on the MCP23017) is now input
  expanderWrite (IODIRB, 0xFF);
 
  // lol, see the KS0108 spec sheet - you need to read twice to get the data
  startSend ();
    doSend (GPIOA);                  // control port
    doSend (LCD_RESET | LCD_READ | LCD_DATA | LCD_ENABLE | _chipSelect);  // set enable high
  endSend ();

  startSend ();
    doSend (GPIOA);                  // control port
    doSend (LCD_RESET | LCD_READ | LCD_DATA | _chipSelect);  // pull enable low to toggle data
  endSend ();

  startSend ();
  doSend (GPIOA);                  // control port
  doSend (LCD_RESET | LCD_READ | LCD_DATA | LCD_ENABLE | _chipSelect);  // set enable high
  endSend ();

  byte data;

  if (_ssPin)
    {
    digitalWrite (_ssPin, LOW);
    SPI.transfer ((_port << 1) | 1);  // read operation has low-bit set
    SPI.transfer (GPIOB);             // which register to read from
    data = SPI.transfer (0);          // get byte back
    digitalWrite (_ssPin, HIGH);
    }
  else
    {
    // initiate blocking read into internal buffer
    Wire.requestFrom (_port, (byte) 1);
   
    // don't bother checking if available, Wire.receive does that anyway
    //  also it returns 0x00 if nothing there, so we don't need to bother doing that
    data = i2c_read ();
    } 

  // drop enable AFTER we have read it
  startSend ();
  doSend (GPIOA);                  // control port
  doSend (LCD_RESET | LCD_READ | LCD_DATA | _chipSelect);  // pull enable low to toggle data
  endSend ();

  // data port (on the MCP23017) is now output again
  expanderWrite (IODIRB, 0);
 
  return data;
 
}  // end of I2C_graphical_LCD_display::readData

That also appears to work.

[Reply #33 on:]

Were you getting valid data on your glcd reads? or just always getting 0 or FF?
i.e. does line() work properly by overstriking the existing pixels?

Yes I was.
Yes it does.

[Reply #34 on:]

Hi, thanks for the update.  I would be happy to design a PCB and send you a few if I had a schematic to work from?

The schematic is here:

http://www.gammon.com.au/forum/?id=10940

I already did an Eagle file for it (attached). It may or may not be 100% correct, I haven't tested it.

Also wondering if your project can support different GLCD resolutions?  Thanks

Not sure, it's been a while since I worked on it.

[Reply #35 on:]

Were you getting valid data on your glcd reads? or just always getting 0 or FF?
i.e. does line() work properly by overstriking the existing pixels?

Yes I was.
Yes it does.

Interesting... I'm kind of surprised.

hmm. I wonder if it is glcd specific and some glcd modules disable the bus in s/w vs hardware
(which might make the validity stretch beyond the E dropping a while longer)
or maybe they use R/W to determine when to drive the bus and not actually gate it with E.
The samsung ks0107/8 spec and all of the glcd specs I have show
the read data only being valid while E is high.
They may not have really implemented it that way but
its probably best/safest to read the data when E is high - That's what I do in the glcd library.

--- bill

[Reply #36 on:]

Thanks Nick, much appreciated - if you PM me I will send you a few when they arrive :-)

Might take a month or two.....

[Reply #37 on:]

He made ​​his project and it works perfectly.
I have a question with arduino rookie.
I see in the library instruction to display on the LCD voltage value is refreshed every 5 seconds. It is a decimal variable (eg 230.33 volts)
I've tried with:
lcd.letter (voltage);
But I get an X.

Thank you and congratulations on your development.