next topic »

[on:]

Hello this is a noob programming question, but i just cant get it to work.
Im trying to take my int array named "buffer" and reverse the order of all numbers in it, and put it in a new array named "buffer2".
Any tips on how i can achieve this?
Thanks in advance.

[Reply #1 on:]

Code:

int x = 0;
int y = 255; //CHANGE TO SIZE OF "BUFFER" ARRAY!

while(y){
  buffer[x] = buffer2[y];
  x++;
  y--;
}

Remember to change the size of 'y' to the size of 'buffer'.
Onions.

[Reply #2 on:]

an inplace reverse

Code:

#define BUFFERSIZE 123
int buffer[BUFFERSIZE];

reverse()
{
  for (int i=0, j = BUFFERSIZE-1; i< BUFFERSIZE/2; i++, j--)
  {
    int temp = buffer[i];
    buffer[i] = buffer[j];
    buffer[j] = temp;
  }
}

[Reply #3 on:]

Big thanks for the fast reply! Great support!

[Reply #4 on:]

Code:

int x = 0;
int y = 255; //CHANGE TO SIZE OF "BUFFER" ARRAY!

while(y){
  buffer[x] = buffer2[y];
  x++;
  y--;
}

Remember to change the size of 'y' to the size of 'buffer'.
Onions.

So maybe use: int y = sizeof(buffer); ?

[Reply #5 on:]

So maybe use: int y = sizeof(buffer); ?

Which of course only works if you're not passing the array as an argument to a function.

[Reply #6 on:]

So maybe use: int y = sizeof(buffer); ?

No, because 'sizeof' returns the number of bytes in the array, not the number of elements. Since an 'int' is two bytes on the Arduino, 'sizeof' will return twice the number of elements.  Try this:

Code:

int y = sizeof(buffer) / sizeof(buffer[0]);

Remember that the compiler will evaluate the two 'sizeof's and the division.

[Reply #7 on:]

Code:

for (int i=0, j = BUFFERSIZE-1; i< BUFFERSIZE/2; i++, j--)
  {
    int temp = buffer[i];
    buffer[i] = buffer[j];
    buffer[j] = temp;
  }

Bonus marks for eliminating "temp"

[Reply #8 on:]

Bonus marks for eliminating "temp"

I'll just leave this here: http://en.wikipedia.org/wiki/XOR_swap_algorithm#Reasons_for_avoidance_in_practice

[Reply #9 on:]

Without the int j, but I expect it will execute slower;  pointer math might be faster

Code:

for (int i=0; i< BUFFERSIZE/2; i++)
  {
    int temp = buffer[i];
    buffer[i] = buffer[BUFFERSIZE-1 - i ];
    buffer[BUFFERSIZE-1 - i] = temp;
  }

[Reply #10 on:]

I'll just leave this here: http://en.wikipedia.org/wiki/XOR_swap_algorithm#Reasons_for_avoidance_in_practice

Opacity, I agree with.
"Modern CPU architecture" and "AVR" don't fit in the same sentence  ;-)

[Reply #11 on:]

Well, the AVR chips do have a pipeline (even though that can easily be ignored). But I was actually mostly referring to compiler optimizations.

[Reply #12 on:]

Well, the AVR chips do have a pipeline

PICs do too - I wonder why they're so slow?