Go Down

Topic: New LiquidCrystal library - LCD library (Read 26 times) previous topic - next topic

bperrybap


There is nothing complicated in what I have posted. It's pretty simple and straight forward and requires no second guessing of my intent.


But it isn't straight forward.
I can't figure out what you want since you are not being specific nor pointing directly to exact code to reference.
Leaving people to guess what you mean isn't a good way to communicate your desires.
So I'll ask again.
What is it that you are wanting?

Beyond wanting to modify the constructors for additional information,
Are you wanting to to support negative logic for the backlight control?

Quote

The person who modified the I2C version to work with the attiny85 put in his settings for his LCD and that included the troublesome backlight mask that I have mentioned.



The code that fm posted that I looked at only uses 0x00 and 0xff for BACKLIGHT defines to turn on/off the bitmask
that controls the backlight.

I can't find any references to the other BACKLIGHT defines you mentioned in fm's code
so I'm not seeing any troublesome masks.

Can you provide a link to code and exact modules and line numbers
of the problems you are talking about?

--- bill

sixeyes


There is nothing complicated in what I have posted. It's pretty simple and straight forward and requires no second guessing of my intent.


I don't wish to disagree with you, but I'm not clear what you're after either. I do not think it's clear or straight forward.

Iain

m12lrpv

To someone who understands the code segment and functionality that I spoke about it should be quite clear.

I am not here to explain the inner workings of I2C and LCD's to people who just want to argue.
:smiley-roll:

Let me google that for you


bperrybap


To someone who understands the code segment and functionality that I spoke about it should be quite clear.

I am not here to explain the inner workings of I2C and LCD's to people who just want to argue.
:smiley-roll:

Let me google that for you



Ah, i see we have a smart ass on our hands.

First, before this post, you never posted any code, any code segments, nor  any links to any code.
You only babbled about masks and some not completely clear statements that possibly
could be interpreted as the desire for negative logic to control the backlight circuitry.

2nd what you were talking about has absolutely NOTHING to do with I2C it has to do with setting output pins
to control the backlight circuitry and even that doesn't really have anything to do with LCDs.

3rd, when modifying multi layer API interfaces for these kinds of bit twiddling control,
the changes can have implications beyond just the i2c device layer. The same modifications
can apply to the other interfaces as well which means it should be handled in a generic/common way.
So your thinking about just ic2 expander output bits is way too narrow.

Well after looking at the attiny85 code you so graciously finally provided a link to above, which has nothing to do with fm's code,
I can see that the tiny85 code that you are looking at hard codes the backlight control to bit 7 as well as
uses negative logic for backlight control.

Without seeing actual code, there was no way to know for sure what you were babbling about in your previous posts.

fm's code already allows using any bit for backlight control but presumes positive logic.

So what you were really wanting all this time but were unable to verbalize in a way that
was pretty simple and straight forward and requires no second guessing of your intent
was that you were wanting support for negative logic for backlight control.

Gee, it would have been so much simpler if you would have just come right out and said
that is what you wanted/needed, especially since I even asked if that was what you wanted.

--- bill



fm

Hi Bill, thanks for the hints you've posted. I have noted them down for library improvements on coming versions.

@m12lrpv - I think that we are talking about different libraries. In this particular case (for the New LiquidCrystal), the library, in its I2C configuration does support three main class constructors: only address, address + EN, RS, RW, address + EN, RS, RW + Di (i=1..4).
As for negative logic control, with the current methods it is possible but on the code it will look strange: setBackligh (LOW) -> will change to 0, will switch on the light. setBacklight (HIGH) -> will change to 255, will set the backlight off.
   

Go Up