One piezo buzzer with two buttons and two melodies

You're creating two variables both called buttonState. Not a good idea. Instead of that just use digitalRead(halloween) or digitalRead(starwars) directly in the if statements. Also the } to end your two for loops are in the wrong places. Each loop should just play its notes and then end.

How are your buttons wired? Pull up or pull down resistors fitted?

Steve