Go Down

Topic: error on my sketch (Read 4803 times) previous topic - next topic

AWOL

The other option is to paste the code into an editor that allows a hex view of the source, like UltraEdit.

nickgammon

That's exactly where I got the hex codes from.

I get suspicious when a line says something about a stray "\" when I don't see any of them. Then I look at the punctuation in the line. As a last resort, I would retype the whole thing.
Please post technical questions on the forum, not by personal message. Thanks!

More info: http://www.gammon.com.au/electronics

xulingxuling23

#17
Feb 13, 2013, 03:36 pm Last Edit: Feb 13, 2013, 03:39 pm by xulingxuling23 Reason: 1

No.  You declared motor_drive as an int then tried to use it as a function
Code: [Select]
int motor_drive;
Code: [Select]
motor_drive(right_speed, left_speed); //Sends PWM signals to the motors
Declaring it as another type will not solve the problem.
Should there be a function in your code that causes both motors to run ?

yeah i want both motors run sir and i make a functian and ^^ no errors thx sir

liuzengqiang

Nick,

That evil symbol! OP must have copied and pasted from some webpage maybe with different character coding.

OP,

I think frankly you should go through basic arduino and c tutorials. You don't seem to understand programming and yet want to do a project that needs some that understanding. Learn the basic first. We can help you write some code, correct mistakes, but you have to understand your (or what you found) code first.
Serial LCD keypad panel,phi_prompt user interface library,SDI-12 USB Adapter

michinyon

You cannot have an int variable  and a function with the same name.

I thought you could.  The compiler should be able to figure it out.
But I wrote a short test program,  and apparently,  you can't.

And even if it was allowed, it's confusing.  Don't give program variables
and functions the same name.

PaulS

Quote
You cannot have an int variable  and a function with the same name.

I thought you could.  The compiler should be able to figure it out.

Why? They are both just symbols.

I'm sure that you've seen people posting here something like:
Code: [Select]
void myFun()
{
}

void loop()
{
   myFun;
}

wondering why muFun was not called. The compiler just saw a symbol that was not syntactically invalid. That's really no different from:
Code: [Select]
void loop()
{
   7;
}

Useless, but perfectly legal.

UKHeliBob



yeah i want both motors run sir and i make a functian and ^^ no errors thx sir

Do you know how to make one motor run, either way will do to start with ?
You are probably using a motor shield (which one ?)  Are there any example programs for it ?
Please do not send me PMs asking for help.  Post in the forum then everyone will benefit from seeing the questions and answers.

xulingxuling23




yeah i want both motors run sir and i make a functian and ^^ no errors thx sir

Do you know how to make one motor run, either way will do to start with ?
You are probably using a motor shield (which one ?)  Are there any example programs for it ?


Code: [Select]
#define motor1pole1 2
#define motor1pole2 3
#define motor2pole1 7
#define motor2pole2 8

// map L293d motor enable pins to Arduino pins
#define enablePin1 9
#define enablePin2 10

#define M1_MAX_SPEED 100
#define M2_MAX_SPEED 100

#define motordelay 30
#define debugmotorsec 3000

void setup() {
  Serial.begin(9600);

  // set mapped L293D motor1 and motor 2 enable pins on Arduino to output (to turn on/off motor1 and motor2 via L293D)
  pinMode(enablePin1, OUTPUT);
  pinMode(enablePin2, OUTPUT);

  // set mapped motor poles to Arduino pins (via L293D)
  pinMode( motor1pole1 , OUTPUT);
  pinMode( motor1pole2, OUTPUT);
  pinMode( motor2pole1, OUTPUT);
  pinMode( motor2pole2 , OUTPUT);
  motorspeed(0, 0);
}

int mspeed = 100;  // pick a starting speed up to 255

void loop() {

// set speed of motor 1 and 2 to same speed
  motorspeed(mspeed, mspeed);

// spin motor 1 only in one direction
  Serial.print("MOTOR 1 FORWARD @ SPEED: ");
  Serial.println(mspeed);
  motorforward(1);
  delay(debugmotorsec);
  motorstop(1);

  // spin motor 2 only in one direction
  Serial.print("MOTOR 2 FORWARD @ SPEED: ");
  Serial.println(mspeed);
  motorforward(2);
  delay(debugmotorsec);
  motorstop(2);

  // spin motor 1 only in opposite direction
  Serial.print("MOTOR 1 BACK @ SPEED: ");
  Serial.println(mspeed);
  motorback(1);
  delay(3000);
  motorstop(1);

// spin motor 2 only in opposite direction
  Serial.print("MOTOR 2 BACK @ SPEED: "); 
  Serial.println(mspeed);
  motorback(2);
  delay(debugmotorsec);
  motorstop(2);

// stop both motors 1 and 2
  Serial.println("BOTH MOTORS STOP FOR 2 SEC.");
  motorstop(1);
  motorstop(2);
  delay(2000);

// spin both motors in one direction
  Serial.print("BOTH MOTORS FORWARD @ SPEED: ");
  Serial.println(mspeed);
  motorforward(1);
  motorforward(2);
  delay(debugmotorsec);

// stop both motors
  Serial.println("BOTH MOTORS STOP FOR 2 SEC.");
  motorstop(1);
  motorstop(2);

  delay(2000);
// spin both motors in opposite direction
  Serial.print("BOTH MOTORS BACK @ SPEED: ");
  Serial.println(mspeed);
  motorback(1);
  motorback(2);
  delay(debugmotorsec);

// stop both motors
  Serial.println("BOTH MOTORS STOP FOR 2 SEC.");
  motorstop(1);
  motorstop(2);
  delay(2000);


// spin both motors but in opposite directions
  Serial.print("MOTOR1 FORWARD | MOTOR2 BACK @ SPEED: ");
  Serial.println(mspeed);
  motorforward(1);
  motorback(2);
  delay(debugmotorsec);

// stop both motors
  Serial.println("BOTH MOTORS STOP FOR 2 SEC.");
  motorstop(1);
  motorstop(2);
  delay(2000);

// spin both motors in the other opposite direction
  Serial.print("MOTOR1 BACK | MOTOR2 FORWARD @ SPEED: ");
  Serial.println(mspeed);
  motorback(1);
  motorforward(2);
  delay(debugmotorsec);

// stop both motors
  Serial.println("BOTH MOTORS STOP FOR 2 SEC.");
  motorstop(1);
  motorstop(2);
  delay(2000);

  mspeed += 50;  // add 50 to speed of motor spin. Max speed 255

// set speed of motor 1 and 2 to same new speed
  motorspeed(mspeed,mspeed);

}

// MOTOR FUNCTIONS

void motorstop(int motornum){
  delay(motordelay);
  if (motornum == 1) {
    digitalWrite(motor1pole1, LOW);
    digitalWrite(motor1pole2, LOW);
  }
  else if (motornum == 2) {

    digitalWrite(motor2pole1, LOW);
    digitalWrite(motor2pole2, LOW);
  }
  delay(motordelay);
}

void motorforward(int motornum){
  if (motornum == 1) {
    digitalWrite(motor1pole1, HIGH);
    digitalWrite(motor1pole2, LOW);
  }
  else if (motornum == 2) {

    digitalWrite(motor2pole1, LOW);
    digitalWrite(motor2pole2, HIGH);
  }
  delay(motordelay);
}

void motorback(int motornum){
  if (motornum == 1) {
    digitalWrite(motor1pole1, LOW);
    digitalWrite(motor1pole2, HIGH);
  }
  else if (motornum == 2) {
    digitalWrite(motor2pole1, HIGH);
    digitalWrite(motor2pole2, LOW);
  }
  delay(motordelay);
}

void motorspeed(int motor1speed, int motor2speed) {
  if (motor1speed > M1_MAX_SPEED ) motor1speed = M1_MAX_SPEED; // limit top speed
  if (motor2speed > M2_MAX_SPEED ) motor2speed = M2_MAX_SPEED; // limit top speed
  if (motor1speed < 0) motor1speed = 0; // keep motor above 0
  if (motor2speed < 0) motor2speed = 0; // keep motor speed above 0
  analogWrite(enablePin1, motor1speed);
  analogWrite(enablePin2, motor2speed);
}


here the code is succes working but i cant use on my PID program :(

PaulS

Quote
here the code is succes working but i cant use on my PID program

Since you didn't volunteer, I'll drag it out of you. Why can't you? PID computes an output based on an input and a setup, with the objective of moving the input closer to the setpoint, by changing the output.

If the setpoint is the desired speed, and the input is the actual speed, the output would be the required change in speed/pwm setting/etc. to get the current speed closer to the desired speed.

It isn't clear what your inputs, outpoints, or setpoints would be, though.

Go Up