12V analog input readings

That is a voltage divider and it is the correct way to do this.

Also is that schematic showing a fire alarm panel? I have a friend who builds fire alarm systems in his room.