2 buttons executing different code

Projects Programming
1

Hi, I'm trying to incorporate two buttons into my code that make a motor move forward and reverse respectively. Here is how I have written it

void loop() 
{ 
  buttonState1 = digitalRead(buttonPin1);
  if ((millis() - lastDebounceTime1)>debounceDelay)
  //only if time since last button press > time buffer will code run
  {
  if (buttonState1 == HIGH)
  {
    if (letsgo1 == false)
    {
    letsgo1=true;
    starttime = millis();
    dsa_point = 0;
    digitalWrite(led_ProgRun, HIGH);
    Serial.write(254);
    Serial.write(1);//clears LCD
    Serial.print("Running Sequence...");
    lastDebounceTime1 = millis();
    digitalWrite(SLEEP1, HIGH);
    digitalWrite(SLEEP2, HIGH);
    digitalWrite(SLEEP3, HIGH);
    }
    else //letsgo == true
    {
    letsgo1 = false;
    digitalWrite(led_ProgRun, LOW);
    lastDebounceTime1 = millis();
    Serial.write(254);
    Serial.write(1);//clears LCD
    Serial.print("Sequence Aborted.");
    digitalWrite(SLEEP1, LOW);
    digitalWrite(SLEEP2, LOW);
    digitalWrite(SLEEP3, LOW);
    }
  }
  if (letsgo1==true)
  { 
    currenttime = millis() - starttime; 
    if (dosomethingat[dsa_point][0] <= currenttime)
    {
     switch (dosomethingat[dsa_point][1])
     {
      case 1: //when switch variable = 1
      if (dosomethingat[dsa_point][2]==1)
      {
        stepper1.setMaxSpeed(dosomethingat[dsa_point][3]);
        stepper1.move(dosomethingat[dsa_point][4]); 
        

      }
      break;
      
      case 2:
      if (dosomethingat[dsa_point][2]==1)
      {
        stepper2.setMaxSpeed(dosomethingat[dsa_point][3]);
        stepper2.move(dosomethingat[dsa_point][4]);
         
      }
      break;
      
      
      case 0: // 
      Serial.write(254);
      Serial.write(1);//clears LCD
      Serial.print("Sequence complete.");
      digitalWrite(led_ProgRun, LOW);
      digitalWrite(SLEEP1, LOW);
      digitalWrite(SLEEP2, LOW);
      digitalWrite(SLEEP3, LOW);
      break;
    }
    dsa_point = dsa_point +1;
  }
}
}

buttonState2 = digitalRead(buttonPin2);
  if ((millis() - lastDebounceTime2)>debounceDelay)
  {
    if (buttonState2 == HIGH)
    {
      if (letsgo2 == false)
      {
        letsgo1 = false;
        letsgo2 = true;
        Serial.write(254);
        Serial.write(1);//clears LCD
        Serial.print("Withdrawing Syringes...");
        lastDebounceTime2 = millis();
        stepper1.setMaxSpeed(1000);
        stepper1.move(-20000);
        stepper2.setMaxSpeed(1000);
        stepper2.move(-20000);
      }  
  else //letsgo2 == true
    {
    letsgo2 = false;
    digitalWrite(led_ProgRun, LOW);
    lastDebounceTime2 = millis();
    Serial.write(254);
    Serial.write(1);//clears LCD
    Serial.print("Load Syringe");
    digitalWrite(SLEEP1, LOW);
    digitalWrite(SLEEP2, LOW);
    digitalWrite(SLEEP3, LOW);
    }  
    }
  }  

stepper1.run();
stepper2.run();


}

However this does not work and the motor moves forward for about half a second when I press the first button. Any suggestions?

2

Your {curly braces} are incomplete.
Switch.. case will not work as you think it is.
Fix that and try again.

3

I'm not sure I follow, that switch case worked fine in a different code and was simply copied and the second button was added

4

It does not seem like the second if will run since false was set just previous.

else //letsgo == true
    {
    letsgo1 = false;
    digitalWrite(led_ProgRun, LOW);
    lastDebounceTime1 = millis();
    Serial.write(254);
    Serial.write(1);//clears LCD
    Serial.print("Sequence Aborted.");
    digitalWrite(SLEEP1, LOW);
    digitalWrite(SLEEP2, LOW);
    digitalWrite(SLEEP3, LOW);
    }
  }
  if (letsgo1==true) // will this ever be true at this point if you set it false every time above???
  {
5

I was wrong.
Looked at a working sketch of mine where every case was followed by a {} but the reference pages do not show those.
So the {} are not necessary in this case, so sorry.

6

@C2, that part of the code works fine as I've tried it without the second button. However once the second button is added it doesn't work..

7

However once the second button is added it doesn't work..

What do your serial prints tell you is happening? Why don't you have any?

Why don't you use Tools + Auto Format to fix that horrid mess?