2 out puts not working

Projects Programming
1

my pinmode output 5 and 6 dont work with this code but will work when they are stand alone. What is causing the arduino to not output anything from these outputs within my code?
Heres the code:

#include <SoftwareSerial.h> // use the software serial library
SoftwareSerial mySerial(3,4); // receive data at pin 3; transmit data at pin 2
int setpoint;
float val;
int roomtemp;
int UCL;
int LCL;
float salinity;
void setup() {
// put your setup code here, to run once:
Serial.begin(9600);
pinMode(5,OUTPUT);
pinMode(6,OUTPUT);
pinMode(3,OUTPUT);
pinMode(2, OUTPUT);
roomtemp=25;
setpoint=7.0291*roomtemp+334.73;
UCL=setpoint+6.12;
LCL=setpoint-6.12;
Serial.print("Setpoint =");
Serial.print(setpoint);
Serial.print("Degrees Celsius");
Serial.print("UCL =");
Serial.print(UCL);
Serial.print("Degrees Celsius");
Serial.print("LCL =");
Serial.print(LCL);
Serial.print("Degrees Celsius");
mySerial.begin(9600); delay(500); // set data rate to 9600 baud; wait for bootup
mySerial.write(254); mySerial.write(128);
mySerial.write(254); mySerial.write(1); // clear screen & move to top left position
mySerial.write(254); mySerial.write(132);
mySerial.print("LCL");
mySerial.write(254); mySerial.write(139);
mySerial.print("SP");
mySerial.write(254); mySerial.write(144);
mySerial.print("UCL");
mySerial.write(254); mySerial.write(192);
mySerial.print("S:");
mySerial.write(254); mySerial.write(195);
mySerial.print(0.072,3);
mySerial.write(254); mySerial.write(201);
mySerial.print(0.100,3);
mySerial.write(254); mySerial.write(207);
mySerial.print(0.108,3);
mySerial.write(254); mySerial.write(148);
mySerial.print("T:");
mySerial.write(254); mySerial.write(152);
mySerial.print("24.1");
mySerial.write(254); mySerial.write(158);
mySerial.print("25.0");
mySerial.write(254); mySerial.write(164);
mySerial.print("25.9");
mySerial.write(254); mySerial.write(212);
mySerial.write(254); mySerial.write(212);
mySerial.print("S=");
mySerial.write(254); mySerial.write(220);
mySerial.print("T=");
}

void loop() {
Serial.println();
int val=analogRead(5);
Serial.print("Analog Value =");
Serial.print(val);
Serial.print("Temperature =");
Serial.println((0.14227val)-47.621);
if(val<LCL) digitalWrite(3,HIGH);
else if(val>UCL) digitalWrite(3,LOW);
mySerial.write(254); mySerial.write(227);
if(val<LCL) mySerial.write("H= ON");
mySerial.write(254); mySerial.write(227);
if(val>UCL) mySerial.write("H=OFF");
digitalWrite(2, HIGH);
delay(100);
int analogS=analogRead(4);
digitalWrite(2, LOW);
Serial.println(analogS);
delay(1000);
salinity = 2.0955pow(10,-19)pow(analogS,5.8106)100.000;
Serial.print("Salinity =");
Serial.println(salinity);
mySerial.write(254); mySerial.write(214);
mySerial.print(salinity);
mySerial.write(254); mySerial.write(222);
mySerial.print((0.14227val)-47.621,1);
Serial.println("analog value");
Serial.print(analogRead(4));
float target= (salinity-(salinity-.1).60);
float numer=((((target).08585-(salinity).08585)/(.1-(.1*.15+salinity*.85)))*60.0);
float denom= ((.1));
float valve= ((numer/denom)/10.00);
if(.096.104){
delay(5000);
}if(salinity>.104){
Serial.print("Entering DIon Function");
digitalWrite(6,HIGH);
delay(valve);
digitalWrite(6,LOW);
delay(5000);
}
if(salinity<.096){
Serial.print("Entering Saltyon Function");
digitalWrite(5,HIGH);
delay(valve);
digitalWrite(5,LOW);
delay(5000);
}
Serial.print("time");
Serial.println(valve);
}

2

What does "standalone" code mean?

Put your sketch in </> code tags.

3

What do you mean with "my pinmode output 5 and 6 dont work with this code"? "Don't work" doesn't tell us anything.

Are you tring to tell us that even though the Serial Monitor Displays "Entering DIon Function" but pin 6 does not go high then low and that the Serial Monitor Displays "Entering Saltyon Function" but pin 5 does not go high then low?

Before posting your code with code tags as suggested by ieee488 (and required by Forum etiquette as stipulated in the post "How to use this forum - please read." at the top of each Forum area), please also use the pretty print to clean up the code a bit.

I may be wrong, but "if(.096.104){" Looks funny to me. Does that really mean to test that salinity is within the range of 0.096 and 0.104?

4

  if (.096<salinity>.104)Not just funny but completely wrong

To test whether the value of salinity is smaller than .096 and greater than .104 you have to test both values

  if (salinity < 0.096 && salinity > 0.104)

You would also be wise to print the value of salinity before testing it so that you can see what is going on. Better still, work with integers for the value and display floats if/when needed. Floats are inherently inaccurate