Hello everyone,
I have a question because I don't know what to do.
I would like to have 3 buttons that when pressed each perform a certain task,
I looked at the debounce code and tried to adapt it, but sadly the results are mixed,
can anyone help me sort out what I'm doing wrong
// constants won't change. They're used here to
// set pin numbers:
const int buttonPin = 2; // the number of the pushbutton pin
const int buttonPinb = 3; // the number of the pushbutton pin
const int buttonPinc = 4; // the number of the pushbutton pin
const int ledPin = 13; // the number of the LED pin
const int ledPinb = 12; // the number of the LED pin
const int ledPinc= 11; // the number of the LED pin
// Variables will change:
int ledState = HIGH; // the current state of the output pin
int ledStateb = HIGH; // the current state of the output pin
int ledStatec = HIGH; // the current state of the output pin
int buttonState; // the current reading from the input pin
int buttonStateb; // the current reading from the input pin
int buttonStatec; // the current reading from the input pin
int lastButtonState = LOW; // the previous reading from the input pin
// the following variables are long's because the time, measured in miliseconds,
// will quickly become a bigger number than can be stored in an int.
long lastDebounceTime = 0; // the last time the output pin was toggled
long debounceDelay = 50; // the debounce time; increase if the output flickers
void setup() {
pinMode(buttonPin, INPUT);
pinMode(buttonPinb, INPUT);
pinMode(buttonPinc, INPUT);
pinMode(ledPin, OUTPUT);
pinMode(ledPinb, OUTPUT);
pinMode(ledPinc, OUTPUT);
// set initial LED state
digitalWrite(ledPin, ledState);
}
void loop() {
// read the state of the switch into a local variable:
int reading = digitalRead(buttonPin);
// check to see if you just pressed the button
// (i.e. the input went from LOW to HIGH), and you've waited
// long enough since the last press to ignore any noise:
// If the switch changed, due to noise or pressing:
if (reading != lastButtonState) {
// reset the debouncing timer
lastDebounceTime = millis();
}
if ((millis() - lastDebounceTime) > debounceDelay) {
// whatever the reading is at, it's been there for longer
// than the debounce delay, so take it as the actual current state:
// if the button state has changed:
if (reading != buttonState) {
buttonState = reading;
// only toggle the LED if the new button state is HIGH
if (buttonState == HIGH) {
ledState = !ledState;
}
}
}
// set the LED:
digitalWrite(ledPin, ledState);
// save the reading. Next time through the loop,
// it'll be the lastButtonState:
lastButtonState = reading;
buttonB();
buttonC();
}
void buttonB(){
int readingb = digitalRead(buttonPinb);
if (readingb != lastButtonState) {
// reset the debouncing timer
lastDebounceTime = millis();
}
if ((millis() - lastDebounceTime) > debounceDelay) {
// whatever the reading is at, it's been there for longer
// than the debounce delay, so take it as the actual current state:
// if the button state has changed:
if (readingb != buttonState) {
buttonStateb = readingb;
// only toggle the LED if the new button state is HIGH
if (buttonStateb == HIGH) {
ledStateb = !ledStateb;
}
}
}
// set the LED:
digitalWrite(ledPinb, ledStateb);
// save the reading. Next time through the loop,
// it'll be the lastButtonState:
lastButtonState = readingb;
}
void buttonC () {
int readingc = digitalRead(buttonPinb);
if (readingc != lastButtonState) {
// reset the debouncing timer
lastDebounceTime = millis();
}
if ((millis() - lastDebounceTime) > debounceDelay) {
// whatever the reading is at, it's been there for longer
// than the debounce delay, so take it as the actual current state:
// if the button state has changed:
if (readingc != buttonStatec) {
buttonStatec = readingc;
// only toggle the LED if the new button state is HIGH
if (buttonStatec == HIGH) {
ledStatec = !ledStatec;
}
}
}
// set the LED:
digitalWrite(ledPinc, ledStatec);
// save the reading. Next time through the loop,
// it'll be the lastButtonState:
lastButtonState = readingc;
}
UKHeliBob:
How are the buttons wired ?
Have you got any pull down resistors on the input pins or are they just at a floating voltage until a button is pressed ?
All the buttons have 10k resistors attached to them, but when I compile the code only the void loop get activated
Ok, I got it to work this time,
here's the code I've used, is there a better way to do it?
/*
Debounce
Each time the input pin goes from LOW to HIGH (e.g. because of a push-button
press), the output pin is toggled from LOW to HIGH or HIGH to LOW. There's
a minimum delay between toggles to debounce the circuit (i.e. to ignore
noise).
The circuit:
* LED attached from pin 13 to ground
* pushbutton attached from pin 2 to +5V
* 10K resistor attached from pin 2 to ground
* Note: On most Arduino boards, there is already an LED on the board
connected to pin 13, so you don't need any extra components for this example.
created 21 November 2006
by David A. Mellis
modified 30 Aug 2011
by Limor Fried
modified 28 Dec 2012
by Mike Walters
This example code is in the public domain.
http://www.arduino.cc/en/Tutorial/Debounce
*/
// constants won't change. They're used here to
// set pin numbers:
const int buttonPin = 2; // the number of the pushbutton pin
const int buttonPinb = 3; // the number of the pushbutton pin
const int buttonPinc = 4; // the number of the pushbutton pin
const int ledPin = 13; // the number of the LED pin
const int ledPinb = 12; // the number of the LED pin
const int ledPinc= 11; // the number of the LED pin
// Variables will change:
int ledState = HIGH; // the current state of the output pin
int ledStateb = HIGH; // the current state of the output pin
int ledStatec = HIGH; // the current state of the output pin
int buttonState; // the current reading from the input pin
int buttonStateb; // the current reading from the input pin
int buttonStatec; // the current reading from the input pin
int lastButtonState = LOW; // the previous reading from the input pin
int lastButtonStateb = LOW; // the previous reading from the input pin
int lastButtonStatec = LOW; // the previous reading from the input pin
// the following variables are long's because the time, measured in miliseconds,
// will quickly become a bigger number than can be stored in an int.
long lastDebounceTime = 0; // the last time the output pin was toggled
long debounceDelay = 50; // the debounce time; increase if the output flickers
void buttonB();
void buttonC();
void setup() {
pinMode(buttonPin, INPUT);
pinMode(buttonPinb, INPUT);
pinMode(buttonPinc, INPUT);
pinMode(ledPin, OUTPUT);
pinMode(ledPinb, OUTPUT);
pinMode(ledPinc, OUTPUT);
// set initial LED state
digitalWrite(ledPin, ledState);
}
void loop() {
// read the state of the switch into a local variable:
int reading = digitalRead(buttonPin);
// check to see if you just pressed the button
// (i.e. the input went from LOW to HIGH), and you've waited
// long enough since the last press to ignore any noise:
// If the switch changed, due to noise or pressing:
if (reading != lastButtonState) {
// reset the debouncing timer
lastDebounceTime = millis();
}
if ((millis() - lastDebounceTime) > debounceDelay) {
// whatever the reading is at, it's been there for longer
// than the debounce delay, so take it as the actual current state:
// if the button state has changed:
if (reading != buttonState) {
buttonState = reading;
// only toggle the LED if the new button state is HIGH
if (buttonState == HIGH) {
ledState = !ledState;
}
}
}
// set the LED:
digitalWrite(ledPin, ledState);
// save the reading. Next time through the loop,
// it'll be the lastButtonState:
lastButtonState = reading;
buttonB();
buttonC();
}
void buttonB(){
int readingb = digitalRead(buttonPinb);
if (readingb != lastButtonStateb) {
// reset the debouncing timer
lastDebounceTime = millis();
}
if ((millis() - lastDebounceTime) > debounceDelay) {
// whatever the reading is at, it's been there for longer
// than the debounce delay, so take it as the actual current state:
// if the button state has changed:
if (readingb != buttonStateb) {
buttonStateb = readingb;
// only toggle the LED if the new button state is HIGH
if (buttonStateb == HIGH) {
ledStateb = !ledStateb;
}
}
}
// set the LED:
digitalWrite(ledPinb, ledStateb);
// save the reading. Next time through the loop,
// it'll be the lastButtonState:
lastButtonStateb = readingb;
}
void buttonC () {
int readingc = digitalRead(buttonPinc);
if (readingc != lastButtonStatec) {
// reset the debouncing timer
lastDebounceTime = millis();
}
if ((millis() - lastDebounceTime) > debounceDelay) {
// whatever the reading is at, it's been there for longer
// than the debounce delay, so take it as the actual current state:
// if the button state has changed:
if (readingc != buttonStatec) {
buttonStatec = readingc;
// only toggle the LED if the new button state is HIGH
if (buttonStatec == HIGH) {
ledStatec = !ledStatec;
}
}
}
// set the LED:
digitalWrite(ledPinc, ledStatec);
// save the reading. Next time through the loop,
// it'll be the lastButtonState:
lastButtonStatec = readingc;
}