7 segment with rotary

Projects Programming
1

here is my code. can it be made shorter and better ?
works btw

int anodeLeds[] = {4, 5, 6, 7, 8, 9, 10};
int cathodeDigits[] = {1, 11, 12, 13};
int displayBuf[2];
int j = 0;
int startTime = 0;
int endTime;
int pinA = 2;
int pinB = 3;
int Previous, State;
int counter = 0;
int rot_dir = 0;

int num_array[10][7] = {
{ 1, 1, 1, 1, 1, 1, 0 }, // 0
{ 0, 1, 1, 0, 0, 0, 0 }, // 1
{ 1, 1, 0, 1, 1, 0, 1 }, // 2
{ 1, 1, 1, 1, 0, 0, 1 }, // 3
{ 0, 1, 1, 0, 0, 1, 1 }, // 4
{ 1, 0, 1, 1, 0, 1, 1 }, // 5
{ 1, 0, 1, 1, 1, 1, 1 }, // 6
{ 1, 1, 1, 0, 0, 0, 0 }, // 7
{ 1, 1, 1, 1, 1, 1, 1 }, // 8
{ 1, 1, 1, 0, 0, 1, 1 }
}; // 9
void setup() {
// put your setup code here, to run once:
for (int i = 0; i < 7; i++)
{
pinMode(anodeLeds*, OUTPUT);*

  • }*
  • for (int i = 0; i < 4; i++)*
  • {*
    _ pinMode(cathodeDigits*, OUTPUT);_
    _     }_
    _     displayBuf[1] = 0; // initializes the display*_
    * displayBuf[0] = 0;*
    * pinMode(pinA, INPUT);*
    * pinMode(pinB, INPUT);*
    * digitalWrite (pinA, HIGH); // enable pull-up*
    * digitalWrite (pinB, HIGH); // enable pull-up*
    * attachInterrupt (digitalPinToInterrupt(pinA), rotaryTurn, FALLING);*
    * Serial.begin(9600);*
    }
    void loop() {
    * // put your main code here, to run repeatedly:*
    * refreshDisplay(displayBuf[1], displayBuf[0]);*
    * State = digitalRead(pinA);*
    * if (State != Previous)*
    * {*
    * if (digitalRead(pinB) != State)*
    * {*
    * counter++;*
    * }*
    * else*
    * {*
    * counter--;*
    * }*
    * Serial.print("Position: ");*
    * Serial.println(counter);*
    * Previous = State;*
    * }*
    * if (counter > 9)*
    * {*
    * j++;*
    * counter = 0;*
    * if (j > 9) j = 0;*
    * }*
    * if (counter < 0 && j > 0)*
    * {*
    * j--;*
    * counter = 9;*
    * }*
    * displayBuf[0] = counter; // send the updated count to the display buffer*
    * displayBuf[1] = j;*
    }
    void displayDigit(int digit)
    {
    * for (int i = 0; i < 7; i++)*
    * {*
    digitalWrite(anodeLeds, num_array[digit]);
    * }*
    }
    void refreshDisplay(int digit1, int digit0)
    {
    * digitalWrite(cathodeDigits[0], HIGH); // displays digit 0 (least significant)*
    * digitalWrite(cathodeDigits[1], HIGH );*
    * digitalWrite(cathodeDigits[2], LOW );*
    * digitalWrite(cathodeDigits[3], HIGH );*
    * displayDigit(digit0);*
    * delay(5);*
    * digitalWrite(cathodeDigits[0], HIGH); // then displays digit 1*
    * digitalWrite(cathodeDigits[1], LOW);*
    * digitalWrite(cathodeDigits[2], HIGH );*
    * digitalWrite(cathodeDigits[3], HIGH );*
    * displayDigit(digit1);*
    * delay(5);*
    }
    void rotaryTurn()
    {
    * rot_dir = digitalRead(pinA);
    _ State = 1;
    }*_
2

Fix the int vs unsigned long thing as suggested in your other thread.