8x8 Led matrix turn signal control by switches

system · April 25, 2014, 5:30pm

I having a problem with my right and left signal.
I connect the 8x8 LED matrix to 2 shift register.
I desire to create a code with (left switch on) left signal on for 1 second then off for 1 second and keep repeat. This goes same to right switch.

This is my code. The output of this code is when left switch on the left signal blinking very fast. The blinking rate as i desire is 1 sec for on and off.

int latchPin = 8;
int clockPin = 12;
int dataPin = 11;
int inputPin2 = 2;            // input pin for left (switch) 
int inputPin3 = 3;            //input pin for right (switch)
int valleft = 0;
int valright =0;

int LEDs[8][8] = {   
  {0, 0, 0, 0, 0, 0, 0, 0},      //blank
  {0, 0, 0, 0, 0, 0, 0, 0},
  {0, 0, 0, 0, 0, 0, 0, 0},
  {0, 0, 0, 0, 0, 0, 0, 0},
  {0, 0, 0, 0, 0, 0, 0, 0},
  {0, 0, 0, 0, 0, 0, 0, 0},
  {0, 0, 0, 0, 0, 0, 0, 0},
  {0, 0, 0, 0, 0, 0, 0, 0}      
};

int right[8][8] = {   
  {0, 0, 0, 0, 1, 0, 0, 0},      //right signal 
  {0, 0, 0, 0, 1, 1, 0, 0},
  {1, 1, 1, 1, 1, 1, 1, 0},
  {1, 1, 1, 1, 1, 1, 1, 1},
  {1, 1, 1, 1, 1, 1, 1, 1},
  {1, 1, 1, 1, 1, 1, 1, 0},
  {0, 0, 0, 0, 1, 1, 0, 0},
  {0, 0, 0, 0, 1, 0, 0, 0}      
};

int left[8][8] = {   
  {0, 0, 0, 1, 0, 0, 0, 0},        //left signal 
  {0, 0, 1, 1, 0, 0, 0, 0},
  {0, 1, 1, 1, 1, 1, 1, 1},
  {1, 1, 1, 1, 1, 1, 1, 1},
  {1, 1, 1, 1, 1, 1, 1, 1},
  {0, 1, 1, 1, 1, 1, 1, 1},
  {0, 0, 1, 1, 0, 0, 0, 0},
  {0, 0, 0, 1, 0, 0, 0, 0}      
};

void setup() {
  pinMode(latchPin, OUTPUT);
  pinMode(clockPin, OUTPUT);
  pinMode(dataPin, OUTPUT);
  pinMode(inputPin2, INPUT);
  pinMode(inputPin3, INPUT);
}

void loop() {
valleft = digitalRead (inputPin2);
valright = digitalRead (inputPin3);  

  if (valleft == HIGH) {      //when the left switch is on 
lightLED(left);                    //display left signal 
delay(1000);                      //waits for 1 sec ( this code seem like not working) 
lightLED(LEDs);                   // off 
delay(1000):
  }
  else if (valright == HIGH) {
lightLED(right);
delay(1000);
lightLED(LEDs);
delay(1000):
  }
else 
lightLED(LEDs);
}
void lightLED(int tempLED[8][8]) {          //run the lightLED  bit by bit 
  byte columnbitsToSend = 0;
  byte rowbitsToSend = 0;
  
  int x = 0;
  int y = 0;
  for (x = 0; x < 8; x++) {
    columnbitsToSend = 0;
    rowbitsToSend = 0;
      
    for (y = 0; y < 8; y ++) {
      if (tempLED[x][y] == 1) {
        bitWrite(rowbitsToSend, y, HIGH);
      } 
    }
    
    digitalWrite(latchPin, LOW);
    bitWrite(columnbitsToSend, x, HIGH);
    shiftOut(dataPin, clockPin, MSBFIRST, columnbitsToSend);
    shiftOut(dataPin, clockPin, MSBFIRST, rowbitsToSend);
    digitalWrite(latchPin, HIGH);   
    delay(2);
  }
  
}

(code tags added by moderator)

CrossRoads · April 25, 2014, 6:37pm

You need to make the delay part of the multiplexing, instead of cyclying thru all the data and then delaying.
Run the multiplexing for longer than just the one pass it gets now.

Paul_B · April 26, 2014, 11:46am

int latchPin = 8;
int clockPin = 12;
int dataPin = 11;
int inputPin2 = 2;            // input pin for left (switch) 
int inputPin3 = 3;            //input pin for right (switch)
int valleft = 0;
int valright =0;

int LEDs[8][8] = {   
  {
    0, 0, 0, 0, 0, 0, 0, 0        }
  ,      //blank
  {
    0, 0, 0, 0, 0, 0, 0, 0        }
  ,
  {
    0, 0, 0, 0, 0, 0, 0, 0        }
  ,
  {
    0, 0, 0, 0, 0, 0, 0, 0        }
  ,
  {
    0, 0, 0, 0, 0, 0, 0, 0        }
  ,
  {
    0, 0, 0, 0, 0, 0, 0, 0        }
  ,
  {
    0, 0, 0, 0, 0, 0, 0, 0        }
  ,
  {
    0, 0, 0, 0, 0, 0, 0, 0        }      
};

int right[8][8] = {   
  {
    0, 0, 0, 0, 1, 0, 0, 0        }
  ,      //right signal 
  {
    0, 0, 0, 0, 1, 1, 0, 0        }
  ,
  {
    1, 1, 1, 1, 1, 1, 1, 0        }
  ,
  {
    1, 1, 1, 1, 1, 1, 1, 1        }
  ,
  {
    1, 1, 1, 1, 1, 1, 1, 1        }
  ,
  {
    1, 1, 1, 1, 1, 1, 1, 0        }
  ,
  {
    0, 0, 0, 0, 1, 1, 0, 0        }
  ,
  {
    0, 0, 0, 0, 1, 0, 0, 0        }      
};

int left[8][8] = {   
  {
    0, 0, 0, 1, 0, 0, 0, 0        }
  ,        //left signal 
  {
    0, 0, 1, 1, 0, 0, 0, 0        }
  ,
  {
    0, 1, 1, 1, 1, 1, 1, 1        }
  ,
  {
    1, 1, 1, 1, 1, 1, 1, 1        }
  ,
  {
    1, 1, 1, 1, 1, 1, 1, 1        }
  ,
  {
    0, 1, 1, 1, 1, 1, 1, 1        }
  ,
  {
    0, 0, 1, 1, 0, 0, 0, 0        }
  ,
  {
    0, 0, 0, 1, 0, 0, 0, 0        }      
};

void setup() {
  pinMode(latchPin, OUTPUT);
  pinMode(clockPin, OUTPUT);
  pinMode(dataPin, OUTPUT);
  pinMode(inputPin2, INPUT);
  pinMode(inputPin3, INPUT);
}

void loop() {
  int t;
  valleft = digitalRead (inputPin2);
  valright = digitalRead (inputPin3);  

  if (valleft == HIGH) {                 //when the left switch is on 
    for (t = 0; t < 64) lightLED(left);  //display left signal 
    lightLED(LEDs);                      // off 
    delay(1000):
  }
  else if (valright == HIGH) {
    for (t = 0; t < 64) lightLED(right);
    lightLED(LEDs);
    delay(1000):
  }
  else 
    lightLED(LEDs);
}
void lightLED(int tempLED[8][8]) {          //run the lightLED  bit by bit 
  byte columnbitsToSend = 0;
  byte rowbitsToSend = 0;

  int x;
  int y;
  for (x = 0; x < 8; x++) {
    columnbitsToSend = 0;
    rowbitsToSend = 0;

    for (y = 0; y < 8; y ++) {
      if (tempLED[x][y] == 1) {
        bitWrite(rowbitsToSend, y, HIGH);
      } 
    }

    digitalWrite(latchPin, LOW);
    bitWrite(columnbitsToSend, x, HIGH);
    shiftOut(dataPin, clockPin, MSBFIRST, columnbitsToSend);
    shiftOut(dataPin, clockPin, MSBFIRST, rowbitsToSend);
    digitalWrite(latchPin, HIGH);   
    delay(2);
  }

}

system · May 4, 2014, 5:38pm

Paul__B:

int latchPin = 8;

int clockPin = 12;
int dataPin = 11;
int inputPin2 = 2; // input pin for left (switch)
int inputPin3 = 3; //input pin for right (switch)
int valleft = 0;
int valright =0;

int LEDs[8][8] = {
{
0, 0, 0, 0, 0, 0, 0, 0 }
, //blank
{
0, 0, 0, 0, 0, 0, 0, 0 }
,
{
0, 0, 0, 0, 0, 0, 0, 0 }
,
{
0, 0, 0, 0, 0, 0, 0, 0 }
,
{
0, 0, 0, 0, 0, 0, 0, 0 }
,
{
0, 0, 0, 0, 0, 0, 0, 0 }
,
{
0, 0, 0, 0, 0, 0, 0, 0 }
,
{
0, 0, 0, 0, 0, 0, 0, 0 }
};

int right[8][8] = {
{
0, 0, 0, 0, 1, 0, 0, 0 }
, //right signal
{
0, 0, 0, 0, 1, 1, 0, 0 }
,
{
1, 1, 1, 1, 1, 1, 1, 0 }
,
{
1, 1, 1, 1, 1, 1, 1, 1 }
,
{
1, 1, 1, 1, 1, 1, 1, 1 }
,
{
1, 1, 1, 1, 1, 1, 1, 0 }
,
{
0, 0, 0, 0, 1, 1, 0, 0 }
,
{
0, 0, 0, 0, 1, 0, 0, 0 }
};

int left[8][8] = {
{
0, 0, 0, 1, 0, 0, 0, 0 }
, //left signal
{
0, 0, 1, 1, 0, 0, 0, 0 }
,
{
0, 1, 1, 1, 1, 1, 1, 1 }
,
{
1, 1, 1, 1, 1, 1, 1, 1 }
,
{
1, 1, 1, 1, 1, 1, 1, 1 }
,
{
0, 1, 1, 1, 1, 1, 1, 1 }
,
{
0, 0, 1, 1, 0, 0, 0, 0 }
,
{
0, 0, 0, 1, 0, 0, 0, 0 }
};

void setup() {
pinMode(latchPin, OUTPUT);
pinMode(clockPin, OUTPUT);
pinMode(dataPin, OUTPUT);
pinMode(inputPin2, INPUT);
pinMode(inputPin3, INPUT);
}

void loop() {
int t;
valleft = digitalRead (inputPin2);
valright = digitalRead (inputPin3);

if (valleft == HIGH) { //when the left switch is on
for (t = 0; t < 64) lightLED(left); //display left signal
lightLED(LEDs); // off
delay(1000):
}
else if (valright == HIGH) {
for (t = 0; t < 64) lightLED(right);
lightLED(LEDs);
delay(1000):
}
else
lightLED(LEDs);
}
void lightLED(int tempLED[8][8]) { //run the lightLED bit by bit
byte columnbitsToSend = 0;
byte rowbitsToSend = 0;

int x;
int y;
for (x = 0; x < 8; x++) {
columnbitsToSend = 0;
rowbitsToSend = 0;

for (y = 0; y < 8; y ++) {
if (tempLED[x][y] == 1) {
bitWrite(rowbitsToSend, y, HIGH);
}
}

digitalWrite(latchPin, LOW);
bitWrite(columnbitsToSend, x, HIGH);
shiftOut(dataPin, clockPin, MSBFIRST, columnbitsToSend);
shiftOut(dataPin, clockPin, MSBFIRST, rowbitsToSend);
digitalWrite(latchPin, HIGH);
delay(2);
}

}

May i know why the delay command work with
lightLED(LEDs);
delay(1000); //it is working

and does not work with
lightLED(right);
delay(1000); //not working

Paul_B · May 4, 2014, 10:30pm

My apologies - I corrected the program flow, but failed to spot the glaring typo! Picked that up on my little netbook reading in bed this morning.

This should work now - I think!

int latchPin = 8;
int clockPin = 12;
int dataPin = 11;
int inputPin2 = 2;            // input pin for left (switch) 
int inputPin3 = 3;            //input pin for right (switch)
int valleft = 0;
int valright =0;

int LEDs[8][8] = {   
  { 0, 0, 0, 0, 0, 0, 0, 0 } , //blank
  { 0, 0, 0, 0, 0, 0, 0, 0 } ,
  { 0, 0, 0, 0, 0, 0, 0, 0 } ,
  { 0, 0, 0, 0, 0, 0, 0, 0 } ,
  { 0, 0, 0, 0, 0, 0, 0, 0 } ,
  { 0, 0, 0, 0, 0, 0, 0, 0 } ,
  { 0, 0, 0, 0, 0, 0, 0, 0 } ,
  { 0, 0, 0, 0, 0, 0, 0, 0 }   
};

int right[8][8] = {   
  { 0, 0, 0, 0, 1, 0, 0, 0 } , //right signal 
  { 0, 0, 0, 0, 1, 1, 0, 0 } ,
  { 1, 1, 1, 1, 1, 1, 1, 0 } ,
  { 1, 1, 1, 1, 1, 1, 1, 1 } ,
  { 1, 1, 1, 1, 1, 1, 1, 1 } ,
  { 1, 1, 1, 1, 1, 1, 1, 0 } ,
  { 0, 0, 0, 0, 1, 1, 0, 0 } ,
  { 0, 0, 0, 0, 1, 0, 0, 0 }    
};

int left[8][8] = {   
  { 0, 0, 0, 1, 0, 0, 0, 0 } , //left signal 
  { 0, 0, 1, 1, 0, 0, 0, 0 } ,
  { 0, 1, 1, 1, 1, 1, 1, 1 } ,
  { 1, 1, 1, 1, 1, 1, 1, 1 } ,
  { 1, 1, 1, 1, 1, 1, 1, 1 } ,
  { 0, 1, 1, 1, 1, 1, 1, 1 } ,
  { 0, 0, 1, 1, 0, 0, 0, 0 } ,
  { 0, 0, 0, 1, 0, 0, 0, 0 }    
};

void setup() {
  pinMode(latchPin, OUTPUT);
  pinMode(clockPin, OUTPUT);
  pinMode(dataPin, OUTPUT);
  pinMode(inputPin2, INPUT);
  pinMode(inputPin3, INPUT);
}

void loop() {
  int t;
  valleft = digitalRead (inputPin2);
  valright = digitalRead (inputPin3);  

  if (valleft == HIGH) {                 //when the left switch is on 
    for (t = 0; t < 64; t++) lightLED(left);  //display left signal 
    lightLED(LEDs);                      // off 
    delay(1000);
  }
  else if (valright == HIGH) {
    for (t = 0; t < 64; t++) lightLED(right);
    lightLED(LEDs);
    delay(1000);
  }
  else 
    lightLED(LEDs);
}
void lightLED(int tempLED[8][8]) {          //run the lightLED  bit by bit 
  byte columnbitsToSend = 0;
  byte rowbitsToSend = 0;

  int x;
  int y;
  for (x = 0; x < 8; x++) {
    columnbitsToSend = 0;
    rowbitsToSend = 0;

    for (y = 0; y < 8; y ++) {
      if (tempLED[x][y] == 1) {
        bitWrite(rowbitsToSend, y, HIGH);
      } 
    }

    digitalWrite(latchPin, LOW);
    bitWrite(columnbitsToSend, x, HIGH);
    shiftOut(dataPin, clockPin, MSBFIRST, columnbitsToSend);
    shiftOut(dataPin, clockPin, MSBFIRST, rowbitsToSend);
    digitalWrite(latchPin, HIGH);   
    delay(2);
  }
}

Didn't notice how badly "Auto Format" had mangled the arrays either!

And a few more bugs - wouldn't compile.

system · May 6, 2014, 5:09pm

Paul__B:
My apologies - I corrected the program flow, but failed to spot the glaring typo! Picked that up on my little netbook reading in bed this morning.

This should work now - I think!
int latchPin = 8;

int clockPin = 12;
int dataPin = 11;
int inputPin2 = 2; // input pin for left (switch)
int inputPin3 = 3; //input pin for right (switch)
int valleft = 0;
int valright =0;

int LEDs[8][8] = {
{ 0, 0, 0, 0, 0, 0, 0, 0 } , //blank
{ 0, 0, 0, 0, 0, 0, 0, 0 } ,
{ 0, 0, 0, 0, 0, 0, 0, 0 } ,
{ 0, 0, 0, 0, 0, 0, 0, 0 } ,
{ 0, 0, 0, 0, 0, 0, 0, 0 } ,
{ 0, 0, 0, 0, 0, 0, 0, 0 } ,
{ 0, 0, 0, 0, 0, 0, 0, 0 } ,
{ 0, 0, 0, 0, 0, 0, 0, 0 }
};

int right[8][8] = {
{ 0, 0, 0, 0, 1, 0, 0, 0 } , //right signal
{ 0, 0, 0, 0, 1, 1, 0, 0 } ,
{ 1, 1, 1, 1, 1, 1, 1, 0 } ,
{ 1, 1, 1, 1, 1, 1, 1, 1 } ,
{ 1, 1, 1, 1, 1, 1, 1, 1 } ,
{ 1, 1, 1, 1, 1, 1, 1, 0 } ,
{ 0, 0, 0, 0, 1, 1, 0, 0 } ,
{ 0, 0, 0, 0, 1, 0, 0, 0 }
};

int left[8][8] = {
{ 0, 0, 0, 1, 0, 0, 0, 0 } , //left signal
{ 0, 0, 1, 1, 0, 0, 0, 0 } ,
{ 0, 1, 1, 1, 1, 1, 1, 1 } ,
{ 1, 1, 1, 1, 1, 1, 1, 1 } ,
{ 1, 1, 1, 1, 1, 1, 1, 1 } ,
{ 0, 1, 1, 1, 1, 1, 1, 1 } ,
{ 0, 0, 1, 1, 0, 0, 0, 0 } ,
{ 0, 0, 0, 1, 0, 0, 0, 0 }
};

void setup() {
pinMode(latchPin, OUTPUT);
pinMode(clockPin, OUTPUT);
pinMode(dataPin, OUTPUT);
pinMode(inputPin2, INPUT);
pinMode(inputPin3, INPUT);
}

void loop() {
int t;
valleft = digitalRead (inputPin2);
valright = digitalRead (inputPin3);

if (valleft == HIGH) { //when the left switch is on
for (t = 0; t < 64; t++) lightLED(left); //display left signal
lightLED(LEDs); // off
delay(1000);
}
else if (valright == HIGH) {
for (t = 0; t < 64; t++) lightLED(right);
lightLED(LEDs);
delay(1000);
}
else
lightLED(LEDs);
}
void lightLED(int tempLED[8][8]) { //run the lightLED bit by bit
byte columnbitsToSend = 0;
byte rowbitsToSend = 0;

int x;
int y;
for (x = 0; x < 8; x++) {
columnbitsToSend = 0;
rowbitsToSend = 0;

for (y = 0; y < 8; y ++) {
if (tempLED[x][y] == 1) {
bitWrite(rowbitsToSend, y, HIGH);
}
}

digitalWrite(latchPin, LOW);
bitWrite(columnbitsToSend, x, HIGH);
shiftOut(dataPin, clockPin, MSBFIRST, columnbitsToSend);
shiftOut(dataPin, clockPin, MSBFIRST, rowbitsToSend);
digitalWrite(latchPin, HIGH);
delay(2);
}
}




Didn't notice how badly "Auto Format" had *mangled* the arrays either!


---


And a few *more* bugs - wouldn't compile.

Yup. It is working.
Thanks a lot. ^^

Topic		Replies	Views
led matrix 8*8 and 74hc595 LEDs and Multiplexing	5	3363	May 6, 2021
8x8 Led Matrix powered by 74HC595 General Guidance	4	3118	May 5, 2021
Help with trying to control a DIY RGB LED 8x8 matrix LEDs and Multiplexing	12	2330	January 10, 2022
Using a Shift Register and 8x8 LED Matrix LEDs and Multiplexing	5	2606	May 6, 2021
LED Dot Matrix Programming	5	3566	May 5, 2021

8x8 Led matrix turn signal control by switches

Related topics