ADC Average example query

Hi,
I am using the example code below. I appear to be limited to an array size of 32. Any thing above this results in negative readings. I would like to average at least 100 readings. Is this possible? Thanks

/*
  Smoothing

  Reads repeatedly from an analog input, calculating a running average and
  printing it to the computer. Keeps ten readings in an array and continually
  averages them.

  The circuit:
  - analog sensor (potentiometer will do) attached to analog input 0

  created 22 Apr 2007
  by David A. Mellis  <dam@mellis.org>
  modified 9 Apr 2012
  by Tom Igoe

  This example code is in the public domain.

  https://www.arduino.cc/en/Tutorial/BuiltInExamples/Smoothing
*/

// Define the number of samples to keep track of. The higher the number, the
// more the readings will be smoothed, but the slower the output will respond to
// the input. Using a constant rather than a normal variable lets us use this
// value to determine the size of the readings array.
const int numReadings = 10;

int readings[numReadings];      // the readings from the analog input
int readIndex = 0;              // the index of the current reading
int total = 0;                  // the running total
int average = 0;                // the average

int inputPin = A0;

void setup() {
  // initialize serial communication with computer:
  Serial.begin(9600);
  // initialize all the readings to 0:
  for (int thisReading = 0; thisReading < numReadings; thisReading++) {
    readings[thisReading] = 0;
  }
}

void loop() {
  // subtract the last reading:
  total = total - readings[readIndex];
  // read from the sensor:
  readings[readIndex] = analogRead(inputPin);
  // add the reading to the total:
  total = total + readings[readIndex];
  // advance to the next position in the array:
  readIndex = readIndex + 1;

  // if we're at the end of the array...
  if (readIndex >= numReadings) {
    // ...wrap around to the beginning:
    readIndex = 0;
  }

  // calculate the average:
  average = total / numReadings;
  // send it to the computer as ASCII digits
  Serial.println(average);
  delay(1);        // delay in between reads for stability
}

const int numReadings = 50;`

You are indicating that increasing the number above 32 causes a failure?

The variable "total" is of type "int" which will roll over and become negative at 32k and since an analog-read yields numbers up to 1023, having 32 readings may cause a rollover. Change the data type from "int" to "uint32_t" (which equals an "unsigned long") and see what happens. All your "int" data types should in fact be unsigned since they are never supposed to handle negative values.

Yes, going to 33 or above results in negative numbers.

Did the suggestion of post 3 work?

Amazing, it works perfectly now, thank you all so much.

This topic was automatically closed 180 days after the last reply. New replies are no longer allowed.