Adding Arduino r4 wifi to Firmata board.h file

[ptillisch]

Aargh, that is annoying. I'll provide instructions you can follow to fix the bug in the library:

1. Open the file at the following path in any text editor:

   /Users/jules/Documents/Arduino/libraries/ConfigurableFirmata/src/utility/Boards.h
   

2. Change the code at line 817 in the Boards.h file from this:

   #define IS_PIN_PWM(p)           digitalPinHasPWM(p)
   

   to this;

   #define ARDUINO_IS_PIN_PWM(x)   (((x & PIN_USE_MASK) ==  PIN_PWM_GPT) || ((x & PIN_USE_MASK) ==  PIN_PWM_AGT))
   #define ARDUINO_digitalPinHasPWM(p) (ARDUINO_IS_PIN_PWM(getPinCfgs(p, PIN_CFG_REQ_PWM)[0]))
   #define IS_PIN_PWM(p)           ARDUINO_digitalPinHasPWM(p)
   

3. Save the file.

Now try compiling the sketch again. Hopefully this time it will work.

Explanation

In case you are interested in the boring details of why this was necessary, I'll provide an explanation below. If you aren't interested in such things then you can skip reading the rest of the post.

@julesmoretti

In file included from /Users/jules/Library/Arduino15/packages/arduino/hardware/renesas_uno/1.2.0/cores/arduino/Arduino.h:124:0,
                 from /Users/jules/Documents/Arduino/libraries/ConfigurableFirmata/src/utility/Boards.h:23,
                 from /Users/jules/Documents/Arduino/libraries/ConfigurableFirmata/src/ConfigurableFirmata.h:18,
                 from /Users/jules/Documents/Arduino/libraries/ConfigurableFirmata/src/AnalogOutputFirmata.cpp:19:
/Users/jules/Documents/Arduino/libraries/ConfigurableFirmata/src/AnalogOutputFirmata.cpp: In member function 'virtual boolean AnalogOutputFirmata::handlePinMode(byte, int)':
/Users/jules/Library/Arduino15/packages/arduino/hardware/renesas_uno/1.2.0/variants/UNOWIFIR4/pins_arduino.h:93:30: error: 'IS_PIN_PWM' was not declared in this scope
 #define digitalPinHasPWM(p) (IS_PIN_PWM(getPinCfgs(p, PIN_CFG_REQ_PWM)[0]))
                              ^
/Users/jules/Documents/Arduino/libraries/ConfigurableFirmata/src/utility/Boards.h:817:33: note: in expansion of macro 'digitalPinHasPWM'
 #define IS_PIN_PWM(p)           digitalPinHasPWM(p)
                                 ^~~~~~~~~~~~~~~~

The problem is that there is a macro named IS_PIN_PWM in the UNO R4 WiFi board's Arduino core library:

arduino/ArduinoCore-renesas/blob/1.2.0/cores/arduino/variant.h#L76-L76

but the ConfigurableFirmata library also uses a macro of the same name:

firmata/ConfigurableFirmata/blob/3.2.0/src/utility/Boards.h#L817-L817

The person who added support for the UNO R4 WiFi board attempted to work around that macro name collision by undefining the core's macro before defining the library's macro:

firmata/ConfigurableFirmata/blob/3.2.0/src/utility/Boards.h#L811-L812

However, that doesn't work because the digitalPinHasPWM macro uses the IS_PIN_PWM macro:

arduino/ArduinoCore-renesas/blob/1.2.0/variants/UNOWIFIR4/pins_arduino.h#L93-L93

I worked around this by duplicating all the code from the core for the digitalPinHasPWM macro definition, including the code for the core's IS_PIN_PWM macro.