Airsoft select fire code

Projects General Guidance
1

Sorry if I do not include everything that I needed in this, this is my first post. So I have been working on making an airlift gun have select fire modes using an Arduino nano, but when I use this code the gun starts shooting without me even touching the trigger. Any help would be greatly appreciated.

int led1 = 12;
int led2 = 11;
int led3 = 7;
int led4 = 10;
int led5 = 9;

int motor = 3;

int selector = 8;
int trigger = 5;

int A = 0;
int B = 0;

int count = 0;
int count2 = 0;
int buttonState = 0;
int lastState;

boolean motorState = false;
unsigned long motorStartTime;


void setup() {
  pinMode (led1, OUTPUT);
  pinMode (led2, OUTPUT);
  pinMode (led3, OUTPUT);
  pinMode (led4, OUTPUT);
  pinMode (led5, OUTPUT);
  pinMode (selector, INPUT_PULLUP);
  pinMode (trigger, INPUT);
  pinMode (motor, OUTPUT);

}

void loop() {
  A = digitalRead (selector);
  if (A!=B) {
    if (A == HIGH) {
      count++;
    }
  }
  B = A;
  if (count == 1) {
    digitalWrite (led2, HIGH);
    buttonState = digitalRead(trigger);
    if (buttonState == HIGH) {
      digitalWrite (motor, HIGH);
      delay (10);
      digitalWrite (motor, LOW);
    }
  }
  if (count == 2) {
    digitalWrite (led2, HIGH);
    buttonState = digitalRead(trigger);
    if (buttonState != lastState && motorState == false)
  {
    //Serial.println(buttonState? "HIGH" : "LOW");
    motorStartTime = millis();
    motorState = true;
  }
  lastState = buttonState;
  if (motorState == true)
  {
    if (millis() - motorStartTime <= 10UL)
    {
      digitalWrite(motor, HIGH);
    }
    else
    {
      digitalWrite(motor, LOW);
      motorState = false;
    } 
  }
    }
  
  if (count == 3) {
    digitalWrite (led3, HIGH);
    buttonState = digitalRead(trigger);
    if (buttonState == HIGH) {
      digitalWrite (motor, HIGH);
      delay (10);
      digitalWrite (motor, LOW);
      while (buttonState == HIGH) {
        //Do nothing
      }
    }
  }
  if (count == 4) {
    digitalWrite (led4, HIGH);
    buttonState = digitalRead(trigger);
    if (buttonState == HIGH) {
      for (int count2=0; count2<3; count2++) {
      digitalWrite (motor, HIGH);
      delay (10);
      digitalWrite (motor, LOW);
      }
    }
  }
  if (count == 5) {
    digitalWrite (led5, HIGH);
    buttonState = digitalRead(trigger);
    if (buttonState == HIGH) {
      for (int count2=0; count2<4; count2++) {
      digitalWrite (motor, HIGH);
      delay (10);
      digitalWrite (motor, LOW);
      }
    }
  }
  if (count == 6) {
    count = 0;
    digitalWrite (led2, LOW);
    digitalWrite (led3, LOW);
    digitalWrite (led4, LOW);
    digitalWrite (led5, LOW);
  }
}
2

If the trigger is on pin 5, have you tried setting it to low to see if that stops the auto fire?

void setup() {
  pinMode (led1, OUTPUT);
  pinMode (led2, OUTPUT);
  pinMode (led3, OUTPUT);
  pinMode (led4, OUTPUT);
  pinMode (led5, OUTPUT);
  pinMode (selector, INPUT_PULLUP);
  pinMode (trigger, INPUT);
  pinMode (motor, OUTPUT);

  digitalWrite (trigger, LOW);
...
}

or if the trigger is pulled down to fire;

void setup() {
  pinMode (led1, OUTPUT);
  pinMode (led2, OUTPUT);
  pinMode (led3, OUTPUT);
  pinMode (led4, OUTPUT);
  pinMode (led5, OUTPUT);
  pinMode (selector, INPUT_PULLUP);
  pinMode (trigger, INPUT);
  pinMode (motor, OUTPUT);

  digitalWrite (trigger, HIGH);
...
}
3

What is an airlift gun? Did you mean an airsoft gun?

4

Yes, I did mean airsoft gun, sorry about; I will try your suggestion and see if that works.

5

Either change the logic of trigger and set it INPUT_PULLUP, or wire a external pull-down resistor to it.

6

Get more ammunition. Hit everything. Win!

The selector has no stopping mechanism, so the moment you press the selector, the code counts from 0 to 6 and resets to 1 immediately. If the selector lands on 0, the trigger will not work. Should the selector climb in value with each button press? If so, you will need to debounce the selector.

https://docs.arduino.cc/built-in-examples/digital/Debounce/

Here is the diagram.json file for wokwi with a pull-down resistor on the trigger 
{
  "version": 1,
  "author": "",
  "editor": "wokwi",
  "parts": [
    { "type": "wokwi-arduino-nano", "id": "nano", "top": -4.8, "left": -0.5, "attrs": {} },
    {
      "type": "wokwi-led-bar-graph",
      "id": "bargraph1",
      "top": -129.6,
      "left": 148.8,
      "attrs": { "color": "lime" }
    },
    {
      "type": "wokwi-pushbutton-6mm",
      "id": "btn1",
      "top": -31,
      "left": -19.2,
      "attrs": { "color": "green", "xray": "1" }
    },
    {
      "type": "wokwi-pushbutton-6mm",
      "id": "btn2",
      "top": -59.8,
      "left": -19.2,
      "attrs": { "color": "green", "xray": "1" }
    },
    {
      "type": "wokwi-resistor",
      "id": "r1",
      "top": -72.85,
      "left": 19.2,
      "attrs": { "value": "10000" }
    },
    {
      "type": "wokwi-text",
      "id": "text1",
      "top": -67.2,
      "left": -76.8,
      "attrs": { "text": "trigger" }
    },
    {
      "type": "wokwi-text",
      "id": "text2",
      "top": -38.4,
      "left": -76.8,
      "attrs": { "text": "selector" }
    },
    {
      "type": "wokwi-text",
      "id": "text3",
      "top": -57.6,
      "left": 192,
      "attrs": { "text": "motor" }
    }
  ],
  "connections": [
    [ "bargraph1:C10", "bargraph1:C9", "green", [ "h0" ] ],
    [ "bargraph1:C9", "bargraph1:C8", "green", [ "h0" ] ],
    [ "bargraph1:C8", "bargraph1:C7", "green", [ "h0" ] ],
    [ "bargraph1:C7", "bargraph1:C6", "green", [ "h0" ] ],
    [ "bargraph1:C6", "bargraph1:C5", "green", [ "h0" ] ],
    [ "bargraph1:C5", "bargraph1:C4", "green", [ "h0" ] ],
    [ "bargraph1:C4", "bargraph1:C3", "green", [ "h0" ] ],
    [ "bargraph1:C3", "bargraph1:C2", "green", [ "h0" ] ],
    [ "bargraph1:C2", "bargraph1:C1", "green", [ "h0" ] ],
    [ "nano:GND.3", "bargraph1:C10", "black", [ "v0", "h48" ] ],
    [ "nano:12", "bargraph1:A1", "green", [ "v0" ] ],
    [ "nano:11", "bargraph1:A2", "green", [ "v0" ] ],
    [ "nano:7", "bargraph1:A3", "green", [ "v0" ] ],
    [ "nano:10", "bargraph1:A4", "green", [ "v0" ] ],
    [ "nano:9", "bargraph1:A5", "green", [ "v0" ] ],
    [ "nano:3", "bargraph1:A9", "green", [ "v0" ] ],
    [ "nano:8", "btn1:2.r", "green", [ "v0" ] ],
    [ "btn2:1.r", "r1:1", "green", [ "v0" ] ],
    [ "nano:GND.1", "btn1:1.r", "black", [ "v0" ] ],
    [ "nano:5V", "btn2:2.r", "red", [ "v0" ] ],
    [ "nano:5", "btn2:1.r", "green", [ "v0" ] ],
    [ "nano:GND.1", "r1:2", "black", [ "v0" ] ]
  ],
  "dependencies": {}
}