Analog Value not updating?

unfortunately the full code exceeds the message limit.