Arduino Compilation Error for ESP32 InterpolationLib

Projects Programming
1

Hi,

I have tried compiling example sketch for Arduino Nano/Uno. It works fine.

when i select ESP32 i get arduino compilation error as below

what could be wrong ?

C:\Users\Kalpesh\Documents\Arduino\libraries\InterpolationLib\src\InterpolationLib.cpp:10:114: error: default argument given for parameter 5 of 'static double Interpolation::Step(double*, double*, int, double, double)' [-fpermissive]
 double Interpolation::Step(double xValues[], double yValues[], int numValues, double pointX, double threshold = 1)
                                                                                                                  ^
In file included from C:\Users\Kalpesh\Documents\Arduino\libraries\InterpolationLib\src\InterpolationLib.cpp:8:0:
C:\Users\Kalpesh\Documents\Arduino\libraries\InterpolationLib\src\InterpolationLib.h:66:16: note: previous specification in 'static double Interpolation::Step(double*, double*, int, double, double)' here
  static double Step(double xValues[], double yValues[], int numValues, double pointX, double threshold = 1);
                ^
C:\Users\Kalpesh\Documents\Arduino\libraries\InterpolationLib\src\InterpolationLib.cpp:24:112: error: default argument given for parameter 5 of 'static double Interpolation::Linear(double*, double*, int, double, bool)' [-fpermissive]
 double Interpolation::Linear(double xValues[], double yValues[], int numValues, double pointX, bool trim = true)
                                                                                                                ^
In file included from C:\Users\Kalpesh\Documents\Arduino\libraries\InterpolationLib\src\InterpolationLib.cpp:8:0:
C:\Users\Kalpesh\Documents\Arduino\libraries\InterpolationLib\src\InterpolationLib.h:70:16: note: previous specification in 'static double Interpolation::Linear(double*, double*, int, double, bool)' here
  static double Linear(double xValues[], double yValues[], int numValues, double pointX, bool trim = true);
                ^
C:\Users\Kalpesh\Documents\Arduino\libraries\InterpolationLib\src\InterpolationLib.cpp:56:116: error: default argument given for parameter 5 of 'static double Interpolation::SmoothStep(double*, double*, int, double, bool)' [-fpermissive]
 double Interpolation::SmoothStep(double xValues[], double yValues[], int numValues, double pointX, bool trim = true)
                                                                                                                    ^
In file included from C:\Users\Kalpesh\Documents\Arduino\libraries\InterpolationLib\src\InterpolationLib.cpp:8:0:
C:\Users\Kalpesh\Documents\Arduino\libraries\InterpolationLib\src\InterpolationLib.h:72:16: note: previous specification in 'static double Interpolation::SmoothStep(double*, double*, int, double, bool)' here
  static double SmoothStep(double xValues[], double yValues[], int numValues, double pointX, bool trim = true);
                ^
C:\Users\Kalpesh\Documents\Arduino\libraries\InterpolationLib\src\InterpolationLib.cpp:75:119: error: default argument given for parameter 5 of 'static double Interpolation::CatmullSpline(double*, double*, int, double, bool)' [-fpermissive]
 double Interpolation::CatmullSpline(double xValues[], double yValues[], int numValues, double pointX, bool trim = true)
                                                                                                                       ^
In file included from C:\Users\Kalpesh\Documents\Arduino\libraries\InterpolationLib\src\InterpolationLib.cpp:8:0:
C:\Users\Kalpesh\Documents\Arduino\libraries\InterpolationLib\src\InterpolationLib.h:73:16: note: previous specification in 'static double Interpolation::CatmullSpline(double*, double*, int, double, bool)' here
  static double CatmullSpline(double xValues[], double yValues[], int numValues, double pointX, bool trim = true);
                ^
C:\Users\Kalpesh\Documents\Arduino\libraries\InterpolationLib\src\InterpolationLib.cpp:131:123: error: default argument given for parameter 5 of 'static double Interpolation::ConstrainedSpline(double*, double*, int, double, bool)' [-fpermissive]
 double Interpolation::ConstrainedSpline(double xValues[], double yValues[], int numValues, double pointX, bool trim = true)
                                                                                                                           ^
In file included from C:\Users\Kalpesh\Documents\Arduino\libraries\InterpolationLib\src\InterpolationLib.cpp:8:0:
C:\Users\Kalpesh\Documents\Arduino\libraries\InterpolationLib\src\InterpolationLib.h:74:16: note: previous specification in 'static double Interpolation::ConstrainedSpline(double*, double*, int, double, bool)' here
  static double ConstrainedSpline(double xValues[], double yValues[], int numValues, double pointX, bool trim = true);
                ^

exit status 1

Compilation error: exit status 1
2

InterpolationLib.cpp

uses the default values in the definition of the functions which is wrong. The default parameters should only be defined in the declaration (in the .h file). The AVR compiler allows this, but the ESP compiler does not. You should file a bug against the library.

Or... here is the InterpolationLib.cpp with the defaults commented out

/***************************************************
Copyright (c) 2019 Luis Llamas
(www.luisllamas.es)
Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License
 ****************************************************/
 
 #include "InterpolationLib.h"

double Interpolation::Step(double xValues[], double yValues[], int numValues, double pointX, double threshold /*= 1*/)
{
	// extremos
	if (pointX <= xValues[0]) return yValues[0];
	if (pointX >= xValues[numValues - 1]) return yValues[numValues - 1];

	auto i = 0;
	while (pointX >= xValues[i + 1]) i++;
		if (pointX == xValues[i + 1]) return yValues[i + 1]; // coincidencia exacta

	auto t = (pointX - xValues[i]) / (xValues[i + 1] - xValues[i]);  // punto relativo en el intervalo
	return t < threshold ? yValues[i] : yValues[i + 1];
}

double Interpolation::Linear(double xValues[], double yValues[], int numValues, double pointX, bool trim /*= true*/)
{
	if (trim)
	{
		if (pointX <= xValues[0]) return yValues[0];
		if (pointX >= xValues[numValues - 1]) return yValues[numValues - 1];
	}

	auto i = 0;
	double rst = 0;
	if (pointX <= xValues[0])
	{
		i = 0;
		auto t = (pointX - xValues[i]) / (xValues[i + 1] - xValues[i]);
		rst = yValues[i] * (1 - t) + yValues[i + 1] * t;
	}
	else if (pointX >= xValues[numValues - 1])
	{
		auto t = (pointX - xValues[numValues - 2]) / (xValues[numValues - 1] - xValues[numValues - 2]);
		rst = yValues[numValues - 2] * (1 - t) + yValues[numValues - 1] * t;
	}
	else
	{
		while (pointX >= xValues[i + 1]) i++;
		auto t = (pointX - xValues[i]) / (xValues[i + 1] - xValues[i]);
		rst = yValues[i] * (1 - t) + yValues[i + 1] * t;
	}

	return rst;

}

double Interpolation::SmoothStep(double xValues[], double yValues[], int numValues, double pointX, bool trim /*= true*/)
{
	if (trim)
	{
		if (pointX <= xValues[0]) return yValues[0];
		if (pointX >= xValues[numValues - 1]) return yValues[numValues - 1];
	}

	auto i = 0;
	if (pointX <= xValues[0]) i = 0;
	else if (pointX >= xValues[numValues - 1]) i = numValues - 1;
	else while (pointX >= xValues[i + 1]) i++;
	if (pointX == xValues[i + 1]) return yValues[i + 1];

	auto t = (pointX - xValues[i]) / (xValues[i + 1] - xValues[i]);
	t = t * t * (3 - 2 * t);
	return yValues[i] * (1 - t) + yValues[i + 1] * t;
}

double Interpolation::CatmullSpline(double xValues[], double yValues[], int numValues, double pointX, bool trim /*= true*/)
{
	if (trim)
	{
		if (pointX <= xValues[0]) return yValues[0];
		if (pointX >= xValues[numValues - 1]) return yValues[numValues - 1];
	}

	auto i = 0;
	if (pointX <= xValues[0]) i = 0;
	else if (pointX >= xValues[numValues - 1]) i = numValues - 1;
	else while (pointX >= xValues[i + 1]) i++;
	if (pointX == xValues[i + 1]) return yValues[i + 1];

	auto t = (pointX - xValues[i]) / (xValues[i + 1] - xValues[i]);
	auto t_2 = t * t;
	auto t_3 = t_2 * t;

	auto h00 = 2 * t_3 - 3 * t_2 + 1;
	auto h10 = t_3 - 2 * t_2 + t;
	auto h01 = 3 * t_2 - 2 * t_3;
	auto h11 = t_3 - t_2;

	auto x0 = xValues[i];
	auto x1 = xValues[i + 1];
	auto y0 = yValues[i];
	auto y1 = yValues[i + 1];

	double m0;
	double m1;
	if (i == 0)
	{
		m0 = (yValues[1] - yValues[0]) / (xValues[1] - xValues[0]);
		m1 = (yValues[2] - yValues[0]) / (xValues[2] - xValues[0]);
	}
	else if (i == numValues - 2)
	{
		m0 = (yValues[numValues - 1] - yValues[numValues - 3]) / (xValues[numValues - 1] - xValues[numValues - 3]);
		m1 = (yValues[numValues - 1] - yValues[numValues - 2]) / (xValues[numValues - 1] - xValues[numValues - 2]);
	}
	else
	{
		m0 = catmullSlope(xValues, yValues, numValues, i);
		m1 = catmullSlope(xValues, yValues, numValues, i + 1);
	}

	auto rst = h00 * y0 + h01 * y1 + h10 * (x1 - x0) * m0 + h11 * (x1 - x0) * m1;
	return rst;
}

double Interpolation::catmullSlope(double x[], double y[], int n, int i)
{
	if (x[i + 1] == x[i - 1]) return 0;
	return (y[i + 1] - y[i - 1]) / (x[i + 1] - x[i - 1]);
}

double Interpolation::ConstrainedSpline(double xValues[], double yValues[], int numValues, double pointX, bool trim /*= true*/)
{
	if (trim)
	{
		if (pointX <= xValues[0]) return yValues[0];
		if (pointX >= xValues[numValues - 1]) return yValues[numValues - 1];
	}

	//auto i = 0;
	//while (pointX >= xValues[i + 1]) i++;
	//if (pointX == xValues[i + 1]) return yValues[i + 1];

	auto i = 0;
	if (pointX <= xValues[0]) i = 0;
	else if (pointX >= xValues[numValues - 1]) i = numValues - 1;
	else while (pointX >= xValues[i + 1]) i++;
	if (pointX == xValues[i + 1]) return yValues[i + 1];

	auto x0 = xValues[i + 1];
	auto x1 = xValues[i];
	auto y0 = yValues[i + 1];
	auto y1 = yValues[i];

	auto fd2i_xl1 = getLeftSecondDerivate(xValues, yValues, numValues - 1, i + 1);
	auto fd2i_x = getRightSecondDerivate(xValues, yValues, numValues - 1, i + 1);

	auto d = (fd2i_x - fd2i_xl1) / (6.0f * (x0 - x1));
	auto c = (x0 * fd2i_xl1 - x1 * fd2i_x) / 2.0f / (x0 - x1);
	auto b = (y0 - y1 - c * (x0 * x0 - x1 * x1) - d * (x0 * x0 * x0 - x1 * x1 * x1)) / (x0 - x1);
	auto a = y1 - b * x1 - c * x1 * x1 - d * x1 * x1 * x1;

	auto rst = a + pointX * (b + pointX * (c + pointX * d));
	return rst;
}


double Interpolation::getFirstDerivate(double x[], double y[], int n, int i)
{
	double fd1_x;

	if (i == 0)
	{
		fd1_x = 3.0f / 2.0f * (y[1] - y[0]) / (x[1] - x[0]);
		fd1_x -= getFirstDerivate(x, y, n, 1) / 2.0f;
	}
	else if (i == n)
	{
		fd1_x = 3.0f / 2.0f * (y[n] - y[n - 1]) / (x[n] - x[n - 1]);
		fd1_x -= getFirstDerivate(x, y, n, n - 1) / 2.0f;
	}
	else
	{
		if ((x[i + 1] - x[i]) / (y[i + 1] - y[i]) * (x[i] - x[i - 1]) / (y[i] - y[i - 1]) < 0)
		{
			fd1_x = 0;
		}
		else
		{
			fd1_x = 2.0f / ((x[i + 1] - x[i]) / (y[i + 1] - y[i]) + (x[i] - x[i - 1]) / (y[i] - y[i - 1]));
		}
	}
	return fd1_x;
}

double Interpolation::getLeftSecondDerivate(double x[], double y[], int n, int i)
{
	auto fdi_x = getFirstDerivate(x, y, n, i);
	auto fdi_xl1 = getFirstDerivate(x, y, n, i - 1);

	auto fd2l_x = -2.0f * (fdi_x + 2.0f * fdi_xl1) / (x[i] - x[i - 1]);
	fd2l_x += 6.0f * (y[i] - y[i - 1]) / (x[i] - x[i - 1]) / (x[i] - x[i - 1]);

	return fd2l_x;
}

double Interpolation::getRightSecondDerivate(double x[], double y[], int numValues, int i)
{
	auto fdi_x = getFirstDerivate(x, y, numValues, i);
	auto fdi_xl1 = getFirstDerivate(x, y, numValues, i - 1);

	auto fd2r_x = 2.0f * (2.0f * fdi_x + fdi_xl1) / (x[i] - x[i - 1]);
	fd2r_x -= 6.0f * (y[i] - y[i - 1]) / (x[i] - x[i - 1]) / (x[i] - x[i - 1]);

	return fd2r_x;
}
3

It looks like the source code on github has been fixed a couple of years ago, but isn't in the library manager so you get older code

1 Like
4

True. i have downloaded V1.0.1 from github and problem is resolved.

I hope admin will update the Arduino library to 1.0.1

Thanks alot!!

5

This topic was automatically closed 180 days after the last reply. New replies are no longer allowed.