Arduino IoT cloud LED control (on/off) doesn't work

[resset]

Hello. I'm trying to figure out how to control (turn on/off) a single LED using Arduino IoT cloud with ESP32 but it seems that I'm missing something. When I turn switch ON the LED lits up and Serial monitor shows that my LED is on, but when I tap on the switch again to Turn OFF the LED nothing happens - it stays on and Serial monitor prints "ON" again. What am I doing wrong?

Here is my code and wiring.

/* 
  Sketch generated by the Arduino IoT Cloud Thing "Untitled"
  https://create.arduino.cc/cloud/things/1234567

  Arduino IoT Cloud Variables description

  The following variables are automatically generated and updated when changes are made to the Thing

  bool light1;

  Variables which are marked as READ/WRITE in the Cloud Thing will also have functions
  which are called when their values are changed from the Dashboard.
  These functions are generated with the Thing and added at the end of this sketch.
*/

#include "thingProperties.h"
int lightled = 21;

void setup() {
  pinMode(lightled,OUTPUT);
  // Initialize serial and wait for port to open:
  Serial.begin(9600);
  // This delay gives the chance to wait for a Serial Monitor without blocking if none is found
  delay(1500); 
  
  

  // Defined in thingProperties.h
  initProperties();

  // Connect to Arduino IoT Cloud
  ArduinoCloud.begin(ArduinoIoTPreferredConnection);
  
  /*
     The following function allows you to obtain more information
     related to the state of network and IoT Cloud connection and errors
     the higher number the more granular information you’ll get.
     The default is 0 (only errors).
     Maximum is 4
 */
  setDebugMessageLevel(2);
  ArduinoCloud.printDebugInfo();
}

void loop() {
  ArduinoCloud.update();
  // Your code here 
  
  
}



/*
  Since Light1 is READ_WRITE variable, onLight1Change() is
  executed every time a new value is received from IoT Cloud.
*/
void onLight1Change()  {
  // Add your code here to act upon Light1 change
if(lightled) {
  digitalWrite(lightled,HIGH);
  Serial.println("ON");
  delay(100);
}
else {
digitalWrite(lightled,LOW);
Serial.println("OFF");
delay(100);
  }
}

[noobmastha]

@resset

void onLight1Change()  {
  // Add your code here to act upon Light1 change
if(lightled) {
  digitalWrite(lightled,HIGH);
  Serial.println("ON");
  delay(100);
}
else {
digitalWrite(lightled,LOW);
Serial.println("OFF");
delay(100);
  }
}

lightled is a pin number, you shouldn`t use it in if statement. Try this :

void onLight1Change()  {
  // Add your code here to act upon Light1 change
if(light1) {
  digitalWrite(lightled,HIGH);
  Serial.println("ON");
}
else {
digitalWrite(lightled,LOW);
Serial.println("OFF");
  }
}

Also uncomment bool light1; I suppose that is your cloud variable?

[resset]

Thank you, I'll give it a shot.
Yes, it is a cloud variable and it's not commented. There's no way to comment/uncomment that.

[resset]

@noobmastha

lightled is a pin number, you shouldn`t use it in if statement. Try this :

void onLight1Change()  {
  // Add your code here to act upon Light1 change
if(light1) {
  digitalWrite(lightled,HIGH);
  Serial.println("ON");
}
else {
digitalWrite(lightled,LOW);
Serial.println("OFF");
  }
}

I tried and it worked. Thanks again!