Arduino RGB LED/button color switch project

Projects Programming
1 
/*Goal: make RGB LED light up Red if button pressed, then green if presssed again, then blue, then off. 
In the end, I will have it do other stuff. I just want it to be obvious now what is going on.
Problem: turning red when pressws, not thing working from there. Please help.
*/ 
int red = 3;
int green = 5;
int blue = 6;
int button = 8; 
int bs; //button state
void setup() {
pinMode (red,OUTPUT);
pinMode (green,OUTPUT);
pinMode (blue,OUTPUT);
pinMode (button,INPUT_PULLUP);
bs = 0;
}

void loop() {
digitalRead(button);
if (digitalRead(button) == LOW){
bs++ ;
ifConditions();
delay(100);
}
ifConditions();
}

void ifConditions(){

if (bs == 0)
{
digitalWrite(red,LOW); 
digitalWrite(green,LOW); 
digitalWrite(blue,LOW); 
}

else if (bs=1){
digitalWrite(red,HIGH); 
digitalWrite(green,LOW); 
digitalWrite(blue,LOW); 
/*analogWrite(red,random(255));
analogWrite(green,random(255));
analogWrite(blue,random(255));
delay(random(255));
*/
}

else  if (bs == 2){
digitalWrite(red,LOW); 
digitalWrite(green,HIGH); 
digitalWrite(blue,LOW); 
/*digitalWrite(red,HIGH);
delay(250); 
digitalWrite(red,LOW); 
delay(250); 
digitalWrite(green,HIGH);
delay(250);  
digitalWrite(green,LOW);
delay(250);  
digitalWrite(blue,HIGH);
delay(250); 
digitalWrite(blue,LOW);
delay(250);
*/
}  

else if (bs == 3){
digitalWrite(red,LOW); 
digitalWrite(green,LOW); 
digitalWrite(blue,HIGH); 
/*digitalWrite(red,HIGH);
delay(250); 
digitalWrite(green,HIGH); 
delay(250); 
digitalWrite(blue,HIGH);
delay(250);
digitalWrite(red,LOW); 
digitalWrite(green,LOW); 
digitalWrite(blue,LOW); 
delay(1500);
*/

}

else if (bs == 4){
delay(1);
bs = 0;
}
}
2

I know it may not be the best code and there is some unnecessary stuff, but I just need it to work.

3

What's the problem with it? You kind of brought the patient but forgot to mention the symptom.

4

Hah! The symptom is mentioned in comments in the code!
Better to put the description for us to read outside of the code block.
Also better to remove big chunks of comment blocks. Less confusion makes it easier to spot problems.
Also better to hit CTRT-T in the IDE. This auto formats the code, making it much easier to read.

5 
else if (bs=1){

Ooopsies

6

Thanks. Sometimes, you are so blind to something and then someone else points it out and it becomes obvious. Now it works great!

7

How do you interrupt the if/then conditions thing to change bs?

8

You don't. You wrote them blocking style with delays. So you don't interrupt them you wait for them to finish. If you want to be able to do that then you'll have to rewrite the whole thing to use millis and be non-blocking.