Tried the circuit by powering my Arduino through the usb. And that worked fine. Actually much better than expected.
Then I tried powering the Arduino through a power supply and suddenly my guitar pedals switched off.
That shouldn't have happened.
So I guessed that the audio jack should be carrying voltage already. I disconnected the jack from the pedal chain and measured the voltage on the tip/sleeve of the jack. And as expected the jack carried around 5v.
The voltage on an unconnected pin is floating and "undefined" and it's possible for it to float-up to 5V. But the meter should pull it down to zero (or near zero) so I'm betting the Arduino is fried. Hopefully your pedal isn't also fried!
Do you have any resistors? A resistor between A0 and ground will pull the voltage down to ground (about zero volts). A 1M resistor would be great because that's in the ballpark for a guitar pickup, but a 10K resistor would also be a valid experiment. If you're still getting 5V, the Arduino is bad or A0 might be programmed as an output (software error).
Or as a more complete test try [u]Analog Read Serial[/u] with a potentiometer.
The Arduino can be damaged by negative voltages, including the negative half of an AC audio signal. That shouldn't happen with a direct guitar connection but it could happen with a pedal (lower impedance and more current capability).
It's also possible you "zapped" the Arduino with a [u]static discharge[/u] when you touched the circuitry.
The normal solution for handling the positive & negative halves of an audio signal is to bias the input at 2.5V. The schematic for the standard bias circuit is attached to [u]this post[/u]. But for a guitar, increase the resistors to 1M or more. (The capacitor in the bias circuit will also isolate/protect your guitar & pedals from any DC voltage.)
With the bias, silence will read about 512 on the ADC and your audio readings will be centered around 512. Depending on what your software is doing you may want to subtract-out the bias.
You may want to consider an OPTO ISOLATOR between your main rig and the Arduino
No... Opto-isolators are digital (non-linear) and a guitar pick-up can't drive the internal LED.