Best control structure for task of aligning motor with sensor

Have you checked the inputs from the light sensors to be sure you're getting sensible results?

Use the analogRead function to get the values, and observe the values using Serial.write and the IDE's serial monitor whlle turning the unit by hand.....

no amount of coding will work if this isn't OK.

regards

Allan