bug in servo.cpp?

Forum 2005-2010 (read only) Software Bugs & Suggestions
1

I'm new to the arduino and am playing around with a couple of servos. In looking at the following line of code from servo.cpp that is in the playground library:

pulse0 = (min1616LclockCyclesPerMicrosecond() + (max16-min16)(16LclockCyclesPerMicrosecond())*angle/180L)/64L;

Can't this just be reduced to:
pulse0 = (max1616LclockCyclesPerMicrosecond()*angle/180L)/64L;

Which most likely isn't what the author intended (as there is no min16 term in the second equation).

2

Aquilon,

I was briefly convinced you were right, but looking carefully I see that the "angle/180L" applies only to the "(max16-min16)(16LclockCyclesPerMicrosecond())" term and NOT to "min1616L*clockCyclesPereMicrosecond()". So your reduced expression is not the equivalent.

Mikal

3

Heh. You are right! I was up too late apparently and parens are blurring together.