Can this be Simplified?

Classified123 · June 7, 2021, 9:33pm

Hello,

I'm wondering if the println percentage increase of my subroutine can be simplified such that it increases by 10% every 2500ms or increase by 1% every 2.50ms.

Is there an equation that I can add that would let me do that or do have to do something else?

Thanks in advance.

//Systems Check 
 void SystemCheck()
 {
   display.clearDisplay();
   display.setTextSize(2);
   display.setCursor(0,0);
   display.print("Scanning");
   display.setTextSize(2);
   display.setCursor(0,17);
   display.println("Please");
   display.println("Wait...");
   display.setTextSize(1);
   display.println("0%");
   display.display();
    recognizer.say("Starting Scan");
    delay(2000);
    recognizer.say("Checking Essential Colors");
    delay(2000);
    display.clearDisplay();
   display.setTextSize(2);
   display.setCursor(0,0);
   display.print("Scanning");
   display.setTextSize(2);
   display.setCursor(0,17);
   display.println("Please");
   display.println("Wait...");
   display.setTextSize(1);
   display.println("10%");
   display.display();
    recognizer.say("Checking Red"); 
    RGB_color(255, 0, 0); //Red
    delay(3000);
    display.clearDisplay();
   display.setTextSize(2);
   display.setCursor(0,0);
   display.print("Scanning");
   display.setTextSize(2);
   display.setCursor(0,17);
   display.println("Please");
   display.println("Wait...");
   display.setTextSize(1);
   display.println("20%");
   display.display();
    recognizer.say("Checking Green");
    RGB_color(0, 255, 0); //Green
    delay(3000);
    display.clearDisplay();
   display.setTextSize(2);
   display.setCursor(0,0);
   display.print("Scanning");
   display.setTextSize(2);
   display.setCursor(0,17);
   display.println("Please");
   display.println("Wait...");
   display.setTextSize(1);
   display.println("30%");
   display.display();
    recognizer.say("Checking Blue");
    RGB_color(0, 0, 255); //Blue
    delay(3000);
    recognizer.say("Color Check Completed");
    RGB_color(255, 255, 0); //Yellow
    delay(2000);
    display.clearDisplay();
   display.setTextSize(2);
   display.setCursor(0,0);
   display.print("Scanning");
   display.setTextSize(2);
   display.setCursor(0,17);
   display.println("Please");
   display.println("Wait...");
   display.setTextSize(1);
   display.println("40%");
   display.display();
    recognizer.say("Checking Non-Essential Colors");
    delay(2000);
    display.clearDisplay();
   display.setTextSize(2);
   display.setCursor(0,0);
   display.print("Scanning");
   display.setTextSize(2);
   display.setCursor(0,17);
   display.println("Please");
   display.println("Wait...");
   display.setTextSize(1);
   display.println("50%");
   display.display();
    recognizer.say("Checking White"); 
    RGB_color(255, 255, 255); //White
    delay(3000);
    display.clearDisplay();
   display.setTextSize(2);
   display.setCursor(0,0);
   display.print("Scanning");
   display.setTextSize(2);
   display.setCursor(0,17);
   display.println("Please");
   display.println("Wait...");
   display.setTextSize(1);
   display.println("60%");
   display.display();
    recognizer.say("Checking Purple");
    RGB_color(255, 0, 255); //Purple
    delay(3000);
    display.clearDisplay();
   display.setTextSize(2);
   display.setCursor(0,0);
   display.print("Scanning");
   display.setTextSize(2);
   display.setCursor(0,17);
   display.println("Please");
   display.println("Wait...");
   display.setTextSize(1);
   display.println("70%");
   display.display();
    recognizer.say("Checking Yellow");
    RGB_color(255, 255, 0); //Yellow
    delay(3000);
    display.clearDisplay();
   display.setTextSize(2);
   display.setCursor(0,0);
   display.print("Scanning");
   display.setTextSize(2);
   display.setCursor(0,17);
   display.println("Please");
   display.println("Wait...");
   display.setTextSize(1);
   display.println("80%");
   display.display();
    recognizer.say("Non-Essential Color Check Complete");
    delay(3000);
    display.clearDisplay();
   display.setTextSize(2);
   display.setCursor(0,0);
   display.print("Scanning");
   display.setTextSize(2);
   display.setCursor(0,17);
   display.println("Please");
   display.println("Wait...");
   display.setTextSize(1);
   display.println("90%");
   display.display();
    recognizer.say("Scanning");
    delay(3000);
    recognizer.say("Scan Complete");
    display.clearDisplay();
    display.setTextSize(2);
    display.setCursor(0,0);
    display.print("Scanning");
    display.setCursor(0,17);
    display.print("Complete");
    display.display();
    delay(3000);
  }

UKHeliBob · June 7, 2021, 9:34pm

Please post a complete sketch illustrating your question

Classified123 · June 7, 2021, 9:36pm

This is it. It's just a subroutine for show (Right now).

(Right now, this just let's me know if my RGB led is working properly by running through the colors)

jimLee · June 7, 2021, 9:39pm

You have a bunch of repeated bits.

a
b
c (number1)
d

a
b
c (number2)
d

a
b
c (number3)
d

Break this into a function

dothis(numberX)

a
b
c (numberX)
d

Then your routine no longer grows. Or not by much.

dothis(number1)
dothis(number2)
dothis(number3)
dothis(number4)

-jim lee

Classified123 · June 7, 2021, 9:43pm

Is there an example I can refer to.

I remember seeing something like that where the Number would be x (current number) and it would increase by y (Which would be 1 or something), but I can't remember where I saw it.

jimLee · June 7, 2021, 9:47pm

Umm.. no examples that I think would help. But lets do this..

I'm betting you used copy paste to replicate blocks of code for this didn't you?

-jim lee

Classified123 · June 7, 2021, 9:50pm

Yes. I wanted to keep the "Scanning" "Please Wait..." display the same and have the percentage at the bottom increase, so instead of typing everything out over and over again, I just copied and pasted it and just changed the percent value.

jimLee · June 7, 2021, 9:52pm

Ok that block of code you replicated is your, lets call it... displayFunction()

Lets see one of those blocks here.

void displayFunction() {

// block goes here

}

Classified123 · June 7, 2021, 9:55pm

So it would be this:

void displayFunction() {

   display.clearDisplay();
   display.setTextSize(2);
   display.setCursor(0,0);
   display.print("Scanning");
   display.setTextSize(2);
   display.setCursor(0,17);
   display.println("Please");
   display.println("Wait...");
   display.setTextSize(1);
   display.println("0%");
   display.display();
    recognizer.say("Starting Scan");
    delay(2000);
}

jimLee · June 7, 2021, 9:58pm

Yes! Now what part changes from call to call? The % thing?

void displayFunction(int percent) {

   display.clearDisplay();
   display.setTextSize(2);
   display.setCursor(0,0);
   display.print("Scanning");
   display.setTextSize(2);
   display.setCursor(0,17);
   display.println("Please");
   display.println("Wait...");
   display.setTextSize(1);
   display.print(percent);
   display.println(" %");
   display.display();
    recognizer.say("Starting Scan");
    delay(2000);
}

void SystemCheck() {

   displayFunction(0);
   displayFunction(10);
   displayFunction(20);
   // See the pattern?
}

Classified123 · June 7, 2021, 10:02pm

Ok, I think I got it.

So display.print(precent); will display the displayFunction(10); value/number (10 in this case). Correct?

But I'm a bit confused on how it increases/counts up.

jimLee · June 7, 2021, 10:03pm

In your systemCheck() I call it with 0, 10, 20, etc.

Classified123 · June 7, 2021, 10:07pm

So if I were to do it in my code it would be like this:
Correct?

//Systems Check 
 void SystemCheck()
 {
    displayFunction(); //Would I add this or do I have to put the value in between the 
 //brackets  like displayFunction(0); 
    recognizer.say("Starting Scan");
    delay(2000);
    recognizer.say("Checking Essential Colors");
    delay(2000);
    displayFunction();
    recognizer.say("Checking Red"); 
    RGB_color(255, 0, 0); //Red
    delay(3000);
    //So on and so on
  }

jimLee · June 7, 2021, 10:10pm

think of functions like... Contract workers. I give you this stuff and you do that job. If you want the display stuff you wrote to happen you give it a percent value (its in the contract) and it will work that into the display like you wrote it.

Your code above looks fine, but you forgot to put in the percent values for the display to write out.

Oh yeah, sorry. brackets.

jimLee · June 7, 2021, 10:13pm

See how delay() has brackets with a passed in value? The contract is "HOLD Here for (this many milliseconds)" Just like your new displayFunction(). "Draw this with (this percentage value)"

Classified123 · June 7, 2021, 10:20pm

So would I have 3 separate subroutines like this?

//Systems Check 
 void SystemCheck()
 {
    displayFunction(0);
    recognizer.say("Starting Scan");
    delay(2000);
    recognizer.say("Checking Essential Colors");
    delay(2000);
    displayFunction(10);
    recognizer.say("Checking Red"); 
    RGB_color(255, 0, 0); //Red
    delay(3000);
    //So on and so on
  }

void  displayFunction() {

   displayFunction(0);
   displayFunction(10);
   displayFunction(20);
}

void displayFunction(int percent) {

   display.clearDisplay();
   display.setTextSize(2);
   display.setCursor(0,0);
   display.print("Scanning");
   display.setTextSize(2);
   display.setCursor(0,17);
   display.println("Please");
   display.println("Wait...");
   display.setTextSize(1);
   display.print(percent);
   display.println(" %");
   display.display();
}

jimLee · June 7, 2021, 10:21pm

No, just put the percent values into your systemCheck() one where you want them.

You don't have a function with a list of delay()s do you?

Classified123 · June 7, 2021, 10:23pm

I'm sorry I'm a bit confused. What do you mean?

jimLee · June 7, 2021, 10:25pm

Why did you add the third function?

void  displayFunction() {

   displayFunction(0);
   displayFunction(10);
   displayFunction(20);
}

Classified123 · June 7, 2021, 10:26pm

Because I thought it's supposed to be called upon so the display.print(precent) knows what to write.

Topic		Replies	Views
Help with loop function Programming	26	213	August 8, 2025
Using multiple millis() functions in a row Programming	37	1207	July 18, 2024
Latest updated delay vs timer demo Programming	15	186	December 18, 2025
I do not read analog input with millis function Science and Measurement	34	300	April 27, 2025
Changing this code to work in milliseconds instead of seconds LEDs and Multiplexing	20	192	March 28, 2025

Can this be Simplified?

Related topics