Can't find the cause of this thing

musman12 · April 14, 2022, 1:06pm

So I made a this in TinkerCAD:

The code inside the Adruino Uno:

#include <IRremote.h>
#include <LiquidCrystal.h>

//----Variables-----\\

const int RedPin = 11;
const int GreenPin = 9;
const int BluePin = 10;
const int IRrecvPin = 12;

int ColourRed = 255;
int ColourGreen = 255;
int ColourBlue = 255;

int WhichMode = 0;

boolean LCDPressOn = false;
boolean LEDOn = false;
String CurrentColour[8] = {"w", "r", "g", "b", "o", "y", "a", "p"};
int ColourTracker = 0;

LiquidCrystal lcd(7, 6, 5, 4, 3, 2);     // Initialize the LCD Pins

IRrecv irrecv(IRrecvPin);	//Start the IR
decode_results results;		//Start the IR
unsigned long key_value = 0;

//---Custom-Characters---\\

byte PowerButton[8] = {
  B00000,
  B00100,
  B01110,
  B10101,
  B10001,
  B10001,
  B01110,
  B00000
};

//-----Start-Once-----\\

void setup(){
  Serial.begin(9600);
  
  pinMode(BluePin, OUTPUT);
  pinMode(RedPin, OUTPUT);
  pinMode(GreenPin, OUTPUT);
  
  lcd.begin(16, 2);
  lcd.createChar(2, PowerButton);
  
  irrecv.enableIRIn();
  irrecv.blink13(true);
}

//-------Repeat-------\\

void loop(){ 
  TranslateIR();
  LCD();
}

//---LCD---\\

void LCD() {
  if (LEDOn && LCDPressOn == false && WhichMode == 0){
    lcd.setCursor(0, 0);
  	lcd.print("    LED On      ");
  	lcd.setCursor(0, 1);
    lcd.print("                ");
    delay(1000);
    LCDPressOn = true;
  } else if (LEDOn && LCDPressOn && WhichMode == 0) {
	lcd.setCursor(0, 0);
	lcd.print(" Current Values ");
	lcd.setCursor(0, 1);
	lcd.print("RGB= ");
	lcd.print(ColourRed);
	lcd.print(",");
	lcd.print(ColourGreen);
	lcd.print(",");
	lcd.print(ColourBlue);
    delay(1000);
  } else if (LEDOn == false && WhichMode == 0) {
    lcd.setCursor(0, 0);
  	lcd.print("    LED Off     ");
  	lcd.setCursor(0, 1);
    lcd.print("    Press ");
    lcd.setCursor(10, 1);
    lcd.write(2);
    lcd.setCursor(11, 1);
    lcd.print("   ");
    delay(1000);
  } else if (LEDOn && WhichMode == 1) { // Red
    lcd.setCursor(0, 0);
    lcd.print("(-/+)        Red");
    lcd.setCursor(0, 1);
    lcd.print("Value = ");
    lcd.print(ColourRed);
    delay(1000);
  } else if (LEDOn && WhichMode == 2) { // Green
    lcd.setCursor(0, 0);
    lcd.print("(-/+)      Green");
    lcd.setCursor(0, 1);
    lcd.print("Value = ");
    lcd.print(ColourGreen);
    delay(1000);
  } else if (LEDOn && WhichMode == 3) { // Blue
    lcd.setCursor(0, 0);
    lcd.print("(-/+)       Blue");
    lcd.setCursor(0, 1);
    lcd.print("Value = ");
    lcd.print(ColourBlue);
    delay(1000);
  } else if (LEDOn && WhichMode == 4) { // Default
    WhichMode = 0;
    LCDPressOn = true;
  }
}

//---Change-Values-RGB---\\

void ChangeValueN() {
  if (LEDOn) {
    if (WhichMode == 1) {
      ColourRed = ColourRed - 10;
      if (ColourRed < 0) ColourRed = 0;
      analogWrite(RedPin, ColourRed);
      analogWrite(GreenPin, ColourGreen);
      analogWrite(BluePin, ColourBlue);
    } else if (WhichMode == 2) {
      ColourGreen = ColourGreen - 10;
      if (ColourGreen < 0) ColourGreen = 0;
      analogWrite(RedPin, ColourRed);
      analogWrite(GreenPin, ColourGreen);
      analogWrite(BluePin, ColourBlue);
    } else if (WhichMode == 3) {
      ColourBlue = ColourBlue - 10;
      if (ColourBlue < 0) ColourBlue = 0;
      analogWrite(RedPin, ColourRed);
      analogWrite(GreenPin, ColourGreen);
      analogWrite(BluePin, ColourBlue);
    }
  }
}

void ChangeValueP() {
  if (LEDOn) {
    if (WhichMode == 1) {
      ColourRed = ColourRed + 10;
      if (ColourRed > 255) ColourRed = 255;
      analogWrite(RedPin, ColourRed);
      analogWrite(GreenPin, ColourGreen);
      analogWrite(BluePin, ColourBlue);
    } else if (WhichMode == 2) {
      ColourGreen = ColourGreen + 10;
      if (ColourGreen > 255) ColourGreen = 255;
      analogWrite(RedPin, ColourRed);
      analogWrite(GreenPin, ColourGreen);
      analogWrite(BluePin, ColourBlue);
    } else if (WhichMode == 3) {
      ColourBlue = ColourBlue + 10;
      if (ColourBlue > 255) ColourBlue = 255;
      analogWrite(RedPin, ColourRed);
      analogWrite(GreenPin, ColourGreen);
      analogWrite(BluePin, ColourBlue);
    }
  }
}

//-----Set-LED-----\\

void SetLED() {
  if (CurrentColour[ColourTracker].equals("w")) {
    ColourRed = 255;
	ColourGreen = 255;
	ColourBlue = 255;
    
    if (LEDOn) {
      analogWrite(RedPin, ColourRed);
      analogWrite(GreenPin, ColourGreen);
      analogWrite(BluePin, ColourBlue);
    }
  } else if (CurrentColour[ColourTracker].equals("r")) {
    ColourRed = 255;
	ColourGreen = 0;
	ColourBlue = 0;
    
    if (LEDOn) {
      analogWrite(RedPin, ColourRed);
      analogWrite(GreenPin, ColourGreen);
      analogWrite(BluePin, ColourBlue);
    }
  } else if (CurrentColour[ColourTracker].equals("g")) {
    ColourRed = 0;
	ColourGreen = 255;
	ColourBlue = 0;
    
    if (LEDOn) {
      analogWrite(RedPin, ColourRed);
      analogWrite(GreenPin, ColourGreen);
      analogWrite(BluePin, ColourBlue);
    }
  } else if (CurrentColour[ColourTracker].equals("b")) {
    ColourRed = 0;
	ColourGreen = 0;
	ColourBlue = 255;
    
    if (LEDOn) {
      analogWrite(RedPin, ColourRed);
      analogWrite(GreenPin, ColourGreen);
      analogWrite(BluePin, ColourBlue);
    }
  } else if (CurrentColour[ColourTracker].equals("o")) {
    ColourRed = 255;
	ColourGreen = 69;
	ColourBlue = 0;
    
    if (LEDOn) {
      analogWrite(RedPin, ColourRed);
      analogWrite(GreenPin, ColourGreen);
      analogWrite(BluePin, ColourBlue);
    }
  } else if (CurrentColour[ColourTracker].equals("y")) {
    ColourRed = 255;
	ColourGreen = 255;
	ColourBlue = 0;
    
    if (LEDOn) {
      analogWrite(RedPin, ColourRed);
      analogWrite(GreenPin, ColourGreen);
      analogWrite(BluePin, ColourBlue);
    }
  } else if (CurrentColour[ColourTracker].equals("a")) {
    ColourRed = 0;
	ColourGreen = 255;
	ColourBlue = 255;
    
    if (LEDOn) {
      analogWrite(RedPin, ColourRed);
      analogWrite(GreenPin, ColourGreen);
      analogWrite(BluePin, ColourBlue);
    }
  } else if (CurrentColour[ColourTracker].equals("p")) {
    ColourRed = 255;
	ColourGreen = 0;
	ColourBlue = 255;
    
    if (LEDOn) {
      analogWrite(RedPin, ColourRed);
      analogWrite(GreenPin, ColourGreen);
      analogWrite(BluePin, ColourBlue);
    }
  }
}

//-----Toggle-LED-----\\

void ToggleLED() {
  if (LEDOn) {
    Serial.println("LED turned off");
    analogWrite(RedPin, 0);
    analogWrite(GreenPin, 0);
    analogWrite(BluePin, 0);
    LEDOn = false;
    delay(200);
  } else {
    Serial.println("LED turned on");
    analogWrite(RedPin, ColourRed);
    analogWrite(GreenPin, ColourGreen);
    analogWrite(BluePin, ColourBlue);
    LEDOn = true;
    delay(200);
  }
}

//----Cycle----\\

void Cycle() {
  if (LEDOn) {
    ColourTracker++;
    if (ColourTracker > 7 || ColourTracker < 0) {
      ColourTracker = 0;
    }
  }
}

//---Cycle-Modes---\\

void CycleMode() {
  if (LEDOn){
    WhichMode++;
    if (WhichMode > 4 || WhichMode < 0) {
      WhichMode = 0;
    }
  }
}

//-----Translate-IR----\\

void TranslateIR() {
  if (irrecv.decode(&results)){
    if (results.value == 0XFFFFFFFF) results.value = key_value;
    switch(results.value) {
    	case 0xFD00FF:
      		Serial.println("POWER");
      		lcd.clear();
      		ToggleLED();
      		delay(500);
      		break;
      
      	case 0xFD40BF:
          	Serial.println("FUNC/STOP");
      		lcd.clear();
      		Cycle();
      		SetLED();
      		delay(500);
      		break;
      
      	case 0xFDA05F:
      		Serial.println(">||");
      		lcd.clear();
      		CycleMode();
      		delay(500);
      		break;
      
      	case 0xFD20DF:
      		Serial.println("|<<");
      		lcd.clear();
      		ChangeValueN();
      		delay(100);
      		break;
      
      	case 0xFD609F:
      		Serial.println(">>|");
      		lcd.clear();
      		ChangeValueP();
      		delay(100);
      		break;
    }
    Serial.println(results.value);
    key_value = results.value;
    irrecv.resume();
  }
}

So my problem is that when I cycle through the modes (by pressing pause button) and decrease or increase the values of the colours (by pressing |<< or >>| buttons), only the blue and green work, but the red doesn't and I can't figure the problem out.

Edit: When I press |<< then the code for all buttons change randomly. But only when the mode is on the red and then I press |<<.

StefanL38 · April 14, 2022, 2:24pm

add serial-output that shows the values of each variable in every iteration

here is your code more formatted
Did you really want a part of the lines to be outside the innermost if-conditions

#include <IRremote.h>
#include <LiquidCrystal.h>

//----Variables-----\\

const int RedPin    = 11;
const int GreenPin  = 9;
const int BluePin   = 10;
const int IRrecvPin = 12;

int ColourRed   = 255;
int ColourGreen = 255;
int ColourBlue  = 255;

int WhichMode = 0;

boolean LCDPressOn = false;
boolean LEDOn = false;
String CurrentColour[8] = {"w", "r", "g", "b", "o", "y", "a", "p"};
int ColourTracker = 0;

LiquidCrystal lcd(7, 6, 5, 4, 3, 2);     // Initialize the LCD Pins

IRrecv irrecv(IRrecvPin);  //Start the IR
decode_results results;   //Start the IR
unsigned long key_value = 0;

//---Custom-Characters---\\

byte PowerButton[8] = {
  B00000,
  B00100,
  B01110,
  B10101,
  B10001,
  B10001,
  B01110,
  B00000
};

//-----Start-Once-----\\

void setup() {
  Serial.begin(9600);

  pinMode(BluePin, OUTPUT);
  pinMode(RedPin, OUTPUT);
  pinMode(GreenPin, OUTPUT);

  lcd.begin(16, 2);
  lcd.createChar(2, PowerButton);

  irrecv.enableIRIn();
  irrecv.blink13(true);
}

//-------Repeat-------\\

void loop() {
  TranslateIR();
  LCD();
}

//---LCD---\\

void LCD() {
  if (LEDOn && LCDPressOn == false && WhichMode == 0) {
    lcd.setCursor(0, 0);
    lcd.print("    LED On      ");
    lcd.setCursor(0, 1);
    lcd.print("                ");
    delay(1000);
    LCDPressOn = true;
  } 
  
  else if (LEDOn && LCDPressOn && WhichMode == 0) {
    lcd.setCursor(0, 0);
    lcd.print(" Current Values ");
    lcd.setCursor(0, 1);
    lcd.print("RGB= ");
    lcd.print(ColourRed);
    lcd.print(",");
    lcd.print(ColourGreen);
    lcd.print(",");
    lcd.print(ColourBlue);
    delay(1000);
  } 
  
  else if (LEDOn == false && WhichMode == 0) {
    lcd.setCursor(0, 0);
    lcd.print("    LED Off     ");
    lcd.setCursor(0, 1);
    lcd.print("    Press ");
    lcd.setCursor(10, 1);
    lcd.write(2);
    lcd.setCursor(11, 1);
    lcd.print("   ");
    delay(1000);
  } 
  
  else if (LEDOn && WhichMode == 1) { // Red
    lcd.setCursor(0, 0);
    lcd.print("(-/+)        Red");
    lcd.setCursor(0, 1);
    lcd.print("Value = ");
    lcd.print(ColourRed);
    delay(1000);
  } 
  
  else if (LEDOn && WhichMode == 2) { // Green
    lcd.setCursor(0, 0);
    lcd.print("(-/+)      Green");
    lcd.setCursor(0, 1);
    lcd.print("Value = ");
    lcd.print(ColourGreen);
    delay(1000);
  } 
  
  else if (LEDOn && WhichMode == 3) { // Blue
    lcd.setCursor(0, 0);
    lcd.print("(-/+)       Blue");
    lcd.setCursor(0, 1);
    lcd.print("Value = ");
    lcd.print(ColourBlue);
    delay(1000);
  } 
  
  else if (LEDOn && WhichMode == 4) { // Default
    WhichMode = 0;
    LCDPressOn = true;
  }
}

//---Change-Values-RGB---\\

void ChangeValueN() {
  if (LEDOn) {
    if (WhichMode == 1) {
      ColourRed = ColourRed - 10;
      if (ColourRed < 0) {
        ColourRed = 0;
      }
      analogWrite(RedPin, ColourRed);
      analogWrite(GreenPin, ColourGreen);
      analogWrite(BluePin, ColourBlue);
    } 
    
    else if (WhichMode == 2) {
      ColourGreen = ColourGreen - 10;
      if (ColourGreen < 0) {
        ColourGreen = 0;
      }
      analogWrite(RedPin, ColourRed);
      analogWrite(GreenPin, ColourGreen);
      analogWrite(BluePin, ColourBlue);
    } 
    
    else if (WhichMode == 3) {
      ColourBlue = ColourBlue - 10;
      if (ColourBlue < 0) { 
        ColourBlue = 0;
      }
      analogWrite(RedPin, ColourRed);
      analogWrite(GreenPin, ColourGreen);
      analogWrite(BluePin, ColourBlue);
    }
  }
}

void ChangeValueP() {
  if (LEDOn) {
    if (WhichMode == 1) {
      ColourRed = ColourRed + 10;
      if (ColourRed > 255) {
        ColourRed = 255;
      }
      analogWrite(RedPin, ColourRed);
      analogWrite(GreenPin, ColourGreen);
      analogWrite(BluePin, ColourBlue);
    } 
    
    else if (WhichMode == 2) {
      ColourGreen = ColourGreen + 10;
      if (ColourGreen > 255) { 
        ColourGreen = 255;
      }
      analogWrite(RedPin, ColourRed);
      analogWrite(GreenPin, ColourGreen);
      analogWrite(BluePin, ColourBlue);
    } 
    
    else if (WhichMode == 3) {
      ColourBlue = ColourBlue + 10;
      if (ColourBlue > 255) {
        ColourBlue = 255;
      }
      analogWrite(RedPin, ColourRed);
      analogWrite(GreenPin, ColourGreen);
      analogWrite(BluePin, ColourBlue);
    }
  }
}

//-----Set-LED-----\\

void SetLED() {
  if (CurrentColour[ColourTracker].equals("w")) {
    ColourRed = 255;
    ColourGreen = 255;
    ColourBlue = 255;

    if (LEDOn) {
      analogWrite(RedPin, ColourRed);
      analogWrite(GreenPin, ColourGreen);
      analogWrite(BluePin, ColourBlue);
    }
  } 
  
  else if (CurrentColour[ColourTracker].equals("r")) {
    ColourRed = 255;
    ColourGreen = 0;
    ColourBlue = 0;

    if (LEDOn) {
      analogWrite(RedPin, ColourRed);
      analogWrite(GreenPin, ColourGreen);
      analogWrite(BluePin, ColourBlue);
    }
  } 
  
  else if (CurrentColour[ColourTracker].equals("g")) {
    ColourRed = 0;
    ColourGreen = 255;
    ColourBlue = 0;

    if (LEDOn) {
      analogWrite(RedPin, ColourRed);
      analogWrite(GreenPin, ColourGreen);
      analogWrite(BluePin, ColourBlue);
    }
  } 
  
  else if (CurrentColour[ColourTracker].equals("b")) {
    ColourRed = 0;
    ColourGreen = 0;
    ColourBlue = 255;

    if (LEDOn) {
      analogWrite(RedPin, ColourRed);
      analogWrite(GreenPin, ColourGreen);
      analogWrite(BluePin, ColourBlue);
    }
  } 
  
  else if (CurrentColour[ColourTracker].equals("o")) {
    ColourRed = 255;
    ColourGreen = 69;
    ColourBlue = 0;

    if (LEDOn) {
      analogWrite(RedPin, ColourRed);
      analogWrite(GreenPin, ColourGreen);
      analogWrite(BluePin, ColourBlue);
    }
  } 
  
  else if (CurrentColour[ColourTracker].equals("y")) {
    ColourRed = 255;
    ColourGreen = 255;
    ColourBlue = 0;

    if (LEDOn) {
      analogWrite(RedPin, ColourRed);
      analogWrite(GreenPin, ColourGreen);
      analogWrite(BluePin, ColourBlue);
    }
  } 
  
  else if (CurrentColour[ColourTracker].equals("a")) {
    ColourRed = 0;
    ColourGreen = 255;
    ColourBlue = 255;

    if (LEDOn) {
      analogWrite(RedPin, ColourRed);
      analogWrite(GreenPin, ColourGreen);
      analogWrite(BluePin, ColourBlue);
    }
  } 
  
  else if (CurrentColour[ColourTracker].equals("p")) {
    ColourRed = 255;
    ColourGreen = 0;
    ColourBlue = 255;

    if (LEDOn) {
      analogWrite(RedPin, ColourRed);
      analogWrite(GreenPin, ColourGreen);
      analogWrite(BluePin, ColourBlue);
    }
  }
}

//-----Toggle-LED-----\\

void ToggleLED() {
  if (LEDOn) {
    Serial.println("LED turned off");
    analogWrite(RedPin, 0);
    analogWrite(GreenPin, 0);
    analogWrite(BluePin, 0);
    LEDOn = false;
    delay(200);
  } 
  
  else {
    Serial.println("LED turned on");
    analogWrite(RedPin, ColourRed);
    analogWrite(GreenPin, ColourGreen);
    analogWrite(BluePin, ColourBlue);
    LEDOn = true;
    delay(200);
  }
}

//----Cycle----\\

void Cycle() {
  if (LEDOn) {
    ColourTracker++;
    if (ColourTracker > 7 || ColourTracker < 0) {
      ColourTracker = 0;
    }
  }
}

//---Cycle-Modes---\\

void CycleMode() {
  if (LEDOn) {
    WhichMode++;
    if (WhichMode > 4 || WhichMode < 0) {
      WhichMode = 0;
    }
  }
}

//-----Translate-IR----\\

void TranslateIR() {
  if (irrecv.decode(&results)) {
    if (results.value == 0XFFFFFFFF) results.value = key_value;
    switch (results.value) {
      case 0xFD00FF:
        Serial.println("POWER");
        lcd.clear();
        ToggleLED();
        delay(500);
        break;

      case 0xFD40BF:
        Serial.println("FUNC/STOP");
        lcd.clear();
        Cycle();
        SetLED();
        delay(500);
        break;

      case 0xFDA05F:
        Serial.println(">||");
        lcd.clear();
        CycleMode();
        delay(500);
        break;

      case 0xFD20DF:
        Serial.println("|<<");
        lcd.clear();
        ChangeValueN();
        delay(100);
        break;

      case 0xFD609F:
        Serial.println(">>|");
        lcd.clear();
        ChangeValueP();
        delay(100);
        break;
    }
    Serial.println(results.value);
    key_value = results.value;
    irrecv.resume();
  }
}

musman12 · April 14, 2022, 2:27pm

what do you mean by outside the innermost if-conditions. I am new to C++ and very bad at english.

gcjr · April 14, 2022, 3:59pm

what prevents TranslateIR() calling the function multiple times? is there a mechanism to recognize that a code has been received and won't be processes again until no code is received? not sur ehow the IR decoder works

in CycleMode(), shouldn't WhichMode be set to 1 when incremented > 3, not 4?

musman12 · April 14, 2022, 4:05pm

No, it should be set to 0 so it will change the menu to the default and if it turn to 1 then it change to the red menu

JohnRob · April 14, 2022, 4:58pm

Each "if" statement contains code that is inside brackets. i.e. { code }

so outside the if statement means the adding code that is before the { or after the }

musman12 · April 15, 2022, 3:08pm

That's not the problem. its nothing to do with the if statement. The problem is that when the mode is on red and I decrease the value of red all the codes for the buttons in the IR Remote change to something else.

StefanL38 · April 15, 2022, 5:57pm

It is likely that you didn't set curly braces around a part of the if-conditions
This means a part of the commands is executed unconditional

system · October 12, 2022, 5:58pm

This topic was automatically closed 180 days after the last reply. New replies are no longer allowed.

Topic		Replies	Views
help with arduno uno R3 ID:1.7.9 & 2004A 4 x 20 IC2 lcd Displays	9	1574	May 6, 2021
Trying to create a smart bike lock whats wrong with my code/circuit Programming Questions	3	34	November 19, 2024
Problem with infrared remote control and lcd "invalid header file" Programming Questions	4	468	June 11, 2024
Weird Bugs using 20x4 LCD with Arduino Uno Displays	6	2235	May 6, 2021
LCD I2C showing gibberish while connected to arduino uno Programming Questions	4	614	January 30, 2023

Can't find the cause of this thing

Related topics