ClickButton Lib on the DUE

Official Hardware Mega Due
1

Hi !

I tried the ClickButton Lib (Google Code Archive - Long-term storage for Google Code Project Hosting.) on the DUE. But it won´t work for me. The same code on the Arduino MEGA runs just fine.

So did anyone know a DUE fix for this Lib? Or can anyone give some advice how to enhance the lib to get it working on the DUE?

Regards
Dominik

2

Change:

  pinMode(_pin, INPUT);
  // Turn on internal pullup resistor if applicable
  if (_activeHigh == LOW && internalPullup == CLICKBTN_PULLUP) digitalWrite(_pin,HIGH);

to

  pinMode(_pin, activeHigh == LOW && internalPullup == CLICKBTN_PULLUP? 
          INPUT_PULLUP : INPUT) ;

It was using a trick specific to the AVR architecture for pull-ups.

I think you should probably to change the timestamp variables from "long" to "unsigned int"
and any other longs to ints for Due.
Time values should have been "unsigned long" in the first place, but I can't see anything
else obviously a problem.

A good way to deal with types is use explicitly sized types: change long to int32_t and
unsigned long to uint32_t. Things that are already just int can stay int, usually.

3

Hi Mark,

things getting strange :slight_smile:

Ok first I did a test with a very simple sketch:

int reader = 0;

void setup() {
  Serial.begin(115200);
  Serial.println("Start ...");
  pinMode(48, INPUT);
  digitalWrite(48, HIGH);       // turn on pullup resistors
}

// the loop function runs over and over again forever
void loop() {
  reader = digitalRead(48);  
  Serial.println(reader);
  delay(250);            
}

This works ok. If I press the button I get 0 otherwise I get 1. So generally this should work.

Now I changed the code in the clickbutton constructor:

 pinMode(_pin, INPUT);
 if (_activeHigh == LOW && internalPullup == CLICKBTN_PULLUP) digitalWrite(_pin,HIGH);

to

  pinMode(_pin, INPUT);
  digitalWrite(_pin,HIGH);

If I run this the code did not work.

Now I connected a second button an a different pin but with an external pullup resistor (12k).
I used the second constructor for the init:

ClickButton::ClickButton(uint8_t buttonPin, boolean activeType)

This works fine. :astonished:

Now I´m a little bit confused ... :slight_smile:

4

The Due doesn't do pullups like AVR, you have to use pinMode (pin, INPUT_PULLUP)

[ perhaps you should actually try the fix I posted... ]

5

Hi !

Now I tried all version in the third constructor of ClickButton.

  • pinMode (pin, INPUT)
  • pinMode (pin, INPUT_PULLUP)
  • pinMode (pin, INPUT); digitalWrite(_pin,HIGH);
  • pinMode (pin, INPUT_PULLUP); digitalWrite(_pin,HIGH);
  • your suggestion from the second post

Nothing works for me.

The only solution that works well is an external Pullup and using of constructor 2 (ClickButton::ClickButton(uint8_t buttonPin, boolean activeType)).

But the strange thing is ... This code works great (now with INPUT_PULLUP):

int reader = 0;

void setup() {
  Serial.begin(115200);
  pinMode(46, INPUT_PULLUP);
}

// the loop function runs over and over again forever
void loop() {
  reader = digitalRead(46);  
  Serial.println(reader);
  delay(250);            
}

I´ve attached my test sketch. Maybe there is a mistake?

ButtonDirekt.ino (2.35 KB)

6

One thing that may confound the issue is that the internal pullups on the Due are
very weak - like 50k or more, IIRC. Touching the wiring might affect things.
For long cable runs add a 4k7 external pullup anyway.

Actually I looked at the code for digitalWrite on the Due - they've faked it up
to behave like the Atmel chips and turn on pull-ups if the pin is currently an
INPUT...

Anyway the pinMode (..., INPUT_PULLUP) is the clean way to do these
things now, it documents intent in the setup() function nicely.