Code checking before programming

lastchancename:
Overall, you could drastically shorten & simplify your code with arrays.
Also remember LEDs are not linear, you may want a table in PROGMEM to map your brightness value to PWM value.

larryd:
unsigned char encoder_A1;
Could be
byte encoder_A1;

const int pin_A1 = 2;//A pin red encoder
Could be
const byte pin_A1 = 2;//A pin red encoder

int brightnessRed = 120; //Starting at half the value of full brightness
Could be
byte brightnessRed = 120; //Starting at half the value of full brightness

Depending on the wiring, you may be able to turn on pull-ups.

You will of course need a loop() function.

You need to get the better half buy your child a soldering iron, DVM, hand tools, drill etc.

Both are excellent suggestions. As I don't know how to write arrays I'm probably going to leave that one alone. For simplicity purposes anyway. I will have to research the PROGMEM commands as that is above my head right now, but certainly worth looking into.

I do have a build station with soldering iron and all, but my daughter is 4, so she wont be handling any of that. Just figured I would build her a toy that can teach colors.

I'll be putting together the loop function tonight but needed to make sure what I have so far is a solid foundation (for a beginner anyway)

I appreciate the help