so I attempted to fix all the problems you mentioned but I'm having trouble I keep getting the error
expected primary-expression before 'client'
when I try to compile it says the error is where I'm trying to call the analog command(BridgeClient client); function that I set up I'm not sure if there is something I'm missing or if I need to put the function before the Dc1 function
#include <Bridge.h>
#include <BridgeServer.h>
#include <BridgeClient.h>
BridgeServer server;//set up a bridge server
//LED Pin vairiables (they will stay constant)
const int Led1 = 11;
const int Led2 = 9;
const int Led3 = 6;
const int Led4 = 3;
const int P = 50; //perioud of the cycle it can't go below 50
//Vairiables that will change
unsigned long DC1 = 0;
unsigned long DC2 = 0;
unsigned long DC3 = 0;
unsigned long DC4 = 0;
//on LED signals
unsigned long ONLed1 = (P * DC1);
unsigned long ONLed2 = (P * DC2);
unsigned long ONLed3 = (P * DC3);
unsigned long ONLed4 = (P * DC4);
//LED off signals
unsigned long OFFLed1 = (P * (1 - DC1));
unsigned long OFFLed2 = (P * (1 - DC2));
unsigned long OFFLed3 = (P * (1 - DC3));
unsigned long OFFLed4 = (P * (1 - DC4));
byte totalmillies = 0;// the total number of miliseconds on the loop
//checking if the LEDS are on or off
byte Led1State = LOW;
byte Led2State = LOW;
byte Led3State = LOW;
byte Led4State = LOW;
void setup() {
Bridge.begin();
Console.begin();
Console.println ("through vairiables");
//set up server
server.listenOnLocalhost();
server.begin();
//setting Leds as outputs
pinMode(Led1, OUTPUT);
pinMode(Led2, OUTPUT);
pinMode(Led3, OUTPUT);
pinMode(Led4, OUTPUT);
}
void loop() {
totalmillies = millis();
updateLed1State();
updateLed2State();
updateLed3State();
updateLed4State();
SwitchLeds();
BridgeClient client = server.accept();
analogCommand(BridgeClient client);
}
void updateDC1() {
analogCommand(BridgeClient client);
if (pin = 11) {
DC1 == (value / 255);
}
}
void process(BridgeClient client) {
String command = client.readStringUntil('/');
if (client) {
process(client);
Console.println("client connected and will now close");
client.stop();
}
if (command == "analog") {
analogCommand(client);
}
}
float analogCommand(BridgeClient client) {
int pin, value;
pin = client.parseInt();
if (client.read() == '/') {
value = client.parseInt();
return value;
return pin;
}
}
void updateLed1State() {
if (Led1State == LOW) {
if (totalmillies - OFFLed1 >= ONLed1) {
Led1State = HIGH;
}
}
else {
if (totalmillies - ONLed1 >= ONLed1 + OFFLed1)
{
Led1State = LOW;
}
}
}
void updateLed2State() {
if (Led2State == LOW) {
if (totalmillies - OFFLed2 >= ONLed2) {
Led2State = HIGH;
}
}
else {
if (totalmillies - ONLed2 >= ONLed2 + OFFLed2)
{
Led1State = LOW;
}
}
}
void updateLed3State() {
if (Led3State == LOW) {
if (totalmillies - OFFLed3 >= ONLed3) {
Led3State = HIGH;
}
}
else {
if (totalmillies - ONLed3 >= ONLed3 + OFFLed3)
{
Led3State = LOW;
}
}
}
void updateLed4State() {
if (Led4State == LOW) {
if (totalmillies - OFFLed4 >= ONLed4) {
Led4State = HIGH;
}
}
else {
if (totalmillies - ONLed4 >= ONLed4 + OFFLed4)
{
Led4State = LOW;
}
}
}void SwitchLeds() {
digitalWrite(Led1, Led1State);
digitalWrite(Led2, Led2State);
digitalWrite(Led3, Led3State);
digitalWrite(Led4, Led4State);
}