Code gets stuck on the last note of the melody after being played

Using Arduino Programming Questions
1

Hey, so the program I made is supposed to be a sort of tea machine, that automatically puts a teabag inside a mug. I decided to make a melody that plays after the process is done, and then the program runs back to the start after all of the components inside the void loop is done. The problem is that once the melody finishes playing, it gets stuck on the last note forever (which in this case is the REST). I honestly have no clue what to do.
The code for the pitches:

/*************************************************
* Public Constants
*************************************************/

#define NOTE_B0 31
#define NOTE_C1 33
#define NOTE_CS1 35
#define NOTE_D1 37
#define NOTE_DS1 39
#define NOTE_E1 41
#define NOTE_F1 44
#define NOTE_FS1 46
#define NOTE_G1 49
#define NOTE_GS1 52
#define NOTE_A1 55
#define NOTE_AS1 58
#define NOTE_B1 62
#define NOTE_C2 65
#define NOTE_CS2 69
#define NOTE_D2 73
#define NOTE_DS2 78
#define NOTE_E2 82
#define NOTE_F2 87
#define NOTE_FS2 93
#define NOTE_G2 98
#define NOTE_GS2 104
#define NOTE_A2 110
#define NOTE_AS2 117
#define NOTE_B2 123
#define NOTE_C3 131
#define NOTE_CS3 139
#define NOTE_D3 147
#define NOTE_DS3 156
#define NOTE_E3 165
#define NOTE_F3 175
#define NOTE_FS3 185
#define NOTE_G3 196
#define NOTE_GS3 208
#define NOTE_A3 220
#define NOTE_AS3 233
#define NOTE_B3 247
#define NOTE_C4 262
#define NOTE_CS4 277
#define NOTE_D4 294
#define NOTE_DS4 311
#define NOTE_E4 330
#define NOTE_F4 349
#define NOTE_FS4 370
#define NOTE_G4 392
#define NOTE_GS4 415
#define NOTE_A4 440
#define NOTE_AS4 466
#define NOTE_B4 494
#define NOTE_C5 523
#define NOTE_CS5 554
#define NOTE_D5 587
#define NOTE_DS5 622
#define NOTE_E5 659
#define NOTE_F5 698
#define NOTE_FS5 740
#define NOTE_G5 784
#define NOTE_GS5 831
#define NOTE_A5 880
#define NOTE_AS5 932
#define NOTE_B5 988
#define NOTE_C6 1047
#define NOTE_CS6 1109
#define NOTE_D6 1175
#define NOTE_DS6 1245
#define NOTE_E6 1319
#define NOTE_F6 1397
#define NOTE_FS6 1480
#define NOTE_G6 1568
#define NOTE_GS6 1661
#define NOTE_A6 1760
#define NOTE_AS6 1865
#define NOTE_B6 1976
#define NOTE_C7 2093
#define NOTE_CS7 2217
#define NOTE_D7 2349
#define NOTE_DS7 2489
#define NOTE_E7 2637
#define NOTE_F7 2794
#define NOTE_FS7 2960
#define NOTE_G7 3136
#define NOTE_GS7 3322
#define NOTE_A7 3520
#define NOTE_AS7 3729
#define NOTE_B7 3951
#define NOTE_C8 4186
#define NOTE_CS8 4435
#define NOTE_D8 4699
#define NOTE_DS8 4978
#define REST 0

// The actual program:
#include <Servo.h> // Adds the library for the Servo to operate.
#include "pitches.h" // Adds the tab I've created for certain pitches and notes for the buzzer to play when called.
Servo servoOne; // All of these variables are for the usage of the tea brewing program.
Servo servoTwo;
int sensorValue = 0;
int minuteTimer = 0;
int counter = 0;
int welcome = 0;
int i = 0;
int buttonStateOne = 1;
int a = 2; // a-g are the variables for the 7 segment.
int b = 3;
int c = 4;
int d = 5;
int e = 6;
int f = 7;
int g = 8;
int buttonOne = 13; 
int led = 11;
int buzzer = 12; // Buzzer not attached to pin 11 due to the tone and analogWrite() both having the same built in timer in both pins 3 and 11. Can create weird sound if put on either pins.
int melody[] = {
  NOTE_D4, NOTE_E4, NOTE_FS4, NOTE_G4, NOTE_A4, NOTE_D4, NOTE_B4, NOTE_D5, NOTE_A4, NOTE_FS4, NOTE_G4, NOTE_FS4, NOTE_G4, NOTE_A4, NOTE_FS4, NOTE_E4, NOTE_D4, NOTE_A3, NOTE_E4, NOTE_D4, NOTE_E4, NOTE_FS4, NOTE_E4, NOTE_A3, 
  NOTE_D4, NOTE_E4, NOTE_FS4, NOTE_G4, NOTE_A4, NOTE_D4, NOTE_B4, NOTE_D5, NOTE_A4, NOTE_FS4, NOTE_G4, NOTE_FS4, NOTE_G4, NOTE_A4, NOTE_FS4, NOTE_E4, NOTE_D4, NOTE_A3, NOTE_E4, NOTE_D4, NOTE_E4, NOTE_FS4, NOTE_E4, NOTE_A3,
  NOTE_B3, NOTE_A3, NOTE_B3, NOTE_CS4, NOTE_D4, NOTE_A3, NOTE_FS4, NOTE_FS4, NOTE_G4, NOTE_FS4, NOTE_G4, NOTE_E4, NOTE_E4, NOTE_D4, NOTE_E4, NOTE_D4, REST
};
int durations[] = {
  6, 14, 6, 14, 4, 4, 4, 4, 4, 4, 6, 14, 6, 14, 6, 14, 6, 14, 6, 14, 6, 14, 4, 4, 6, 14, 6, 14, 4, 4, 4, 4, 4, 4, 6, 14, 6, 14, 6, 14, 6, 14, 6, 14, 6, 14, 4, 4, 
  6, 14, 6, 14, 4, 6, 14, 24, 24, 24, 24, 14, 6, 14, 2, 4
};
int songLength = sizeof(melody)/sizeof(melody[0]);

void setup() // Sets up each pin, the serial monitor, and the servos for usage.
{
  pinMode(A0, INPUT);
  pinMode(buttonOne,INPUT_PULLUP);
  Serial.begin(9600);
  servoOne.attach(9);
  servoTwo.attach(10);
  pinMode(led, OUTPUT);
  pinMode(a,OUTPUT);
  pinMode(b,OUTPUT);
  pinMode(c,OUTPUT);
  pinMode(d,OUTPUT);
  pinMode(e,OUTPUT);
  pinMode(f,OUTPUT);
  pinMode(g,OUTPUT);
}

void clearAll() // Resets the 7 segment.
{
  digitalWrite(a,LOW);
  digitalWrite(b,LOW);
  digitalWrite(c,LOW);
  digitalWrite(d,LOW);
  digitalWrite(e,LOW);
  digitalWrite(f,LOW);
  digitalWrite(g,LOW);
}

void digitOne() // Creates the number 1 on the 7 segment.
{
  clearAll();
  digitalWrite(a,LOW);
  digitalWrite(b,HIGH);
  digitalWrite(c,HIGH);
  digitalWrite(d,LOW);
  digitalWrite(e,LOW);
  digitalWrite(f,LOW);
  digitalWrite(g,LOW);
}

void digitTwo() // Creates the number 2 on the 7 segment.
{
  clearAll();
  digitalWrite(a,HIGH);
  digitalWrite(b,HIGH);
  digitalWrite(c,LOW);
  digitalWrite(d,HIGH);
  digitalWrite(e,HIGH);
  digitalWrite(f,LOW);
  digitalWrite(g,HIGH);
}

void digitThree() // Creates the number 3 on the 7 segment.
{
  clearAll();
  digitalWrite(a,HIGH);
  digitalWrite(b,HIGH);
  digitalWrite(c,HIGH);
  digitalWrite(d,HIGH);
  digitalWrite(e,LOW);
  digitalWrite(f,LOW);
  digitalWrite(g,HIGH);
}

void digitFour() // Creates the number 4 on the 7 segment.
{
  clearAll();
  digitalWrite(a,LOW);
  digitalWrite(b,HIGH);
  digitalWrite(c,HIGH);
  digitalWrite(d,LOW);
  digitalWrite(e,LOW);
  digitalWrite(f,HIGH);
  digitalWrite(g,HIGH);
}

void digitFive() // Creates the number 5 on the 7 segment.
{
  clearAll();
  digitalWrite(a,HIGH);
  digitalWrite(b,LOW);
  digitalWrite(c,HIGH);
  digitalWrite(d,HIGH);
  digitalWrite(e,LOW);
  digitalWrite(f,HIGH);
  digitalWrite(g,HIGH);
}

void ledBlink() // The method that controls the LED, sets up the servos to stay for a certain amount of time, 
// and displays what is happening and when the process will end in the serial monitor.
{
  if(minuteTimer == 1)
  {
    counter = 60;
    Serial.println("The tea is brewing!");
    for(int i = 0; i < 30; i++)
    {
      Serial.println(counter);
      counter--;
      digitalWrite(led, HIGH);
      delay(1000);
      Serial.println(counter);
      counter--;
      digitalWrite(led, LOW);
      delay(1000);
    }
    digitalWrite(led, HIGH);
  }
  else if(minuteTimer == 2)
  {
    counter = 120;
    Serial.println("The tea is brewing!");
    for(int i = 0; i < 60; i++)
    {
      Serial.println(counter);
      counter--;
      digitalWrite(led, HIGH);
      delay(1000);
      Serial.println(counter);
      counter--;
      digitalWrite(led, LOW);
      delay(1000);
    }
    digitalWrite(led, HIGH);
  }
  else if(minuteTimer == 3)
  {
    counter = 180;
    Serial.println("The tea is brewing!");
    for(int i = 0; i < 90; i++)
    {
      Serial.println(counter);
      counter--;
      digitalWrite(led, HIGH);
      delay(1000);
      Serial.println(counter);
      counter--;
      digitalWrite(led, LOW);
      delay(1000);
    }
    digitalWrite(led, HIGH);
  }
  else if(minuteTimer == 4)
  {
    counter = 240;
    Serial.println("The tea is brewing!");
    for(int i = 0; i < 120; i++)
    {
      Serial.println(counter);
      counter--;
      digitalWrite(led, HIGH);
      delay(1000);
      Serial.println(counter);
      counter--;
      digitalWrite(led, LOW);
      delay(1000);
    }
    digitalWrite(led, HIGH);
  }
  else if(minuteTimer == 5)
  {
    counter = 300;
    Serial.println("The tea is brewing!");
    for(int i = 0; i < 150; i++)
    {
      Serial.println(counter);
      counter--;
      digitalWrite(led, HIGH);
      delay(1000);
      Serial.println(counter);
      counter--;
      digitalWrite(led, LOW);
      delay(1000);
    }
    digitalWrite(led, HIGH);
  }
}

void teaTime() // Moves the servos to place the tea bag in the mug slowly.
{
  if(minuteTimer > 0)
  {
    // sweep the servo from 0 to 180 degrees in steps
    // of 1 degrees
    for (i = 0; i <= 25; i += 1) 
    {
      // tell servo to go to position in variable 'i'
      servoOne.write(i);
      // wait 15 ms for servo to reach the position
      delay(15); // Wait for 15 millisecond(s)
    }
    for (i = 0; i <= 50; i += 1) 
    {
      // tell servo to go to position in variable 'i'
      servoTwo.write(i);
      // wait 15 ms for servo to reach the position
      delay(15); // Wait for 15 millisecond(s)
    }
  }
}

void startingPos() // Moves the servos to their loading/starting position for the process.
{
  servoOne.write(0);
  delay(15);
  servoTwo.write(0);
  delay(15);
}

void returnPos() // Moves the servos slowly back.
{
  for (i = 50; i >= 0; i -= 1) {
    // tell servo to go to position in variable 'i'
    servoTwo.write(i);
    // wait 15 ms for servo to reach the position
    delay(15); // Wait for 15 millisecond(s)
  }
  for (i = 25; i >= 0; i -= 1) {
    // tell servo to go to position in variable 'i'
    servoOne.write(i);
    // wait 15 ms for servo to reach the position
    delay(15); // Wait for 15 millisecond(s)
  }
}

void buzzerTune() // The tune that is played through the buzzer when the tea making process is completed.
{
  for (int thisNote = 0; thisNote < songLength; thisNote++){
    // determine the duration of the notes that the computer understands
    // divide 1000 by the value, so the first note lasts for 1000/8 milliseconds
    int duration = 1000/ durations[thisNote];
    tone(12, melody[thisNote], duration);
    // pause between notes
    int pause = duration * 2;
    delay(pause);
    // stop the tone
    noTone(12);
  }
}

void welcomeMessage() // The welcome message that's displayed to the user when the program is started or goes back to the start.
{
  Serial.println("Hello and welcome to the tea brewing station!");
  Serial.println("Please set up the amount of time (1-5 minutes) you would like your tea to be brewed.");
  Serial.println("(Set the time by turning the potentiometer, the time will be displayed on the seven segment.");
  Serial.println("Once you have set the time, please push the button in order to start the process.");
  Serial.println("(Please do not push the button more than once for a smooth tea brewing process.)");
  Serial.println("A tune will play when the tea is ready, or you can watch the countdown on the serial monitor if you're bored.");
  Serial.println("Once the tea is ready, simply pick-up the mug and you're good to go. You're welcome to repeat the process after everything is done!");
  Serial.println("Enjoy!");
  welcome++;
}

// The main code where everything happens.
void loop() 
{
  // As a back-up/cautionary measure so that the servos are correctly set up.
  startingPos();
  // The welcome message whenever the program starts, or once everything is done and it's prepared for another run.
  if(welcome == 0)
  {
    welcomeMessage();
  }
  // read the input on analog pin 0:
  sensorValue = analogRead(A0);
  // print out the value you read:
  delay(10); // Delay a little bit to improve simulation performance
  // Controls 7 segment with potentiometer to set up how long the tea should be brewed.
  if(sensorValue <= 203)
  {
    digitOne();
    delay(20);
    minuteTimer = 0;
    minuteTimer = minuteTimer + 1;
  }
  if(sensorValue >= 204 && sensorValue <= 407)
  {
    digitTwo();
    delay(20);
    minuteTimer = 0;
    minuteTimer = minuteTimer + 2;
  }
  if(sensorValue >= 408 && sensorValue <= 611)
  {
    digitThree();
    delay(20);
    minuteTimer = 0;
    minuteTimer = minuteTimer + 3;
  }
  if(sensorValue >= 612 && sensorValue <= 815)
  {
    digitFour();
    delay(20);
    minuteTimer = 0;
    minuteTimer = minuteTimer + 4;
  }
  if(sensorValue >= 816 && sensorValue <= 1023)
  {
    digitFive();
    delay(20);
    minuteTimer = 0;
    minuteTimer = minuteTimer + 5;
  }
  buttonStateOne = digitalRead(buttonOne); // Reads when the button is pushed.
  delay(25); // Delay to improve simulation process.
  if(buttonStateOne == 0) // Starts the actual tea brewing if the button is pushed.
  {
    teaTime();
    ledBlink();
    returnPos();
    buzzerTune();
    digitalWrite(led, LOW);
    Serial.println("The tea is ready! Bonappetit!");
    buttonStateOne = 1;
    welcome--;
  }
}
2

Read the forum guidelines to see how to properly post code.
Use the IDE autoformat tool (ctrl-t or Tools, Auto format) before posting code in code tags.

The way that the code is posted it is very difficult to copy to a text editor or IDE to examine and verify.

Please edit your original post to put the code in code tags.

3

I count 65 notes but only 64 durations. The last duration will be read off the end of the array.

4

Whenever you have multiple arrays which must have the same size, you should declare that size since this will allow the compiler to provide an error if something is missing or too much.

#define ARRAY_SIZE 10 //or SONG_SIZE
const byte array1[ARRAY_SIZE] = { 1, 2, 3, 4, 5, 6, 7, 8, 9, 0 }; //OK
const byte array2[ARRAY_SIZE] = { 1, 2, 3, 4, 5, 6, 7, 8, 9 }; //Not OK

for (int i = 0; i < ARRAY_SIZE; i++)
{
  Serial.println(array1[i] + array2[i]);
}
5

There is nothing wrong with supply too few initial values.

Where it goes wrong is using whatever ends up in uninitialised locations.

Would the remaining spot(s) be 0 in this case?

a7

6

@alto777 I've not tested, the compiler should warn about a const array not filled properly. Anyhow the code would not read out of bounds and the error would (probably) be noticeable.

EDIT: Just tested, no warning, missing initializers are zeroed.

7

I don't know why you are not supposed to push the button twice, but the program should take care of that, not the user. Never count on the user no to mess up (even if the user is yourself).

8

Yeah, I wondered if the const would make a difference.

The only warning I’ve ever gotten is the obvs wrong “too many initialisers”, which I often do deliberately, add an extra one, take the complaint and derive a good clue that you have the right number.

a7

9

Oh I just put that as a cautionary measure. I can probably just remove that message since pressing the push button more than once doesn't affect anything.

10

Thank you for telling me, I edited the original post to include those. Unfortunately the bot detected it as spam for a while, but all is good!

11

Thank you so much, and yes just like Danois said, there is no errors when compiling the code. I'll try adding an extra one to see if it works once I get access to my project again. Hopefully it should go well, I'll keep you guys updated.

12

It works now, thank you both alto and Danois! Thank you so much!

13

Was the number of elements in the array that was too short all you had to change?

a7

14

Yeah, the note durations array was 1 off, so just adding an extra duration removed the error. Also managed to fix all of the bugs, so the whole project is complete now.

15

when you say your code stops durring the noise i would assume the problem is in the
buzzerTune() function

When you say it stops at the last note, look at the last note. it is zero.
zero is a time increment for your pitch. if you ask for a pitch to move at zero. it will take exactly forever to complete. LOL.

16

Yeah, it was a dumb mistake on my part, I'm glad it was just the missing duration note that was the problem.

17

This topic was automatically closed 180 days after the last reply. New replies are no longer allowed.