Code Structure Advice

I'm running it on a mega 2560. It's a few years old not sure what revision is any.